I love finding a mysterious NOP in a released binary.
-
I love finding a mysterious NOP in a released binary.
Someone patched this. Compilers don't usually just stick a NOP in the middle of a functional call.
Unless they're MIPS or similar, I guess, but there are very few MS-DOS games that run on MIPS processors
-
"how do I tell if I've inaccurately marked data as code?"
well, does it ever use the XLAT instruction? then yeah, it's wrong.
-
or AAS/DAA/AAD/DAS/AAM.
The chances that the code you're looking at legitimately uses BCD are approximately zero
-
@foone This should honestly be part of the heuristics Ghidra should use. Plus, war you if you do it by accident. Too many times I had wrongly detected (or previously mistakenly declared as) code sections I had to clean up by squinting my eyes and saying “nah, this aint lookin like legit code”
-
@ljrk yeah!
-
@foone "there are very few MS-DOS games that run on MIPS processors"
Careful. You know people around here are prone to take that as a challenge.
-
@nuxi all according to plan
-
@foone I'm pretty sure the Borland compilers do sometimes insert NOPs for alignment under certain circumstances
-
@lethal_guitar Dang it. This is Borland C++, so maybe it's not such a tell after all
