Spam not being caught

PeterJones

We haven't, as of yet, because we don't have enough coverage to approve such posts 24/7, and we get a lot of international posts -- we hadn't wanted to make users wait until one of the moderators was awake before their post is made public and starts getting replies. But maybe we'll have to.

julian

@PeterJones the way your spam is presented is novel, even clever. I don't think I've encountered that kind of spam before (or maybe it slipped through! )

Putting in an icon for external URLs makes sense, I'll look into adding.

<baris>

Maybe it's time to build https://github.com/NodeBB/NodeBB/issues/6021

julian

@baris Indeed

I've been looking at adding that fa-external-link icon via markdown plugin. Takes a little more effort than I thought.

<baris>

@julian might be alot simpler if it's done client side?

julian

@baris probably, yes just needed to spend a whole day to come to this conclusion

julian

@PeterJones This is now available in Markdown v12.2.1

Keep in mind I also refactored the plugin client js and updated the ACP template a fair bit, that's why it took so long

<baris>

Minimum reputation for posting links is also coming in 3.4.0

PeterJones

Both of those have been working since we upgraded to 3.4.1, so that's great.

Unfortunately, with "minimum reputation for posting links" enabled, it also means that new users cannot (easily) reply to posts, because replies automatically include @-mentions (which count as links) and a link to the post they replied to (which counts as a link). It would be nice if the link reputation-for-link requirement were only for external links.

Though as I'm replying to this post, I see neither an automatic @-mention nor a link to the previous reply, so that implies that there's a way to turn off that automatic text. However, I cannot find a setting that turns those off. In 3.4.1, how can I turn those automatic "links" off? If I do that, it would allow newer users to reply more easily.

Thank you.

<baris>

@PeterJones those links are added when you use @mention like @PeterJones or when you quote someone with the quote button on their posts. We should definitely fix it so they don't count against links. I think internal links to the forum shouldn't count against that setting.

julian

Nice catch @PeterJones

julian

Don't count internal links towards link count in `min:rep:post-links` by julianlam · Pull Request #12130 · NodeBB/NodeBB

Building on #6021, the restriction should only apply to external links. Internal links are always (almost always? prove me wrong) OK.

GitHub (github.com)

This is fixed and slated for release with v3.6.0

PeterJones

@julian said in Spam not being caught:

This is fixed and slated for release with v3.6.0

Thanks for the fast fix!