[nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB

phenomlab

@phenomlab said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

@thebronx I get an error after enabling this plugin then posting
Internal Error.
Oops! Looks like something went wrong!

/api/topic/22/reputation-system-update/1

Cannot read properties of undefined (reading 'pid')
Not sure if this is related to the plugin or not, but I'm going to disable and see if that makes any difference

Well, it's not this plugin, but it seems the case of this issue is nodebb-plugin-question-and-answer ! Disabled that, and everything works as expected.

TheBronx

@phenomlab nice

zandertrek

Where do I enter commands such as $ npm install random-plugin? Is there a terminal window somewhere like in Linux?

TheBronx

@zandertrek said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

Where do I enter commands such as $ npm install random-plugin? Is there a terminal window somewhere like in Linux?

If you don't know where, that is a good reason not to try hehe. If you installed NodeBB yourself, you have a server you can SSH in and thus go to the folder where NodeBB was installed to run the command.

If you did not install it yourself, and thus are using a managed instance, then you probably cannot run commands.

The thing is, I don't know why you cannot see the v1.2.1 that was released yesterday. And I don't see a "refresh" button somewhere to refresh the list of available plugins.

Maybe @baris or @julian know this: why does he see v1.1.3 instead of v1.2.1 of nodebb-plugin-reputation-rules?
Is there a cache that we have to refresh? Is there something wrong with my package.json?

Edit:
He is running nodebb 1.18.1
I uploaded v1.2.0 yesterday with compatibility ^1.18.2
Then uploaded v1.2.1 with compatibility ^1.18.0
Not sure if that has anything to do with the issue.

Thank you

zandertrek

@thebronx v1.2.1 appeared in the plug-ins list. I "installed" it. But it did not show up in my INSTALLED plug-ins list. I went back to the FIND PLUG-INS list and, behold, v1.2.2 was there but v1.2.1 was gone. So I installed v1.2.2 which does show up in my INSTALLED list. However, it seems to be incompatible with my NodeBB v1.18.1 which is understandable (I see no settings for the plug-in, but the standard REPUTATION AND FLAGS settings are completely grayed out and don't accept changes).

Am I correct in thinking that is not compatible, or are the settings located somewhere I am not looking?

TheBronx

@zandertrek have you activated the plugin after installing it?
v1.2.2 is compatible, should work fine, I have been doing some refactoring in the code to make it easier to maintain, no additional functionality compared to v1.2.1

Settings should be under Plugins -> Reputation Rules

gotwf

@zandertrek This occurs more often than one may imagine among newer users so don't feel bad if you missed it.

@thebronx said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

have you activated the plugin after installing it?

zandertrek

After a considerable learning process, I have v1.2.2 up and running well. Thanks to @TheBronx for reviving this great plug-in. I feel it adds another dimension to the forum experience.

TheBronx

@zandertrek said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

After a considerable learning process, I have v1.2.2 up and running well. Thanks to @TheBronx for reviving this great plug-in. I feel it adds another dimension to the forum experience.

I am glad you find it useful! Feel free to report any issues you may find.

Thank you!

zandertrek

@thebronx said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

I should probably remove the setting "Max downvotes per day" as that is now supported by NodeBB out of the box, or maybe try and change the main setting from the plugin instead of having two different values doing the same.
But for now it will stay. You can just set it to zero in one place and the configure the other, not that big of a deal.

I see that the plugin overlaps with standard settings in two places:

Minimum reputation to downvote posts
Max downvotes per user per day

TheBronx

@zandertrek said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

I see that the plugin overlaps with standard settings in two places:

Minimum reputation to downvote posts

Max downvotes per user per day

yep, I still don't know how to approach this problem
On one side, I like to have all the reputation settings on the same screen
On the other hand, it makes no sense to have two settings controlling the same thing, potentially conflicting

Should I remove the duplicated settings from the plugin?
Should I try and leave them but mirroring the configured values of the original ones? Not sure I can do this.

For now you can just use the setting you like the most, and leave the other one to zero (I think) to disable it.

zandertrek

@thebronx I just experimented with Min rep to downvote and found that the overlapping settings generally play nicely together. The most stringent rule (between the two) is used. If the built-in barrier is met the error message given is "You don't have enough reputation to downvote this post". If the plugin barrier is met the error message is "You don't have enough reputation".

zandertrek

My plan is to keep the same values in both fields. It works fine and is the least confusing to me.

TheBronx

@zandertrek if you are not going to change those settings frequently, fine, keep them the same
if you want to experiment, I would set one to zero and just change the other one to simplify
cause like you said, the most restrictive setting will take precedence
at least that is how I test it

if you have any suggestions let me know cause the idea behind the plugin was to make sure that reputation could be trusted but how that is achieved is very tricky
the rules that have been implemented should help, but I am sure there is more that could be done

One thing I would like to have is a log where I can see how a user got his reputation. All the votes, with their weights, the link to the post and the link to the user who voted for him.
Would be useful to tune the settings and maybe think of new rules.
Maybe in the admin panel, maybe public not sure. Anyways, I think it would be useful but it is just an idea at this point.

zandertrek

@thebronx The voting log is appealing to me. Definitely from the admins perspective it would be a learning tool - a way to observe trends, patterns, and anomalies. For me, this log may be most useful as a .csv that included all votes with associated information (including links to the post) that I could analyze numerous ways.

zandertrek

@thebronx said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

if you have any suggestions let me know

I see that more communication with the user is an area for growth in the reputation-voting-privileges ecosystem.

Notifying users when they have accumulated enough reputation to access priviledges including upvote, downvote, profile photo, cover photo, AboutMe, website, and signature.
Including specifics in voting error messages. Currently the error messages are generic ("you don't have enough rep") but the user would really appreciate knowing how far they have to go ("you need x more rep before you can upvote") and it gives the user a clear goal if they choose to accept the challenge.

I hope these are reasonable suggestions.

TheBronx

@zandertrek those are great ideas!
The first one should be in NodeBB or another plugin probably, as this plugin is more about upvoting/downvoting and not about other privileges.
But the idea of showing notifications like "you have X votes left this month" or "no more votes remaining today" and things like that could be a good way of educating users on the limits of reputation instead of just error messages.
Regarding the second one, not sure if the error popups have enough space for more detailed messages, or if there is another way of showing feedback but it would be really nice to have that. Definitely worth exploring.

Thank you for the suggestions. Not sure if I will implement them at this point but I will dedicate some time to think and mess around to see how far I can go.

TheBronx

I've been improving error messages a bit, now they include some important bits of information depending on the error:

Same for the Spanish translation of course:

I will be including these changes in the next release.

Edit: v1.2.3 was released with these changes

zandertrek

This post is deleted!

zandertrek

@thebronx I experienced some difficulties receiving v1.2.3 but it is now installed. I tested it using a dummy account and I really appreciate the higher level of communication that this version provides. I know the users will also.