voting not working

Rex Huang

I want to vote a post in my nodebb, but nothing happen, no error log.
how can I debug?

julian

Hi there,

Can you please provide the following information to help us debug?

Server or client operating system (if applicable)
NodeBB version and hash
- To get the hash, run git rev-parse HEAD from the root of your NodeBB folder
If applicable, theme versions
- npm ls nodebb-theme-persona
Do you see any errors in the client-side?

Thanks!

Rex Huang

CentOS release 6.6 (Final)
#git rev-parse HEAD
d9af2242a7c7fc92318a83bd46e4f849094960f2
I am not using nodebb-theme-persona, but nodebb-theme-lavender.
error at client-side
"Error
Invalid Data"

psychobunny

This rings a bell, I think I fixed this recently. Can you update to latest 0.7x and latest lavender and let me know?

EDIT: lav's dependant on vanilla as well so update that too please

Rex Huang

I had changed to nodebb-theme-persona, it has the same problem.

Rex Huang

I found the error is come from favouriteCommand, and added some debug output:

    function favouriteCommand(socket, command, eventName, notification, data, callback) {
    winston.info('command=`' + JSON.stringify(command) );
    winston.info('eventName=`' + JSON.stringify(eventName) );
    winston.info('notification=`' + JSON.stringify(notification) );
    winston.info('data=`' + JSON.stringify(data) );

        if(!data || !data.pid || !data.room_id) {
    winston.error('favouriteCommand invalid-data');
            return callback(new Error('[[error:invalid-data]]'));
        }

Rex Huang

the debug output as below:

4/6 03:55 [387] - info: command=`"upvote"
4/6 03:55 [387] - info: eventName=`"voted"
4/6 03:55 [387] - info: notification=`"notifications:upvoted_your_post_in"
4/6 03:55 [387] - info: data=`{"pid":"85","room_id":""}
4/6 03:55 [387] - error: favouriteCommand invalid-data

Does anyone have idea what's going wrong?

Rex Huang

temp solution:

-- 	if(!data || !data.pid || !data.room_id) {
++ if(!data || !data.pid) {

<baris>

That's weird the room_id should be something like topic_<topic_id> where topic_id is the id of the topic you are in.

When this happens what is the value of app.currentRoom client side?

Rex Huang

The code is in src/socket.io/posts.js, but I can't find the topic_id and app.currentRoom you mention.