header.tpl changes
-
There are some changes to header.tpl. If you have your custom theme with header.tpl, you should modify the <script> block in it to match the following.
<script> var RELATIVE_PATH = "{relative_path}"; var config = JSON.parse('{configJSON}'); var app = {}; app.user = JSON.parse('{userJSON}'); </script>
See here for a sample in lavender.
We still have the
app.uid
,app.username
andapp.isAdmin
properties but these will be deprecated in a future release, please use theapp.user
object from now on, it also has theapp.user.isAdmin
property.Related issues and commits
https://github.com/NodeBB/NodeBB/issues/2528
https://github.com/NodeBB/NodeBB/issues/2534https://github.com/NodeBB/NodeBB/commit/8ed06eb7734d5280d16b630fdca8e9db81f0006f
https://github.com/NodeBB/NodeBB/commit/04084807c2a594228e955f8b24f888ae0d5772a1 -
@baris I started working on a more SEO friendly theme/plugin. I hoped I could keep all the changes within a lavender derived theme, but I cannot. Some changes will be in the core. FOr example, server side rendered pagination. I am looking for some advice on how to coordinate making changes in a theme and core nodebb?