Who is in? Plugin

xbenjii

Really nice idea, though might I suggest something like

/(?:who is|who's) in\?/gi

to capture the text.

Schamper

Nice! Is there source available yet?

How do you parse the "who is in" string? What happens if someone puts it in the middle of a sentence? Does it also work on every post in a topic of just first post?

xbenjii

@Schamper said:

Nice! Is there source available yet?

How do you parse the "who is in" string? What happens if someone puts it in the middle of a sentence? Does it also work on every post in a topic of just first post?

Looks like it's just a direct replace on each post, not just the first.

postContent = postContent.replace(/Who is in\?/gi, mainTemplate);

Schamper

@xbenjii kind of dangerous, any post with the magic string in it somewhere would get a match. Might not always be the expected behaviour.

Personally, I'd do something like /^Who is in\?$/gim, but that's me

xbenjii

@Schamper said:

@xbenjii kind of dangerous, any post with the magic string in it somewhere would get a match. Might not always be the expected behaviour.

Personally, I'd do something like /^Who is in\?$/gim, but that's me

If you wanted to add some sort of description though, that wouldn't work. Maybe create a template, something like:

Some text.
{who-is-in}
Some more text.

Then you could do

/\{who-is-in\}/gi

Schamper

@xbenjii why wouldn't it work? That regex should work as long as there's a line with "Who is in?". You can have as much text around it in different paragraphs as you want. Maybe you didn't notice the m modifier?

xbenjii

@Schamper said:

@xbenjii why wouldn't it work? That regex should work as long as there's a line with "Who is in?". You can have as much text around it in different paragraphs as you want. Maybe you didn't notice the m modifier?

Whups, missed that xD. Just saw the start/end anchors.

arasbm

Thanks for the feedback so far. Looks like most of you don’t really like the idea of looking for an ordinary sentence to insert the plugin. My thinking was that by doing so, some forum users will discover the plugin accidentally. Specially since you immediately see the plugin in the preview. But as was pointed out, this method of inserting the plugin is not very customizable.

Perhaps, instead of playing the guessing game as to which sentence to capture, I should switch to a good old wordpress style plugin shortcode. Maybe something flexible like [whoisin] that would also support a couple of custom attributes, for example [whoisin add-btn-text="I am in!" remove-btn-text="Remove me" height="5rem"]. I think this way it will be easily customizable for each different use case.

@Schamper I think I saw you had used wordpress style shortcode for some of you plugins. Is this a recommened format for inserting plugins into posts or does NodeBB has it's own shortcode style? Any other suggestions about the shorcode format, or what attributes should be customizable?

Is there source available yet?

Of course, here is the source code

Thanks again for trying it out. This plugin is still very tiny and can be improved easily. So please keep the suggestions coming!

psychobunny

Nice, well if you don't win the whole thing, you're definitely well on track for winning the "new developer" prize

Schamper

@arasbm Never really thought about it as Wordpress shortcode style, but I suppose it does look like that. I just tried to think of something that kind of looked like markdown, but I also looked at what syntax other forum software that use markdown are using for some features.

chas

This is awesome,

2 bugs for me,
-cant click on anyone that "is in" ... redirects me to 404 error.
-if i reply inside the same thread to create another "who is in" it works

arasbm

@chas thanks for the report!

cant click on anyone that "is in" ... redirects me to 404 error.

Good find, I will fix it this weekend

if i reply inside the same thread to create another "who is in" it works

I am not sure what the right behaviour would be here. Should I limit the whoisin plugin to only the OP? My thinking was that it would be nice if anyone could start one in a discussion, and if someone else attempts to add another one, it will be just a copy of the first one.

meetdilip

Nice work @arasbm

arasbm

@meetdilip thanks mate! Don't forget to vote for "who is in" if you like the plugin

meetdilip

@arasbm said:

@meetdilip thanks mate! Don't forget to vote for "who is in" if you like the plugin

I have already upvoted the first post, if that is what you mean

arasbm

@meetdilip No, I meant in the polls for the October plugin contest. Here are the links to the polls:

You can vote in both Thanks!

Shaun

@arasbm said:

I am not sure what the right behaviour would be here. Should I limit the whoisin plugin to only the OP? My thinking was that it would be nice if anyone could start one in a discussion, and if someone else attempts to add another one, it will be just a copy of the first one.

I'd say first post only, but you could preserve the option through a configuration setting and let each forum admin decide for themselves.

chas

+1 for first post only

specifying a limit per event could be nice

Still love the simplicity!

arasbm

I made some changes and bug fixes to this plugin. The latest version (0.0.6) works with nodebb 0.6.0 or higher only. Here are the notable changes:

Usage Examples

To use this plugin in a post just insert [whoisin] anywhere in a post. Here are some other examples of using the shortcode:

    [whoisin title=(Will you attend this event?) iamin=(Yes I will!)]
    [whoisin iamin=(I'm down!)]

Current Features

One whoisin widget per post
Ability to add and remove yourself
Allows custom title and button name in shortcode
Automatically subscribe user to the current topic

I hope you will find it useful.

zero

this plugin is awesome but i had some thoughts and maybe a bug

first off, there should be an option to make it first post only
second, say i have 100 users "in" does it show them all or stop at a certain number or once it meets the width of its container? maybe make it only list 5 people then plus some more, like this
[avatar] [avatar] [avatar] [ + 10 more people ] [ X ]
and clicking the more brings up a popover with all "in people"

there also seems to be a bug on the user profile page where if this was used in a recent post, its displayed to both logged in and non logged in users but cant be interacted with. it doesnt display avatars, just [ + I am in! ] [X]