Youtube Lite

a_5mith

@psychobunny Not yet, but my laptops overheating slightly, so didn't want to lose the post. If you spot anything wrong with it while I'm cleaning the fan, mind submitting a PR. I'll look when my laptops cleaned.

psychobunny

Pointing at your repo now

https://github.com/a5mith/nodebb-plugin-youtube-lite/blob/master/plugin.json#L8 callbacked is deprecated, I imagine it's still on my own plugin as well (having it in won't make a difference any time soon, it'll just spit out a warning, I think)

And yeah, the composer hook itself looks good to me

a_5mith

Yeah, I've actually got some console logging on the composer bit, but nothing happens. I'll have to look at Julian's github plugin, as it's similar to that.

a_5mith

Ok, looking at this now, action:composer.posts.reply is the only one that fires when a new post is made. However i'm not sure if it's happening too early. As the video doesn't load.

Latest version is currently 0.0.3.

npm install nodebb-plugin-youtube-lite@latest

###Changes###

Adjusted z-index bug that caused title and play button to appear over the composer
Changed how the video loads in preperation for me working out how hooks work. (Videos won't stop and refresh when a new video is posted)

julian

Was it z-index @a_5mith, or was it wmode?

a_5mith

@julian z-index I hope. Setting it to 2 dropped it behind the composer.

Hưng Thành Nguyễn

@a_5mith this only works with logged in users? I have try withouth logged in and they just show nothing?

a_5mith

@Hưng-Thành-Nguyễn said:

@a_5mith this only works with logged in users? I have try withouth logged in and they just show nothing?

Works for me as a guest on my site. There's certainly no code that would stop guests from viewing. Tried refreshing the page?

Hưng Thành Nguyễn

@a_5mith oh, sorry. I don't know why but my forum not showing any widgets with not logged in users.
Some plugins not showing, either.
Really weird

a_5mith

@Hưng-Thành-Nguyễn said:

@a_5mith oh, sorry. I don't know why but my forum not showing any widgets with not logged in users.
Some plugins not showing, either.
Really weird

If you still have an issue after you've resolved that issue, I'll take a look. But I promise it works.

Hưng Thành Nguyễn

@a_5mith yup, trying to figure out what's going wrong. I've done nothing, just upgrade the nodebb and boom widgets have been gone T__T

Hưng Thành Nguyễn

@a_5mith yeah, it's working now, bro. It's because of shoutbox plugin, which disabled all function. Thanks man

a_5mith

@Hưng-Thành-Nguyễn said:

@a_5mith yeah, it's working now, bro. It's because of shoutbox plugin, which disabled all function. Thanks man

Ah yeah, make sure it's up to date. I believe that issue was fixed.

Hưng Thành Nguyễn

@a_5mith with newest version I have to disable it with not logged in users. Btw, shoutbox is not working with not logged in users, either.
Reported to the dev, hope he will fix this issue soon.

julian

@Hưng-Thành-Nguyễn said:

Btw, shoutbox is not working with not logged in users, either.

I think that's intentional...

a_5mith

@julian said:

@Hưng-Thành-Nguyễn said:

Btw, shoutbox is not working with not logged in users, either.

I think that's intentional...

There's an option to display for guests in the plugin. But you need to log in to post to it.

Hưng Thành Nguyễn

@julian but we still have to disable it by hide its widget with not logged in users.
If not, it will break the whole forum with its non-logged in checking function.
So it will be useless

Hưng Thành Nguyễn

@a_5mith I can't find the option for that.
I have to hide its widget manual.

a_5mith

@Hưng-Thành-Nguyễn said:

@a_5mith I can't find the option for that.
I have to hide its widget manual.

My mistake, there isn't one, I just have hide from anonymous users ticked from the widgets menu.

Hưng Thành Nguyễn

@a_5mith yeah, even in new version he has made it can hide from the anonymous and not break the forum. But it's funny that this plugin will not work if I place shoutbox's widget in global header. Still have to disable it for anonymous.
Anw, that's the solution for now