Pagination 404 issue.

a_5mith

I'm using pagination on my forum, and for some reason, pages 2 & 3 of topics inside one of my categories 404s.

Forum is here, try to access page 2 or 3.

<baris>

It's just that category? Are there a lot of deleted topics in that category?

Also you can put a console.log(err) at https://github.com/NodeBB/NodeBB/blob/master/src/controllers/categories.js#L162 too see any error messages.

a_5mith

@baris Nope, no deleted topics in that category at all.

If I set it back to infinite scroll, when I try to go beyond 50, I get "Error: Teaser doesn't exist"

It also won't find those topics if I search for a topic that I know is either on page 2 or 3.

Don't think I did the console log wrong, but nothing pops up except 404 not found.

<baris>

Modify the code so it looks like below,

	], function (err, data) {
		if (err) {
           console.log(err);    
			if (err.message === '[[error:no-privileges]]') {
				return res.locals.isAPI ? res.json(403, err.message) : res.redirect('403');
			} else {
				return res.locals.isAPI ? res.json(404, 'not-found') : res.redirect('404');
			}
		}

And let me know the error message, "Error: Teaser doesn't exist" might help me debut too. Will take a look.

a_5mith

@baris Have done that, nothing in the error log at all, but, the URLs between trying to access page 2 and trying to access page 4 (which works) are different.

?page=3&_=1403984765537 - 404
?page=4 - 200 OK

console log code is still in if I'm missing what I'm looking for.

<baris>

Stop the forum then run it with node app then check the server console to see if it prints out the error.

a_5mith

@baris No errors, just warns.

warn: [plugins/nodebb-plugin-mentions] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
warn: [plugins/nodebb-plugin-mentions] In the event of an unresponsive NodeBB caused by this plugin, run     ./nodebb reset plugin="nodebb-plugin-mentions".


warn: [plugins/nodebb-plugin-spam-be-gone] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
warn: [plugins/nodebb-plugin-spam-be-gone] In the event of an unresponsive NodeBB caused by this plugin, run     ./nodebb reset plugin="nodebb-plugin-spam-be-gone".

warn: [plugins/nodebb-plugin-spoilers] staticDir is deprecated, use staticDirs instead

Then starts fine...

<baris>

Well it should print an error when you try to access that page.

a_5mith

@baris Will try again.
Progress, sort of.

info: NodeBB Ready
[Error: [[error:no-teaser]]]
[Error: [[error:no-teaser]]]
[Error: [[error:no-teaser]]]
[Error: [[error:no-teaser]]]

<baris>

Ok now change this line

File not found · NodeBB/NodeBB

Node.js based forum software built for the modern web - File not found · NodeBB/NodeBB

GitHub (github.com)

to

console.log('pid : ' + pid, postData);
return next(new Error('[[error:no-teaser]]'));

Im guessing one of the posts got purged somehow but is still in the list of posts for that topic so you are getting that error. Let me know the output of that console.log.

a_5mith

@baris Spot on...

info: NodeBB Ready
pid : 10825 { pid: '10825',
uid: 'undefined',
timestamp: '1389195689000',
fields: [ 'pid', 'uid', 'timestamp' ] }
pid : 10825 { pid: '10825',
uid: 'undefined',
timestamp: '1389195689000',
fields: [ 'pid', 'uid', 'timestamp' ] }

<baris>

Ok if you are using redis check out that post and see whats going on.

redis-cli
hgetall post:10825

I am committing a fix that will stop the crashing. https://github.com/NodeBB/NodeBB/commit/24aa166ed595f89e0917047e1bd47af8e9c1261f.

But you should still check out why that post doesn't have a uid.

a_5mith

@baris
(error) NOAUTH Authentication required.

I have a password on redis if that helps.

<baris>

Yeah pass that password into redis-cli

redis-cli -h my-host -p 1234 -a mypassword

a_5mith

@baris Thanks, I've got this:

"editor"
""
"content"
"Cheers for the tunes, mix is a bit random but I did what I could - :teeth: It'll be posted later today or tomorrow."
"uid"
"undefined"
"relativeTime"
"2014-01-08T15:41:29.000Z"
"votes"
"0"
"deleted"
"0"
"timestamp"
"1389195689000"
"edited"
"0"
"tid"
"274"
"pid"
"10825"
"reputation"
"0"

EDIT: Just realised that's a post in the topic I was looking for... Small world. That post was also made by a member who deleted their account on my old forum.

<baris>

Looks like that post doesn't have a valid uid, if you know its poster's uid then you can fix it by.

hset post:10825 uid <theiruid>

If they are deleted then just set their uid to 0 with

hset post:10825 uid 0

I guess thats something the importer should do.

a_5mith

@baris That's solved it, there's another one on page 3, so I'll look at that one as well. Thanks a lot.

<baris>

No problem, should take a look at the importer and see how it handles deleted users, I guess it just saved the uid as undefined instead of 0 and that was causing the problem.

a_5mith

@baris Right, I've gone through and set all the UIDs, so I'm no longer getting 404 errors. However the username on each post I've changed is posts.user.username

<baris>

You changed them all to uid 0?

Check hgetall user:0