[nodebb-plugin-twitter] Twitter tweet embed plugin
-
Small request for improvement: in library.js you have the hardcoded link
http://platform.twitter.com/widgets.js
. This gives problems (or warnings) with forums that run using "HTTPS". Can you modify the link to//platform.twitter.com/widgets.js
? That way the browser will automatically choose HTTP or HTTPS depending on which protocol was used for loading the page :). Thanks! -
@igbuend said:
Small request for improvement: in library.js you have the hardcoded link
http://platform.twitter.com/widgets.js
. This gives problems (or warnings) with forums that run using "HTTPS". Can you modify the link to//platform.twitter.com/widgets.js
? That way the browser will automatically choose HTTP or HTTPS depending on which protocol was used for loading the page :). Thanks!Fixed
-
-
@Frédéric-Coubard I'll take a look, seems the plugin hasn't been updated.
EDIT: Will submit a pull request to the original author shortly, if you want it immediately. Go into your node_modules folder inside nodebb and do the following:
git clone https://github.com/a5mith/nodebb-plugin-twitter.git
###Make sure you're in the node_modules folder inside nodebb folder###
Then go into your ACP and enable it, restart your forum. Then on twitter, click the date it was posted to get the URL.
@julian Why didn't you tell me making plugins was this easy?!?! Something clicked while I was looking at this. Feels goood. evil laugh
-
Thank you @a_5mith .
I don't have the reported error in log anymore, yet I don't have the plugin working
I have the tweet url via the date, no problem. I copied and pasted. I paid attention activating the plugin and restarting nodebb. But no joy :-(.
Any idea ? -
@Frédéric-Coubard Can you try the following:
cd ~/nodebb npm rm nodebb-plugin-twitter cd node_modules ls
Look to make sure the plugin is gone.
git clone https://github.com/a5mith/nodebb-plugin-twitter.git
Reactivate the plugin, restart nodebb. Go back to your live site and refresh your cache. Ctrl + F5.
If it still doesn't work, I'd need to have a look at a live example if you have it so I can debug for you. But cache and making sure you're on the right version should work.
(Also the official repo has been updated with my changes, shouldn't take long to appear on npm hopefully)
-
-
@a_5mith uninstalled your way and restarted, not better
Here is the topic with my tweet in messages : http://forums.fabriques-alternatives.org/topic/8/serveur-dev-a20-olinuxino (if it works...). Is it possible to not work on my local network but work on the net ?
-
-
It's not working on our local install anymore?
Should we update something? -
@Giorgio-Chiodi Twitter or imgur?