[Solved] Register/Login links do not disappear when logged in

[shinyidol]

Same thing happened to me when upgrading to 0.4.3 today. Getting latest on the theme fixed it.

[RobD]

Yay, that fixed it.

[RobD]

Hmmm, or maybe not really. The buttons on the top-right now look correct but don't do anything. Also still getting the "require not defined" error. But I'm now on 0.43. In 0.42 it kind of worked correctly once after updating the themes after an unusually long delay. Maybe that happened randomly, but I can go down to 0.42 again and recheck if it helps.

[Scuzz]

I've just updated and we have the login and register buttons even when we have logged in. I'm not sure if this is a theme issue with sea wolf or if it's a nodebb issue. SeaWolf is based off Vanilla so if any chnages happen in the vanilla theme then they should propagate over to my theme.

[julian]

There were some changes re: the header buttons recently , though I am unfamiliar with the exact change. @baris?

Also make sure your themes are up-to-date... 0.0.19-53 and 0.0.25-16, respectively

[Scuzz]

@julian apparently the update command for npm didnt actually update it...
All working now.

[julian]

@Scuzz Beats me as to why. npm i nodebb-theme-vanilla installs 0.0.19-35 instead of -53. Not sure if that is still the case, but I updated the package.json file in the v0.4.x branch which might resolve this.

[Dazzuh]

@julian said:

@Scuzz Beats me as to why. npm i nodebb-theme-vanilla installs 0.0.19-35 instead of -53. Not sure if that is still the case, but I updated the package.json file in the v0.4.x branch which might resolve this.

npm i nodebb-theme-vanilla still installs 0.0.19-35, using npm i [email protected] installed the correct one for me

[baris]

@julian yeah I changed it so that the buttons are shown/hidden in the templates on render instead of after the page renders with a socket call, makes it much faster on mobile.

[Scuzz]

The login / Register is now fixed but now the reply and create thread buttons do not appear.

[julian]

@Scuzz on 0.4.3 or latest master?

If former: your themes are too new
If latter: your themes are too old.

[a_5mith]

This post is deleted!

[Scuzz]

Ok, after a ./nodebb upgrade everything seems to be working correctly again.

It might be worth keeping the latest npm version of themes compatible with the stable version of nodebb. Keeping the newer versions of the themes github only so people can use them if they want.

I think this may stop any confusion when upgrading themes.

[julian]

A bit of confusion when updating, as the dependency semver for vanilla was "~0.0.19", which unfortunately matched 0.0.20 as well. I've changed it to be "<0.0.20", which seems to be alright.

[shinyidol]

Just installed clean copy of 0.5.2 and having this issue again. Updated my themes and did ./nodebb upgrade and neither helped.

[julian]

Can you run npm ls on both vanilla and lavender so we can see what versions they are?

[shinyidol]

@julian said:

Can you run npm ls on both vanilla and lavender so we can see what versions they are?

[email protected]
[email protected]

[Hưng Thành Nguyễn]

@julian this is exactly what I faced after pull the fixes for restarting function.
The Login link is still there and all the links on navbar are disappeared

[julian]

@Hưng-Thành-Nguyễn If you have 0.1.10, they shouldn't happen, I think...

This commit introduces styling for maintenance mode -- is it on by accident?

[Hưng Thành Nguyễn]

@julian it only happened with the admin account. With normal account the navbar is showing fine.
with the admin account it just show like this: - The navbar links disappeared and only login link remain. This happened when I updated the code for the restarting fixes. Before that everything had been well.