Looks like settings in ACP have changed since last release as @baris pointed out
Unfortunately the nodebb-plugin-quickstart that serves as example/documentation wasn't enough to have the ACP completely working. Settings are no longer empty when I reload that page, but if I navigate somewhere else and then go back to the plugin settings they are empty. No idea why.
I also found this: https://community.nodebb.org/topic/16958/how-do-i-create-a-settings-page-for-my-plugin
But it again points out to the quickstart plugin and that plugin throws errors, it doesn't work in NodeBB 3.1.6

So I could not fix this issue, which is pretty annoying considering how basic this is for a plugin. That's all the time I had, sorry.

Haven't touched this in a couple years and I am not using NodeBB anymore but I can give it a try, if it is something stupid I can probably fix it and release a new version. No promises, will just have a look.

@BrotherGlaucon said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

when I refresh the ACP page all of the settings disappear. It's as though the settings are not being saved to the database. (Yes, I am clicking the 'save' button in the lower right)

What version of NodeBB are you using? Is it with redis or mongodb? So I can try and replicate the problem.

@phenomlab as I said we would first have to decide what to put there instead of the hardcoded formula. A fixed number? a percentage of user's reputation? another formula that I would have to parse?

What would you prefer?
Cause if the problem is that the users complain and you just want to completely remove this limit, well, a toggle to disable this limitation would be the ideal solution.
If instead you like having a limit but you just want a fixed one, like 100, well, then let's have an input there to set the limit that overrides the formula.
Or you could also say: I like that the limit depends on how much reputation the user has but instead of a 10% of that reputation I want a 20%.
Or even more flexible and complex, I want my own formula.

In summary, what is your use case? What do you want to do with this limit?

@zandertrek yes, that is a plugin generated message.

If you go to the plugin settings, right below Global configuration there is a message (more than an option) that says how that number is calculated.
It is a formula: max votes per day is one tenth of the user reputation, with a minimum of 5 votes per day and a max of 50.
This is fixed, cannot be configured right now.

How would you like to override this setting? Would you like to set a fixed number of votes instead? Would you prefer to alter it to 20% or 50% of user's reputation?

The idea behind this being a formula was that the higher the user reputation the less likely that user would be to abuse the system. In other words, low reputation and high number of votes per day was the most risky combination that would allow spam accounts and multi-accounts to take advantage of the system.
But that of course is quite arbitrary. Why 5 votes minimum? Or 50 max? Why 10%?

So yeah, what would you like the plugin to behave?

I've been improving error messages a bit, now they include some important bits of information depending on the error:

Same for the Spanish translation of course:

I will be including these changes in the next release.

Edit: v1.2.3 was released with these changes

@zandertrek those are great ideas!
The first one should be in NodeBB or another plugin probably, as this plugin is more about upvoting/downvoting and not about other privileges.
But the idea of showing notifications like "you have X votes left this month" or "no more votes remaining today" and things like that could be a good way of educating users on the limits of reputation instead of just error messages.
Regarding the second one, not sure if the error popups have enough space for more detailed messages, or if there is another way of showing feedback but it would be really nice to have that. Definitely worth exploring.

Thank you for the suggestions. Not sure if I will implement them at this point but I will dedicate some time to think and mess around to see how far I can go.

@zandertrek if you are not going to change those settings frequently, fine, keep them the same
if you want to experiment, I would set one to zero and just change the other one to simplify
cause like you said, the most restrictive setting will take precedence
at least that is how I test it

if you have any suggestions let me know cause the idea behind the plugin was to make sure that reputation could be trusted but how that is achieved is very tricky
the rules that have been implemented should help, but I am sure there is more that could be done

One thing I would like to have is a log where I can see how a user got his reputation. All the votes, with their weights, the link to the post and the link to the user who voted for him.
Would be useful to tune the settings and maybe think of new rules.
Maybe in the admin panel, maybe public not sure. Anyways, I think it would be useful but it is just an idea at this point.

@zandertrek said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

I see that the plugin overlaps with standard settings in two places:

1. Minimum reputation to downvote posts
2. Max downvotes per user per day

yep, I still don't know how to approach this problem
On one side, I like to have all the reputation settings on the same screen
On the other hand, it makes no sense to have two settings controlling the same thing, potentially conflicting

Should I remove the duplicated settings from the plugin?
Should I try and leave them but mirroring the configured values of the original ones? Not sure I can do this.

For now you can just use the setting you like the most, and leave the other one to zero (I think) to disable it.

@zandertrek said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

After a considerable learning process, I have v1.2.2 up and running well. Thanks to @TheBronx for reviving this great plug-in. I feel it adds another dimension to the forum experience.

I am glad you find it useful! Feel free to report any issues you may find.

Thank you!

@zandertrek have you activated the plugin after installing it?
v1.2.2 is compatible, should work fine, I have been doing some refactoring in the code to make it easier to maintain, no additional functionality compared to v1.2.1

Settings should be under Plugins -> Reputation Rules

@zandertrek said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

Where do I enter commands such as $ npm install random-plugin? Is there a terminal window somewhere like in Linux?

If you don't know where, that is a good reason not to try hehe. If you installed NodeBB yourself, you have a server you can SSH in and thus go to the folder where NodeBB was installed to run the command.

If you did not install it yourself, and thus are using a managed instance, then you probably cannot run commands.

The thing is, I don't know why you cannot see the v1.2.1 that was released yesterday. And I don't see a "refresh" button somewhere to refresh the list of available plugins.

Maybe @baris or @julian know this: why does he see v1.1.3 instead of v1.2.1 of nodebb-plugin-reputation-rules?
Is there a cache that we have to refresh? Is there something wrong with my package.json?

Edit:
He is running nodebb 1.18.1
I uploaded v1.2.0 yesterday with compatibility ^1.18.2
Then uploaded v1.2.1 with compatibility ^1.18.0
Not sure if that has anything to do with the issue.

Thank you

@phenomlab nice

@zandertrek let me try changing compatibility to 1.18.0 instead of 1.18.2, cause you are not using the latest NodeBB one.

I have published v1.2.1 with that and a couple more changes to the admin panel.

If you cannot see the new version you can also install the plugin manually with:
npm install [email protected]
And then activate it on your admin panel, rebuild and restart.

Not sure if there is a way to refresh the list of plugins when you search cause I think those are cached and that is why new versions don't appear immediately.

v1.2.0 has been published
Not much has changed:

• Added compatibility with NodeBB v1.18.2
• Fixed a bug where "Max upvote weight" and "Max downvote weight" were actually being used as a min, instead of a max
• I've removed the "Reload" button from the settings panel as that is no longer required for the changes to apply

I should probably remove the setting "Max downvotes per day" as that is now supported by NodeBB out of the box, or maybe try and change the main setting from the plugin instead of having two different values doing the same.
But for now it will stay. You can just set it to zero in one place and the configure the other, not that big of a deal.

Let me know if everything works.

@zandertrek @phenomlab

@phenomlab said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

@thebronx Awesome - thanks ! If it helps, the current version throws this in the log

2021-09-09T15:50:00.663Z [4567/164128] - error: Error: Cannot find module './database'
Require stack:
- /home/sudonix/nodebb/src/plugins/index.js
- /home/sudonix/nodebb/src/meta/configs.js
- /home/sudonix/nodebb/src/meta/index.js
- /home/sudonix/nodebb/src/start.js
- /home/sudonix/nodebb/require-main.js
- /home/sudonix/nodebb/app.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at Object.<anonymous> (/home/sudonix/nodebb/node_modules/nodebb-plugin-reputation-rules/library.js:4:24)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:94:18)

Yep, that was solved in that old PR.
I have the plugin running in the latest version of NodeBB locally, not much has changed since last time.

Gonna try and debug the thing with reversing votes cause I am not sure why it didn't work last time. If it works I can release a new version today.

@zandertrek @phenomlab

I haven't updated the plugin in a while. It's been a year since I spent some time on it, maybe this branch is more "compatible" but I found a bug while developing that feature and ran out of time so it was never merged: https://github.com/exo-do/nodebb-plugin-reputation-rules/pull/6

Handling the logs, so that each vote is registered with the amount of reputation added/substracted to both the voter and the autor of the post, was quite complex. And then undoing votes. And then handling opposite votes (undo current vote and then handle the opposite vote). And testing it hehe.

I can try again and see how it goes, hopefully plugins haven't changed too much since v1.13

v1.1.0 released

• Now you can disable votes on messages that are "too old" (you can configure this in number of days, or 0 to disable)
• Added nbbpm compatibility 1.0.x and 1.1.x (it should work in older versions, but I am not sure)

Don't know if the problem is the same, but a few years ago I did a custom ad network (because I didn't like DFP) to serve custom banners and Adsense ads. And I had a problem with document.write() too.

The problem was solved overriding the document.write function. Kinda tricky, but worked: before loading the adsense ad, the document.write function is replaced with a custom function that inserts the content into an element, instead of writing it to the dom directly. After inserting the content, the original document.write function is restored.
That is, a one time function replacement.

Here is some code:

var originalFunction = document.write;

overrideDocumentWriteFunction = function(container) {
	document.write = function(content) {
		container.innerHTML = content;
		document.write = originalFunction;
	};
};

And I used it like this:

var div = document.getElementById('adPlacement');
overrideDocumentWriteFunction(div);

var script = document.createElement('script');
script.type = 'text/javascript';
script.innerHTML = '{adsense script content}'
document.body.appendChild(script);

This way the document.write function was customized to ensure the Adsense script worked after the page was loaded.

I haven't tried DFP on NodeBB but maybe this helps.

@Muchsin-Assegaf said in [nodebb-plugin-reputation-rules] Reputation Rules Plugin for NodeBB:

@TheBronx Just to inform you that I'm using this plugin right now.. Its a great one, thank you

Glad to hear that Thank you too!