@baris Thanks a lot for replying, and I apologize for wasting your time
I somehow got the markdown plugin disabled while upgrading, hence the issue.
Enabling it back up solved it.
solmak
Posts
-
After upgrading from v3.6.3 to v3.6.4 i don't see line breaks when writing posts -
How to add custom profile fields to a NodeBB forum ?Thank you @julian you always respond and seem motivated in helping the community. By proprietary I meant no effort has been made to provide clean working examples for the latest nodebb, as in maintenance of such documentation for people jumping into nodebb to replace their old system.
You have a great product here, with so much more potential and I understand you may not have resources and funding to provide so much documentation and maintain working example of a plugin that does CRUD with custom fields/custom data, but it becomes harder for new adopters if they're unable to figure out cost effective way to replace their old platforms which have plethora of 3rd party add-ons and plugins especially dealing with custom fields and custom data.
I take the blame as well, as part of the community it is partly our job to help keep a set of quickstart plugins, documentation, help available to enhance and optimize the process for new adopters. I hope the community gets together and makes something like a curated directory of available plugins, and tags and tracks what versions each supports, and tries to keep a version that supports the latest major version updates.
Thank you for the wonderful product, I keep trying and finding an excuse to adopt it and hopefully I will get there sooner or later.
-
Last group owner able to rescind ownership leaving group ownerless, but code was intended to disallow such actionI am working on an instance of nodebb where Groups are as major part as Categories, i.e. users are allowed to create groups, and have categories dedicated to groups, to moderate their own group/category as owners, etc.
I am finding that Groups part of nodebb hasn't gotten much attention since it is not the major aspect of a the usual use case.
However, here is a bug I found: It appears the program does not intend for any group to be ownerless (as per the code throwing error).
In src/groups/ownership
Method Groups.ownership.rescind
It appears the intention was for the function to make sure this wasn't the last owner who is being rescinded ownership, and throw an error.const numOwners = await db.setCount(`group:${groupName}:owners`); const isOwner = await db.isSortedSetMember(`group:${groupName}:owners`); if (numOwners <= 1 && isOwner) { throw new Error('[[error:group-needs-owner]]'); }
However, isOwner is returning false even when the uid is the owner, and hence they're being removed as owner, and group is able to become ownerless. Nothing wrong with ownerless groups, but since the intention in the code appears to be contrary to the output I felt it appropriate to be in the bug reports category here.
I've replaced the above check, with this function instead, and now I see the error thrown.
const isOwner = await db.isSetMember(`group:${groupName}:owners`, toUid);
Not a major issue, but since I am working on something where groups play a major role (group based site) I found this and wanted to bring this out here.
nodebb v3.7.1
-
How do I add custom user fields to my theme?Thanks a ton @julian I was able to set a boolean field called 'locked' to the groupd data upon group creation, and was able to retrieve it in the group update hooks to work with it!
-
Last group owner able to rescind ownership leaving group ownerless, but code was intended to disallow such action@baris said in Last group owner able to rescind ownership leaving group ownerless, but code was intended to disallow such action:
@solmak nice catch, I've fixed it here will be available in 3.7.2.
Thank you for spending time on this, that was fast!