Or to be more precise, why was this moved to the interstitials step in the registration?

I'm referring to this commit.

I don't really see why this was needed. If the forum requires a valid email address, why not just show that at registration, and not as an after thought? Even if you tick "Require new users to specify an email address" at /admin/settings/user#user-registration, you only get prompted in the optional email input during the interstitials.

@crazycells That's exactly what I mean. The way it was implemented now is very confusing. I get the need to remove email as a factor (GDPR etc), but I don't understand the way it was implemented. And for some forums emails could be crucial, so why put it after registration? I know it's not technically after registration but, still not where expected.

No where else have I encountered a registration where you don't input your information all at once. I even feel that the TOS could be a checkbox with a link to the information.

But in the end it's the decision of the NodeBB team and I don't want to nag about it. I'm just interested in the reasoning.

@julian This worked great. I did this in my main client file (like persona.js).

require(['hooks'], (hooks) => {
	hooks.on('filter:script.load', (data) => {
		const replaceMap = {
			register: {
				target: 'forum/register',
				with: 'replacement/register',
			},
		};

		const replace = replaceMap[data.tpl_url];

		if (replace) {
			const index = data.scripts.indexOf(replace.target);
			if (index > -1) data.scripts[index] = replace.with;
			else data.scripts.push(replace.with);
		}

		return data;
	});
});

Then I can just add my scripts that I want to replace to the replaceMap object.

Turned out I was fetching the post data wrong. I was using getPostData when i should've been using getPostsByPids.

@julian Okay, I'll do that. Thanks!

I'm getting all available categories for a user with categories.getCategoriesByPrivilege. Then I append to it with
categories.getRecentTopicReplies. I'm not getting what I want, only the top post (reply).

What I want is the following; a list of all topics with recent posts (preferably with a max limit in time range), within my available categories. What the client I'm working for want is a feed type thing with all recent activity displayed in one single flow. Then I will also drill down into specific categories but I think I've got that covered.

This is where I'm at so far:

Controllers.renderFeedPage = function (req, res) {
	if (!req.uid) {
		res.render('feed', {});
	}
	let categoriesData;
	let tree;

	async.waterfall([
		(next) => {
			categories.getCategoriesByPrivilege('categories:cid', req.uid, 'find', next);
		},
		(_categoriesData, next) => {
			categoriesData = _categoriesData;

			tree = categories.getTree(categoriesData, 0);
			categories.getRecentTopicReplies(categoriesData, req.uid, next);
		},
		() => {
			const data = {
				title: meta.config.homePageTitle || '[[pages:home]]',
				categories: tree,
			};
			res.render('feed', data);
		},
	]);
};

I haven't found a good example from the forum and I'm reading source code at this point.

If anyone has done something similar I would really appreciate the input and a nudge in the right direction.

Thanks!

So I've been working with NodeBB for a while now and am familiar with several concepts, but one thing I'm not sure about.

If I want to add data to the "global scope" before render. How would I do that?

I know how to get data to the page templates, but that doesn't carry over into the global templates, like the sidebar menu.

How can I, for instance, fetch my categories and place them in the sidebar?

@baris Just what I needed. Thanks a lot!!

Hi all!
I've run into an issue that when I deploy a new version of my theme/plugin, most users don't get any changes done until they do a hard refresh. This only seems to affect the client side Javascript, so everything looks updated, but in reality functionality gets lost.

Has anyone stumbled upon something similar? Is there a better way to release code?

The background in this is that I have forked Persona and built upon it, so all changes to the platform is basically in the theme. Is there a way to make sure all clients receive all updates?

Thanks!

Thanks for the clarification @PitaJ! I did a lot of experimenting but I guess I didn't get the right combination. I think I never tried naming the module with its extension. That might have been it. For anyone who might be interested in the actual solution, here it is:

In file-explorer.js:

define('azure/file-explorer', ['components'], function (components) {
	const FileExplorer = {};

	FileExplorer.init = function () {
		// Init stuff here	
	});

	return FileExplorer;
});

In plugin.json:

"modules": {
	"azure/file-explorer.js": "static/lib/file-explorer.js"
},

In admin.js:

define('admin/plugins/azure', ['settings', 'azure/file-explorer'], function (settings, fileExplorer) {
	fileExplorer.init();
});

In main.js:

$(document).ready(function () {
	require(['azure/file-explorer'], (fileExplorer) => {
		fileExplorer.init();
	});
});

@phenomlab Thanks! I did not know this was available. I'll have a look to see if it fits my needs.

I have a number of custom templates in my plugin and for some reason browsing to them can sometimes cause issues. In Chrome it looks like it works fine, but Firefox seems to have issues.

It seems to originate from ajaxify.loadTemplate.

The template has a script attached to it via plugin.json as such: "static/lib/communityAnalytics.js",.

The script itself is defined as follows define('forum/community/analytics',...

Clicking on a link that takes you to that template/page works fine in Chrome, but fails in Firefox. Browsing directly to that page works in both browsers.

Any ideas?

I don't believe you can do that since what you're asking for is using server side code on the client. To do that, the entire stack would need to be available on the client and everything it does. Basically running NodeBB on the client.

What you could do is set up your own socket and return the desired data that way.

In your library.js file:

const pluginSockets = require.main.require('./src/socket.io/plugins');

// This will add to the sockets object used by NodeBB core
pluginSockets.customFunc = ((socket, dataDoToFetch, done) => {
	const response = 'This response is only a string but it can be whatever you want';
	done(null, response);
});

Then client side:

socket.emit('plugins.customFunc', dataDoToFetch, (err, data) => {
	if (err) console.log('My socket customFunc', err, data);
	else console.log('Do stuff with this', data);
});

I cannot guarantee that this will work out of the box since my setup involves a bit more complexity, but this is the basic idea. Give it a shot!