Hi there,

I'm trying to migrate my forum to 2.8.2. I have an adapted sso plugin, that adds a GET route to find users by external oauth id.
The plugin works on 1.18 but breaks on 2.8.x already on startup.

The error message is:

2023-01-19T22:37:12.434Z [4567/458] - error: [plugins] Error executing 'static:app.load' in plugin 'nodebb-plugin-sso-oauth-faforever'
Error: Route.get() requires a callback function but got a [object Undefined]
    at Route.<computed> [as get] (/usr/src/app/node_modules/express/lib/router/route.js:211:15)
    at proto.<computed> [as get] (/usr/src/app/node_modules/express/lib/router/index.js:521:19)
    at OAuth.load (/usr/src/app/node_modules/nodebb-plugin-sso-oauth-faforever/library.js:91:10)

The code in question is here:
https://github.com/FAForever/nodebb-plugin-sso-oauth-faforever/blob/ec80064334c0e7a210e9ba5b324bd80d17f5a0c9/library.js#L91

router.get('/api/user/oauth/:externalUserId', middleware.authenticateOrGuest, async function (req, res, next) {
			const userId = await db.getObjectField(constants.name + 'Id:uid', req.params.externalUserId);
			if (!userId) {
				return next();
			}
			const userData = await userController.getUserDataByUID(req.uid, userId);

I compared to other route.get and also other plugins and even our project express page, but I don't understand where the error could. I tried removing the async but no success. I also googled the error in general, but it doesn't make me much smarter.

Any help is appreciated.

@julian said in January 2023 Developer Update:

This milestone is mostly symbolic

This concerns me a little as incrementing the major version breaks the compatibility constraints of many plugins for no technical reason. I had a similar feeling for the 2.x release series. So they don't even appear in the interface anymore and deactivate on updating.

Ah yes, perfect. That works locally. Thank you very much.

Last question: I published a new version of my plugin on npmjs.org, but the plugin list still shows the old version (even a complete new installation). What am I doing wrong? Or is this list centrally stored somewhere and only refreshed once a day?

But that is internal api. I am looking for a solution for an external service to lookup the user with the custom field.

This already exists: http://localhost:4567/api/user/uid/2
I am looking for something like http://localhost:4567/api/user/<my custom field>/<my custom value> or http://localhost:4567/api/users?filter=<my custom field>==<my custom value>

I am using a customized nodebb-plugin-sso-oauth plugin. After login, the user is created initially and the users id on my oauth identity server is saved in a custom field (faf-nodebbId).

My OAuth identity server offers a concept of changing your username. So I built some code that calls the api/v2/users endpoint of the write plugin. However, to write the correct thing I need to lookup the nodebb userid with my external id / faf-nodebbId.

It seems like the nodebb web api has no feature to search for users by custom fields. Am I right? Is there a plugin that offers this? Or what plugin could be taken as reference to implement this on my own?

Ah perfect. I completely missed that.

@julian sorry to dig out this old topic, but is there a simple way to bypass the login screen from inside nodebb (or maybe inside the sso-plugin)?
I could do it in my proxy, but that does not feel like a clean solution.

Thank you very much @oplik0 for your very detailed and helpful answer. I will take a look into the write-api plugin first and see how far I get. From your description it sounds like what I need.

Hi there,

I was able to setup a nodeBB forum with SSO of our own OAuth2 compliant service. So people login first time, their user is created an everything works as intended.

The problem is: In our service people can change their username. And I would like to update the name in nodeBB as well when this happens. How can I achieve that?

1. I have not seen any documentation on changing usernames via plugin.
2. I have no clue how to do this with the plugin system. From my understanding the hook system can only be triggered when actions are executed inside nodeBB. But in this case the action would be triggered from a 3rd party system without a user being logged in.

If anybody could point me into a direction in the docs or any examples I'd be happy.