Posts made by baris

Looks OK to me did you put a console.log here to see if the groups and privileges are correct? Did you check the database directly to see if the change happened?

Hi @sazulo,

Since your plugin hook function is async you should not use the callback and just return strategies from the function.

Change your function to the below and it should work.

OpenIDConnectPlugin.getStrategy = async function (strategies) {
	try {
		if (!OpenIDConnectPlugin.config.enabled) {
			return strategies;
		}
		OpenIDConnectPlugin.issuer = await Issuer.discover(OpenIDConnectPlugin.config.discoverUrl);

		const strategy = new Strategy({
			client: new OpenIDConnectPlugin.issuer.Client({
				client_id: OpenIDConnectPlugin.config.clientId,
				client_secret: OpenIDConnectPlugin.config.clientSecret,
				redirect_uris: [nconf.get('url') + AUTH_OIDC_CALLBACK_PATH],
			}),
			params: {
				// In OpenID Connect,
				// => issuer and subject in the 'openid' scope
				// => email in the 'email' scope
				// => username in the 'profile' scope ( as 'preferred_username' )
				scope: 'openid email profile',
				get nonce() {
					return uuid.v4();
				},
			},
		}, OpenIDConnectPlugin.verify);

		passport.use(strategy);

		strategies.push({
			name: strategy.name,
			url: AUTH_OIDC_LOGIN_PATH,
			callbackUrl: AUTH_OIDC_CALLBACK_PATH,
			icon: 'fa-openid',
			scope: 'user:username',
		});

		return strategies;
	} catch (err) {
		console.log(err);
		winston.error(err);
		throw err;
	}
};

Sound like you need to rebuild and clear your browser cache then.

There are no errors in the messages tab, you should keep it open and reproduce the error. It should show which message caused a invalid-event error.

Breaking change to themes https://github.com/NodeBB/NodeBB/issues/8018

This only affects custom themes on forums that are running on a subfolder. To upgrade the theme to 1.13.0 just remove {config.relative_path} from the files in this commit. https://github.com/NodeBB/nodebb-theme-persona/commit/eb33ae7fa1d59aa1fce77cea988a537e277049b5

djensen47 created this issue in NodeBB/NodeBB

closed Welcome notification link broken #8018

0 barisusakli committed to NodeBB/nodebb-theme-persona

https://github.com/NodeBB/NodeBB/issues/8018

The messages tab should show more info.

Try running ./nodebb build and starting.

Yeah I think we still support node 8, at least till Jan 2020.

https://github.com/NodeBB/NodeBB/blob/master/src/prestart.js#L26 need to change toISOString on that line.

If the nodebb app is just exiting with no errors check if your system has enough ram and swap.

I don't think there is one but you can write a plugin using the hook filter:router.page. This hook gets called before the actual topic route handler.

In your plugin you can just do this:

myPlugin.filterRouterPage = function (req, res, next) {
	const myAnnouncementTopicId = 111;
	if (req.params && req.params.topic_id && parseInt(req.params.topic_id, 10) === myAnnouncementTopicId) {
		req.query.sort = 'newest_to_oldest';
	}
	next();
};

Should be possible but I am not sure if mongodb transactions work on standalone servers yet, I think they are only for sharded clusters and replica sets.

In version 4.0, MongoDB supports multi-document transactions on replica sets.

In version 4.2, MongoDB introduces distributed transactions, which adds support for multi-document transactions on sharded clusters and incorporates the existing support for multi-document transactions on replica sets.

To use transactions on MongoDB 4.2 deployments(replica sets and sharded clusters), clients must use MongoDB drivers updated for MongoDB 4.2.

More info here https://docs.mongodb.com/manual/core/transactions/

Redis has multi for transactions so we could aim for something like this in our dbal layer.

const tx = db.transaction();
tx.setObject('user:' + uid, data);
tx.sortedSetAdd('users:joindate', Date.now(), uid);
await tx.exec();

So both commands are executed atomically.

You can fix the counts by running the following query in mongodb for each group that has the wrong member count.

// get number of users
db.objects.count({_key: "group:<replace_with_group_name>:members"});

// update group object
db.objects.update({_key: "group:<replace_with_group_name>"}, {$set: {"memberCount": <replace_with_value_from_previous_query>}});

This is fixed now https://github.com/NodeBB/NodeBB/commit/661a0f506828ec4ef03e3db8508484d1df6977a6

0 barisusakli committed to NodeBB/NodeBB

fix: don't show deleted topics on unread

Thanks for reporting, I will get this fixed before 1.13.0

Makes sense. Please open an issue on our github.

That layout was changed recently so it is not in a release yet, either wait for 1.13.0 or update to latest master.

You can use the custom css tab in the ACP.

.topic .post-signature {
  font-style: normal;
}

Feel free to open an issue on our github, this needs to be implemented properly so canceling a topic delete doesn't execute all the code that comes after. For example if you cancel topic delete in filter:topic.delete then action:topic.delete shouldn't fire etc.

If you are on nodebb 1.12.2 you should use the version of db search in your package.json. 4.0.6 is for nodebb 1.13.0 which isn't released yet.