nodebb-plugin-lightbox: Please update
-
Oh and BTW same thing can be used in other plugins that are trying to implement gallery like behaviour. They all need ability to add code to image link and this hook enables that so if it gets into master i think that we will see more working plugins in near future (if they are not abandoned by their mainteiners).
-
@sosojni said in nodebb-plugin-lightbox: Please update:
their
This is really great, I'll give it a test. Our users will be happy, thank you
For the other plugins, I think they are all abandoned, I've contacted the maintainers and never got any answer... If you can fork the plugin and publish a working one, I believe you'll make a lot of happy users out there BTW, there is another plugins that have a weird behaviour, this one nodebb-plugin-lightbox. Actually it works but only if the image is hosted somewhere else than the same URL of the nodebb
-
@sosojni Well I don't know what I'm missing, I don't know anything about nodebb, I've searched for image.js in my nodebb root installation and found 2 files. As I didn't know which one I had to edit, I changed both of them
nodebb:~$ find . -name "images.js" -print
./public/src/client/topic/images.js
./build/public/src/client/topic/images.js
nodebb:~$ vi ./build/public/src/client/topic/images.js
nodebb:~$ vi ./build/public/src/client/topic/images.jsThe installed and activated the plugin
Then changed the line in
nodebb:~ cd /node_modules/nodebb-plugin-gallery
nodebb:~ find . -name "main.js" -print
./public/lib/main.jsThen reloaded nodebb but nothing happens concerning the images
still opening in separate browser tab. -
Hook is merged ( https://github.com/NodeBB/NodeBB/pull/5828 ) so you can expect needed image plugins after 1.6 is released.
-
Already submited pull request for gallery: https://github.com/psychobunny/nodebb-plugin-gallery/pull/15
I see @psychobunny is active on this forums so i guess we wont have much problems with him applying that change.
