Thanks @baris, that seems to have fixed it on this forum.
(Is this forum always running on master?)
yzahn
Posts
-
Incorrect title for guest users -
Incorrect title for guest users@baris said in Incorrect title for guest users:
Can you reproduce on this forum?
Yes. (Just right click any link to a post and open in incognito)
but each page's header is cached separately
The code doesn't seem to agree with that statement...
It would seem that the cache key is based only on {template, language, method}. -
Incorrect title for guest usersHi,
Since the latest update, guest users will get an incorrect tab title on the 1st load of a page.
The tab title doesn't reflect the page content. (Not terrible since it corrects itself at the 1st navigation, but still strange).
This seems to be connected to this pull request.@baris was this an intentional side effect?
-
Topic teaser showing even when user can't view postWhen a user has read privilege on a category but not on the topics within the category, the teaser still shows.
Is that intentional? -
Static hooksHi,
I am trying to use the static hook:static:messaging.canMessageUser
to add custom logic to the permission checks if a user may message another user.
However, it seems that static hooks cannot alter the flow of nodebb. Throwing an error or returning false etc. do not do anything.
Shouldn't this rather be a filter hook?
Or am I misunderstanding something? -
EXIF data being stripped, any chance of making that configurable?Fixed already!!
Thanks @baris ! -
EXIF data being stripped, any chance of making that configurable?Hi,
Just spent some time writing a little custom script for a NodeBB based photography forum, its job was to show some EXIF data in a small box under uploaded photos. (e.g. camera model).
Updated to latest version, and poof.. all EXIF data is stripped...
https://github.com/NodeBB/NodeBB/commit/5eaa14e746f3526138ba2433029d70a1870980bcI get that it is a sane default, since EXIF data can be somewhat sensitive from a privacy standpoint, however is there any chance of making this configurable?
I can get by with hand editing the code after each update but that is a pain...
I can't seem to find any trigger that is triggered before the EXIF data is stripped... Any ideas?
-
When is this forum updated with the latest commits from master branch?I am wondering if this forum is maintained in sync with current master? or is it only updated on a version release?
( @julian, you fixed https://github.com/NodeBB/NodeBB/issues/7593 yesterday, wondering when can I test the fix on the current forum? I was actually pretty sure that it was an issue in frontend script as I attempted to explain in the issue... ) -
Which plugins to use??