@baris restarting an rebuilding does not appear to fix the problem.

I had the HTML and socket.io logging set on (not that it applies to this I know) and went to turn it back off and got the following error:

TypeError: stream.end is not a function
    at Object.Logger.close (/home/nodebb/nodebb_root/src/logger.js:102:10)
    at Object.Logger.setup_one_log (/home/nodebb/nodebb_root/src/logger.js:68:10)
    at Object.Logger.setup_one (/home/nodebb/nodebb_root/src/logger.js:50:10)
    at Object.Logger.monitorConfig (/home/nodebb/nodebb_root/src/logger.js:111:9)
    at Config.setMultiple (/home/nodebb/nodebb_root/src/socket.io/admin/config.js:42:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async onMessage (/home/nodebb/nodebb_root/src/socket.io/index.js:150:19)

Also getting lots of language errors for the question and answer plugin

Missing translation "qanda:topic_unsolved" for language "en-GB"
Missing translation "qanda:topic_solved" for language "en-GB"
Missing translation "qanda:menu.unsolved" for language "en-GB"

Since upgrading to 1.16.2 I have a string of issues - maybe they are all related to something fundamental? This is the current versions I am running:

System

Nodebb 1.16.2
Mongod 4.0.20
Redis version 4.0.9
Node v12.21.0
nginx 1.16.1
npm 6.14.11

@baris

Here is chunk of the output logs. the digest is set to go out around 1700 server time so you see some errors for individual users who deleted there account while still subscribed to digest emails. Other than That there are none of the information messages that the link you posted shows should be there.

2021-04-05T06:46:37.497Z [4568/15827] - ESC[33mwarnESC[39m: uid : 5384 has no email, not sending "categoryNotifications_post" email.
2021-04-05T09:54:38.911Z [4568/15827] - ESC[31merrorESC[39m: /api/v3/topics/22351
invalid csrf token
2021-04-05T09:54:41.608Z [4568/15827] - ESC[31merrorESC[39m: /api/v3/topics/22351
invalid csrf token
2021-04-05T09:54:42.643Z [4568/15827] - ESC[31merrorESC[39m: /api/v3/topics/22351
invalid csrf token
2021-04-05T09:55:14.295Z [4568/15827] - ESC[31merrorESC[39m: /api/v3/topics/22351
invalid csrf token
2021-04-05T09:55:40.696Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4131 ([email protected]) has not confirmed email, not sending "categoryNotifications_post" email.
2021-04-05T09:55:40.697Z [4568/15827] - ESC[33mwarnESC[39m: uid : 5384 has no email, not sending "categoryNotifications_post" email.
2021-04-05T12:26:57.740Z [4568/15827] - ESC[31merrorESC[39m: posts.getVoters
Error: [[error:no-privileges]]
    at SocketPosts.getVoters (/home/nodebb/nodebb_root/src/socket.io/posts/votes.js:20:10)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async onMessage (/home/nodebb/nodebb_root/src/socket.io/index.js:150:19)
2021-04-05T12:30:23.421Z [4568/15827] - ESC[31merrorESC[39m: topics.loadMoreSortedTopics
Error: [[error:invalid-session]]
    at validateSession (/home/nodebb/nodebb_root/src/socket.io/index.js:196:9)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async onMessage (/home/nodebb/nodebb_root/src/socket.io/index.js:143:3)
2021-04-05T12:46:10.315Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T12:46:10.398Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T13:36:33.409Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T13:36:33.410Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T14:52:39.513Z [4568/15827] - ESC[31merrorESC[39m: /api/v3/topics
invalid csrf token
2021-04-05T15:12:26.095Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4131 ([email protected]) has not confirmed email, not sending "categoryNotifications_post" email.
2021-04-05T15:12:26.101Z [4568/15827] - ESC[33mwarnESC[39m: uid : 5384 has no email, not sending "categoryNotifications_post" email.
2021-04-05T16:23:45.309Z [4568/15827] - ESC[33mwarnESC[39m: [api] This route has been deprecated and will likely be removed in v1.17.0
2021-04-05T16:23:45.309Z [4568/15827] - ESC[33mwarnESC[39m: [api] Use GET /api/v3/(posts|topics|categories)/:id instead
2021-04-05T16:26:45.802Z [4568/15827] - ESC[31merrorESC[39m: /login
invalid csrf token
2021-04-05T16:27:26.527Z [4568/15827] - ESC[33mwarnESC[39m: [api] This route has been deprecated and will likely be removed in v1.17.0
2021-04-05T16:27:26.528Z [4568/15827] - ESC[33mwarnESC[39m: [api] Use GET /api/v3/(posts|topics|categories)/:id instead
2021-04-05T16:32:37.567Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_topic" email.
2021-04-05T16:32:37.638Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_topic" email.
2021-04-05T16:33:46.887Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4131 ([email protected]) has not confirmed email, not sending "categoryNotifications_post" email.
2021-04-05T16:33:46.956Z [4568/15827] - ESC[33mwarnESC[39m: uid : 5384 has no email, not sending "categoryNotifications_post" email.
2021-04-05T16:36:20.958Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T16:36:20.959Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T16:49:52.858Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T16:49:52.860Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:34:10.944Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:34:10.945Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:37:24.430Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:37:24.431Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:40:21.534Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:40:21.535Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:49:12.589Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:49:12.591Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:59:31.997Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T17:59:31.999Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T18:17:43.462Z [4568/15827] - ESC[31merrorESC[39m: /api/post/upload
invalid csrf token
2021-04-05T18:18:15.704Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4285 has no email, not sending "categoryNotifications_post" email.
2021-04-05T18:18:15.705Z [4568/15827] - ESC[33mwarnESC[39m: uid : 4983 has no email, not sending "categoryNotifications_post" email.
2021-04-05T18:19:36.640Z [4568/15827] - ESC[33mwarnESC[39m: uid : 5384 has no email, not sending "categoryNotifications_topic" email.

@baris

sure, here it is:

Only one is setup to run jobs.

Also there are two digest emails coming through. not 3 which would be expected if all three instances were sending one.

Since upgrading to 1.16.2 Subscribers to digest emails have been receiving two emails, sent separately but almost the the same time, per digest period.

This is using the Mailgun emailer plugin:

Which is the latest release

I have checked my mailgun logs and the emails are being sent twice by Nodebb, for example two digest emails sent to the the same addresses with these two timestamps:
"timestamp": 1617296502.310472,
"timestamp": 1617296459.443556,

When I send a digest email manually (either from the email testing section or the digest management section), two digests are not sent.

I see this topic:
https://community.nodebb.org/topic/10933/multiple-digest-emails/4?_=1617010969529
Indicates it could be because NodeBB is running in multiple processes however this only just started happening in 1.16.2 and I have always run nodebb with 3 clustering instances. When changing to 1.16.2 the significant change was switching to redis for session information as described in the scaling page in the documentation, but I don't see how that applies.

Also this topic:
https://community.nodebb.org/topic/6662/digest-duplicating-emails-on-scaled-nodebb/4?_=1617010969533
deals with a similar problem, but I am only using 1 server for clustering.

Since 1.16.2 (possibly before but no one mentioned it) We have been getting this desktop notifications popup for users on first registration:

the desktop notifications plugin is showing as the latest version: 0.3.3 is anyone else seeing this issue?

Further update - Problem appears to be fixed.

One difference in browser errors is the prepareFooter error:

Uncaught ReferenceError: highlight is not defined
    at HTMLDocument.prepareFooter ((index):3508)

Further digging showed that the prepareFooter() is where custom javascript is placed and that was the issue. Custom java script was breaking the page during prepareFooter() which killed the reply functionality (along with a lot of other things).

The java script was there to add functionality to highlight.js for syntax highlighting. now to dig into what has changed with highlight.js in the latest version.

I note that with this version of chrome the same errors similar errors are show with this forum:

however reply does work here, even after a CTRL-R reload

So I clearly have a misconfiguration somewhere in the backend.

As a further update. this means that when a link to a forum post is pasted into a browser where you already have a logged in session the new tab is effectively a browser reload and thus reply does not work.

After upgrading to 1.16.2 the "reply" functionality no longer works if the page is reloaded

To create the issue:

1. Start with fresh login
2. Test reply works (it does)
3. Normal reload of the browser (CTRL-R)
4. Test reply - does not work, button does nothing

Errors in Chrome console immediately after logging in:

Errors in Chrome console immediately after sending CTRL-R:

Basically identical errors but now reply is not working. clicking the button/link for reply does not generate more errors, the clicks are ignored.

There is one error in the nodebb logs which may be related:

Error: Session Mismatch
    at validateSession (/home/nodebb/nodebb_root/src/socket.io/index.js:196:9)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async onMessage (/home/nodebb/nodebb_root/src/socket.io/index.js:143:3)

Nothing obvious in the nginx access or error logs

System

Nodebb 1.16.2
Mongod 4.0.20
Redis version 4.0.9
Node v12.21.0 (Tried with node v14 as in the documentation but that had other errors that were fixed with a downgrade)
nginx 1.16.1
npm 6.14.11

This is with the latest version of Chrome

Running with clustering enabling so the big change in this upgrade was having to install redis to allow that to work. As redis is now handling the sessions could that be the reason this is not working?

As an possibly related issue, I am used to using our forum from multiple browser sessions almost concurrently (e.g. on mobile, on desktop). I now see session mismatch errors occasionally when switching. For the purposes of this test above I only had one session open to keep it simple.

@baris @FrankM thanks, so it looks like redis installs suitably setup (protected mode on, only bound to the loopback address) etc.

I did the upgrade to 1.16.2 and this element of it appears ok, will open another thread for other issues.

@baris thanks. so to be clear just installing redis, without any configuration is all that is required?

Is there any concern with having redis used in this way with no admin account/password etc?

Looking to upgrade to 1.16.2 with a forum that uses clustering and runs on MongoDB

I see this:
https://community.nodebb.org/topic/15178/1-16-0-breaking-changes/3?_=1616876795709

If you are using clustering redis is now a requirement. Simply install and configure redis in your config.json block. If you were already using redis as your datastore or for sessions no changes are necessary.

In the "scaling" page of the documentation this is:

Configure Redis
When you setup NodeBB to use more than one process, it is advisable to configure Redis as well. Each NodeBB process can communicate with the others through Redis pub-sub. Install Redis on your server and add a redis block to your config.json....

So:

1. Does redis need to be installed before upgrading to 1.16.x? or should the upgrade be done first, then redis installed (basically clarity on the upgrade sequence in this case)
2. How is redis configured? Does the upgrade script create the database, admin user etc etc? If not where is the documentation on how to install and configure redis to be used for pub-sub, but not as the main database?

@TonyTony is this something best solved with a plugin?

It would be great if there was an option to restrict the use of certain tags to particular user categories. For example a moderator could take this feature request with: "Github" or "Review" or whatever. A normal user however would not be able to use those restricted tags.

Pinned topics/posts are useful to help new users and we use them in all the categories. Some users end up directly in "unread" or "recent" and it would be helpful if we could pin topics to those as well.