@baris

So I have looked at this in greater detail and here are the problems 1 I see.

1. The sortedset really only records two bits of information: the UID and the filename. If anything more is needed the filesystem will have to be queried and logic added to evaluate the file. My view is I'd rather store this in the DB and pick it up in a single query than collect the data from the filesystem on the pageload.
2. This process lacks the post validation check for uploads. This leaves debris in both the database and on the file system.
3. I didn't spot a cleanup system that might take care of this.

1 These are from the perspective of the problem I think I am trying to solve, aside from the couple I saw that are duplicates of issues I created in my own efforts.

I'm afraid you lose me at "However, for the 5$ you pay, you are getting some overpriced hipster box."

Really hard to take the remainder seriously.

@baris said in Curiousity? regarding file uploads.:

/user/<slug>/uploads

A cursory examination says no - but I need to dig a little more to be sure and then I think I need to stare at the results for a bit to see if it is better to plugin or PR for the extra bits I use that do not appear to be present here.

Also this looks like it has some of the deficiencies my initial draft had so I probably will end up doing both.

I need to churn on this for a bit.

Unfortunately, projects like NodeBB don't tend to do well with Extreme Stable spins like RHEL/CENT.

I would check and see if there is a more current node available in EPEL - Node's documentation recommends using this source: https://github.com/nodesource/distributions

I don't know if this matters for you, but the Fedora versions are usually new enough if you're in an environment where a "nonstable" spin is acceptable.

It's been a bit, but I've come back to my fileownership plugin now that the PR it was depending on has been committed.

Okay, a long time after.

This is a two step process. The first triggers off of the filter:uploadStored. This is done because part of what I want to collect and store are the mime type of the file and its size. There are also three permutations of the filename that we want to hold on to. This information is only available as part the file upload that happens when you attach the file.

The second step fires on the action:post.save - this exists for one main reason. If you delete a file from your message, nothing ( obvious anyway ) clean up after that. So this post process checks the message body at save time, compares it to the saved data from step 1 and cleans up any deleted files.

On to the curiousities. When you look at the body content on save, you''ll see

![0_1530309721623_FileNaMe.png](/assets/uploads/files/1530309721776-filename-resized.png)

The 0 is the user id #, followed by a timestamp, then the filename. The filename and extension portion match the original file as uploaded. This is followed by the relative url to the version of the image that is posted inline in the forum. Notice that the timestamps do not match and the file has been downcased.

When you click on the image when displayed, you'll load up /assets/uploads/files/1530309721776-filename.png

So why this post? Those timestamps not matching is a little irksome. Is this on purpose? If so, why, exactly?

I'm working on a plugin that programmatically adds group and/or user perms to a dynamically created category.

I mimicked the call used in the write API, but I'm not sure I'm constructing the perms correctly - and that still doesn't answer the issue of single user perms for a category.

I did a quick test to verify that nodebb setup will attempt to verify mongo access even if it has been provided - which I expected, but... and it does.

So it seems that the best practice here would be to pass the values in as part of the build with the assumption that the Redis or mongo instance already exists.

This is probably a dependency on the config file. Try building/dropping a static one in place before this step to validate.

When I have forked, in the past, I give the theme a new name and flip back and forth as needed.

I'll take a crack at it.

Where are you looking to place the tipper?

I'm not familiar with any. Seems like an odd thing to do.

I've had similar issues trying to meet things up with the style guide.

Would that not better handled by your reverse proxy, software, or hardware firewall?

@pitaj I'd like to run my fork through the same travis/coveralls evaluation that the main repo does without having to clutter up with a messy PR. I make a LOT more mistakes than ya'll still.

On a related note, is there a way to easily? rig up my fork to the test flow on my fork so that I don't create so much debris trying to solve for coverage?

@julian Ouch.

Made a small tweak based on covering my ignorance.

#!/bin/bash

# Make sure eslint and related are installed. If not, install it.
if [ ! -f node_modules/.bin/eslint ]; then
  echo "eslint not installed. Installing airbnb-base eslint config, eslint, and related depends."
  (
    export PKG=eslint-config-airbnb-base;
    npm info "$PKG@latest" peerDependencies --json | command sed 's/[\{\},]//g ; s/: /@/g' | xargs npm install --save-dev "$PKG@latest"
  )
  npm install eslint
fi

for file in $(git diff --cached --name-only | grep -E '\.(js|jsx)$')
do
  git show ":$file" | node_modules/.bin/eslint --stdin --stdin-filename "$file" # we only want to lint the staged changes, not any un-staged changes
  if [ $? -ne 0 ]; then
    echo "ESLint failed on staged file '$file'. Please check your code and try again. You can run ESLint manually via npm run eslint."
    exit 1 # exit with failure status
  fi
done

Totally running with the hook. Maybe put that in the dev guide?

Is there a way for me to run style guide portion of the Travis parsing locally? That seems to give me more fits for PRs so far than errors.

Thanks.