Posts made by sazulo

Hello guys, after coding the whole day and discovering the world of NodeBB plugins, I'm ready to put here the first version of the plugin !

Not much to see right now, only three parameters to set :

• Discover Url ( often contains '.well-known' )
• Client ID
• Client Secret

But it works.

/!\ For now beware of providers giving the email in the "prefered_username" field ( like google ), because for now there is no way to modify it before the user is registered /!\

The repository is there :
https://github.com/sazulo/nodebb-plugin-openidconnect

The real error was due to the fact that I wrote callbackUrl instead of callbackURL when pushing into the strategies.

And, as I'm developing with version 1.12.2, I can't just return the results as this version does not support promises.

Hello everybody,

I'm currently trying to create an openid connect plugin for NodeBB, but I've got a "Callback was already called" exception at the loading of the plugin.

Here is my function :

/**
		* Creates the Passport Strategy to login with OpenID Connect.
		*
		* @param {*} strategies
		* @param {*} callback
		*/
OpenIDConnectPlugin.getStrategy = async function (strategies, callback) {
	try {
		if (!OpenIDConnectPlugin.config.enabled) {
			return callback(null, strategies);
		}
		OpenIDConnectPlugin.issuer = await Issuer.discover(OpenIDConnectPlugin.config.discoverUrl);

		const strategy = new Strategy({
			client: new OpenIDConnectPlugin.issuer.Client({
				client_id: OpenIDConnectPlugin.config.clientId,
				client_secret: OpenIDConnectPlugin.config.clientSecret,
				redirect_uris: [nconf.get('url') + AUTH_OIDC_CALLBACK_PATH],
			}),
			params: {
				// In OpenID Connect,
				// => issuer and subject in the 'openid' scope
				// => email in the 'email' scope
				// => username in the 'profile' scope ( as 'preferred_username' )
				scope: 'openid email profile',
				get nonce() {
					return uuid.v4();
				},
			},
		}, OpenIDConnectPlugin.verify);

		passport.use(strategy);

		strategies.push({
			name: strategy.name,
			url: AUTH_OIDC_LOGIN_PATH,
			callbackUrl: AUTH_OIDC_CALLBACK_PATH,
			icon: 'fa-openid',
			scope: 'user:username',
		});

		return callback(null, strategies);
	} catch (err) {
		console.log(err);
		winston.error(err);
		return callback(err);
	}
};

Here is the stacktrace of the console.log :

TypeError: Cannot read property 'length' of undefined
    at pathtoRegexp (/home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/path-to-regexp/index.js:63:49)
    at new Layer (/home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/express/lib/router/layer.js:45:17)
    at Function.route (/home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/express/lib/router/index.js:494:15)
    at Function.proto.<computed> [as get] (/home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/express/lib/router/index.js:509:22)
    at /home/sazulo/Projects/tennotech/nodebb/nodebb/src/routes/authentication.js:77:45
    at Array.forEach (<anonymous>)
    at /home/sazulo/Projects/tennotech/nodebb/nodebb/src/routes/authentication.js:65:20
    at nextTask (/home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/async/dist/async.js:5324:14)
    at next (/home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/async/dist/async.js:5331:9)
    at /home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/async/dist/async.js:969:16

Here is the UnhandledPromiseRejection :

2019-11-07T20:41:17.449Z [4567/61465] - error: Cannot read property 'length' of undefined
(node:61465) UnhandledPromiseRejectionWarning: Error: Callback was already called.
    at /home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/async/dist/async.js:966:32
    at /home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/async/dist/async.js:2518:13
    at Object.OpenIDConnectPlugin.getStrategy [as method] (/home/sazulo/Projects/tennotech/nodebb/nodebb/node_modules/nodebb-plugin-openidconnect/index.js:148:10)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

The line 148 is the return callback(err); at the end.