congrats for the audit scores.

First two are from my browser

Mobile Device

Desktop

from

PageSpeed Insights

Mobile Device

Desktop

From last site desktop is better than mobile than from browser.

I did a bit better performance with a simple vuejs forum, but very good performance for a complex forum like this.

from last checks

desktop: First Contentful Paint: 0,5 s
mobile: First Contentful Paint : 1,8 s

Hello. I wonder if nodebb structure does not favor data inconsistency

What i see in user/create.js file

Different waterfall and parallel async calls, but why not use a single batch request directly to the database?
Anything can happen during the execution of a function. If the server crash before the end of a function we will have data inconsistency, with incremented counters and inexistent new users or similar things.

p.s: With MongoDB 4.0 is possible to execute ACID transactions. Postgre SQL can do the same, i have no idea about redis DB.

@julian
Thanks. Yes it works fine. Only one problem.

Seems like

'action:ajaxify.dataLoaded'

is not called when i refresh the page. It is called only if browse the forum. I noticed it now because i use this hook to capture user counters and put them into the stats page.
It wont work also with simple code, outside or inside the document-ready function.

P.S: i just solved using directly

ajaxify.data

global variable. It is just a problem of the hook

I wonder if there is a filter to add custom field stats on a user profile.
ex: followers, following, my custom counter, my custom counter

at moment, i call this filter to add my counters

filter:user.account

But in this way i have to add custom css code on the client side. There is a way to add them graphically on the server side?

For example when i call this filter

filter:user.profileMenu

is not neccessary to add client css code because this function do anything

plugin.getProfileMenu = function(data, callback) {
  data.links.push({
    title: '[[pages:user/myprop]]',
    id: 'mybutton',
    route: 'mybutton',
    name: 'mybutton',
    visibility: {
      self: true,
      other: true,
      moderator: true,
      globalMod: true,
      admin: true,
    },
  });

  callback(null, data);
}

congrats for the audit scores.

First two are from my browser

Mobile Device

Desktop

from

PageSpeed Insights

Mobile Device

Desktop

From last site desktop is better than mobile than from browser.

I did a bit better performance with a simple vuejs forum, but very good performance for a complex forum like this.

from last checks

desktop: First Contentful Paint: 0,5 s
mobile: First Contentful Paint : 1,8 s

@baris yeah it's true, but you can use transaction on a multicluster with only one node, also if with a lot of limitations.
About your command example is a good idea also if it would work only with redis and postgre, with mongodb can be used like a normal batch.

I took a look to postgreSQL module, seems it support transactions, mongodb emulate the same thing with non ACID batch. I prefer to avoid SQL databases but the way data is organized seem more suitable to a relational DB

Hello. I wonder if nodebb structure does not favor data inconsistency

What i see in user/create.js file

Different waterfall and parallel async calls, but why not use a single batch request directly to the database?
Anything can happen during the execution of a function. If the server crash before the end of a function we will have data inconsistency, with incremented counters and inexistent new users or similar things.

p.s: With MongoDB 4.0 is possible to execute ACID transactions. Postgre SQL can do the same, i have no idea about redis DB.

I'm using several groups that gradually guarantee more and more privileges. Each group is reached after a certain number of posts.
They are groups in which you are automatically added or removed by the system, you cannot choose to accept or reject.
The problem is that at the moment there is no way to prevent a user from leave a group.
I wanted to use the hook

'action: group.leave'

and then re-add the user after its call, but this solution could create a circularity that I don't like.

example: If an admin wants to delete a user from the group, he could not do it, because this hook does not provide information on who was doing the action, then it continues to re-add a user despite any privilege.

I think there is to use the same solution used for registrations, under the check mark
"disable join request" can be good to have "disable leave request"

@baris
i will do it! thanks you

If someone is interested at moment there is a ugly way to avoid a delete.

you can add your logic here

'action:topic.delete'

restore the topic if the caller is not the admin and the topic is part of a specific category

@oplik0

'privileges.can'

Is a good idea if this action depend exclusively from user privileges. Can be good also a filter if the action depend exclusively from the topic category. But i think is good also a hook dedicated for a single topic.

for example, maybe I want to make that a topic cannot be deleted if:

1. reaches a certain number of answers.
2. if it reaches a certain number of likes
3. if it has existed for a certain period of time
4. met certain criteria saved in another database.

they are all things that concern the single topic. Even if, thinking of it better, these cancellation criteria should belong to a category, (there are no topics without category). So in most cases, even a hook for each category would suffice.
But, seeing the structure of nodebb, there are no hooks by category but only during the creation or modification of topics and posts. Perhaps it is easier to continue following this structure

Hello. I see there is a hook that allow you to accept or reject a new topic. its name is

'filter:topic.create'

But the same thing dont exist for topic delete. At moment there is only a action hook to call after a topic is deleted.

Is possible to have a filter also for delete and purge? But i think is sufficent only for delete actions