Posts made by Mickola

Mickola

Hi,

I searched the forum and there's only one topic regarding this issue: https://community.nodebb.org/topic/14551/possible-to-prevent-post-number-being-appended-to-url-while-scrolling-through-threads?_=1626385603965

I wonder if there's a way to disable this 'feature'?

Thank you!

Mickola

Hi,

I am using nodebb-plugin-composer-redactor 3.4.8 on Nodebb 1.16.1.

I just notice that the 'upload an image' function isn't working on Redactor. From the log, it shows that the image is uploaded to the server (/nodebb/public/uploads/files folder) successfully, but the editor doesn't show the image being inserted to the post at all. There's an empty <img> tag inserted to the post though.

When I tried using different composers (Quill and NodeBB default composer), the image upload function works as it should.

Redactor is no longer supported, but I wonder if I can have this fixed. Otherwise, what is the recommendation? Switching to Quill?

Re: Quill
What is the best way to modify the toolbar on Quill editor? I want to hide some icons from the toolbar and currently use CSS to hide them.

Do I have to fork the plugin and edito /static/lib/quill-nbb.js to my liking (ie:

var toolbarOptions = {
container: [
	[{ header: [1, 2, 3, 4, 5, 6, false] }], // h1..h6
	[{ font: [] }],
	['bold', 'italic', 'underline', 'strike'], // toggled buttons
	['link', 'blockquote', 'code-block'],
	[{ list: 'ordered' }, { list: 'bullet' }],
	[{ script: 'sub' }, { script: 'super' }], // superscript/subscript
	[{ color: [] }, { background: [] }], // dropdown with defaults from theme
	[{ align: [] }],
	['clean'],
],
handlers: {},
};

Or is there a way similar to 'creating a child theme' - where I don't need to build everything from the scratch, but some add new template/css/js to extend the theme?

Thank you!

Mickola

@pitaj , I found the issue. It's the hook! I change it from:

{ "hook": "filter:category.topics.get", "method": "getTopics" }

to

{ "hook": "filter:topics.get", "method": "getTopics" }

Mickola

@pitaj

I use https://github.com/nodebb/nodebb-theme-quickstart to create a child theme and added the following based on your changes.

plugin.json:

{
	"id": "nodebb-theme-mytheme",
	"main": "./lib/theme.js",
	"hooks": [
        	{ "hook": "filter:widgets.getAreas", "method": "defineWidgetAreas" },        
		{ "hook": "filter:category.topics.get", "method": "getTopics" }
	],
	"scripts": [
		"./lib/client.js",
		"../nodebb-theme-persona/public/persona.js",
		"../nodebb-theme-persona/public/modules/autohidingnavbar.js",
		"../nodebb-theme-persona/public/modules/quickreply.js"
	],
	"modules": {
		"pulling.js": "node_modules/pulling/build/pulling-drawer.js"
	}
}

theme.js

(function(module) {
    "use strict";
    
    var Posts = require.main.require('./src/posts');
	var Theme = {};

	Theme.defineWidgetAreas = function(areas, callback) {
		areas = areas.concat([
			{
				'name': 'MOTD',
				'template': 'home.tpl',
				'location': 'motd'
			},
			{
				'name': 'Homepage Footer',
				'template': 'home.tpl',
				'location': 'footer'
			},
			{
				'name': 'Category Sidebar',
				'template': 'category.tpl',
				'location': 'sidebar'
			},
			{
				'name': 'Topic Footer',
				'template': 'topic.tpl',
				'location': 'footer'
			}
		]);

		callback(null, areas);
    };
    
    Theme.getTopics = async (data) => {
        const pids = data.topics.map(x => x.mainPid);
        const [{ upvotes, downvotes }, bookmarked, bookmarks, sharing] = await Promise.all([
            Posts.getVoteStatusByPostIDs(pids, data.uid),
            Posts.hasBookmarked(pids, data.uid),
            Posts.getPostsFields(pids, ['bookmarks']),
            Social.getActivePostSharing(pids)
        ]);
        data.topics.forEach((topic, i) => {
            topic.upvoted = upvotes[i];
            topic.downvoted = downvotes[i];
            topic.bookmarked = bookmarked[i];
            topic.bookmarks = bookmarks[i];
            topic.sharing = sharing[i];
        });
        console.log(data);
        return data;
    };

    module.exports = Theme;
    
}(module));

client.js

$(document).ready(function() {
	require(['forum/topic/votes', 'api'], function (votes, api) {

		function bookmarkPost(button) {
			var method = button.attr('data-bookmarked') === 'false' ? 'put' : 'del';
			var pid = button.closest('[data-pid]').attr('data-pid');
	
			api[method](`/posts/${pid}/bookmark`, undefined, function (err) {
				if (err) {
					return app.alertError(err);
				}
				var type = method === 'put' ? 'bookmark' : 'unbookmark';
				$(window).trigger('action:post.' + type, { pid: pid });
			});
			return false;
        }
        
		$(document).on('click', '[component="category/topic"] [component="post/upvote"]', function () {
            		console.log('upvote');
			return votes.toggleVote($(this), '.upvoted', 1);
		});
		$(document).on('click', '[component="category/topic"] [component="post/downvote"]', function () {
            		console.log('downvote');
            		return votes.toggleVote($(this), '.downvoted', -1);
		});
		$(document).on('click', '[component="category/topic"] [component="post/bookmark"]', function () {
            		console.log('bookmark');
            		return bookmarkPost($(this));
		});
    });
    
    $(document).on('click', '[component="category/topic"] [component="post/flag"]', function () {
        var pid = getData($(this), 'data-pid');
        require(['flags'], function (flags) {
            flags.showFlagModal({
                type: 'post',
                id: pid,
            });
        });
    });

    $(document).on('click', '[component="category/topic"] [component="post/flagUser"]', function () {
        var uid = getData($(this), 'data-uid');
        require(['flags'], function (flags) {
            flags.showFlagModal({
                type: 'user',
                id: uid,
            });
        });
    });

    function getData(button, data) {
		return button.parents('[data-pid]').attr(data);
	}

	function togglePostVote(data) {
		var post = $('[component="category/topic"] [data-pid="' + data.post.pid + '"]');
		post.find('[component="post/upvote"]').toggleClass('upvoted', data.upvote);
		post.find('[component="post/downvote"]').toggleClass('downvoted', data.downvote);
		post.find('[component="post/vote-count"]').html(data.post.votes).attr('data-votes', data.post.votes);
	}

	socket.on('posts.upvote', togglePostVote);
	socket.on('posts.downvote', togglePostVote);
	socket.on('posts.unvote', togglePostVote);

	function togglePostBookmark(data) {
		var el = $('[data-pid="' + data.post.pid + '"] [component="post/bookmark"]');
		if (!el.length) {
			return;
		}

		el.attr('data-bookmarked', data.isBookmarked);

		el.find('[component="post/bookmark/on"]').toggleClass('hidden', !data.isBookmarked);
        el.find('[component="post/bookmark/off"]').toggleClass('hidden', data.isBookmarked);
        el.find('[component="post/bookmarks"]').html(data.bookmarks).attr('data-bookmarks', data.bookmarks);
	}

	socket.on('posts.bookmark', togglePostBookmark);
	socket.on('posts.unbookmark', togglePostBookmark);
});

Note: console.log in getTopics isn't triggered.

Originally, I tried to add the changes straight to 'nodebb-theme-persona', but the result is still the same (and console.log in getTopics doesn't seem to be executed).

Mickola

@pitaj , I implemented the changed by creating a child theme and added the scripts there. I have NodeBB 1.16.0.

If a post hasn't been bookmarked yet, I am able to toggle it back & forth. However, if it's already bookmarked, the bookmark icon shows the off-state and when I click it, it shows an error. This is the error I got:

Error: [[error:already-bookmarked]]
    at toggleBookmark (E:\Projects\my.forum.test\src\posts\bookmarks.js:28:10)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Posts.bookmark (E:\Projects\my.forum.test\src\posts\bookmarks.js:8:10)
    at async executeCommand (E:\Projects\my.forum.test\src\api\helpers.js:120:17)
    at async Object.exports.postCommand (E:\Projects\my.forum.test\src\api\helpers.js:116:9)
    at async Object.postsAPI.bookmark (E:\Projects\my.forum.test\src\api\posts.js:210:9)
    at async Posts.bookmark (E:\Projects\my.forum.test\src\controllers\write\posts.js:67:2)
    at async E:\Projects\my.forum.test\src\routes\helpers.js:34:5

Mickola

@pitaj , thanks. It works!

However the bookmark function doesn't work the same as the one on the post (post-menu-list.tpl). When I clicked the bookmark button, it doesn't retain the status 'bookmarked=true'. So, when I get back to the category or refresh the page, the bookmark button is going back to the defautl OFF state. However, if I click the 'bookmark' button again, it shows an error 'You have already bookmarked this post'.

Secondly, I'd like to show the number of bookmarks next to the button, similar to the one inside the post. I added:

<span class="human-readable-number" component="post/bookmark-count" data-bookmarks="{./bookmarks}">{./bookmarks}</span>

Also tried this one:

<span class="human-readable-number" component="post/bookmark-count" data-bookmarks="{./posts.bookmarks}">{./posts.bookmarks}</span>

Both doesn't update the bookmark count at all.

Lastly, I'd like to add a sharing function (from post-menu-list.tpl) to category. This is what I added to topics_list.tpl

                <!-- Share -->
                <span class="share-tools">
                    <a href="#" data-toggle="dropdown" title="[[topic:share_this_post]]"><i class="fa fa-16px fa-fw fa-share"></i></a>
                    <ul class="dropdown-menu" role="menu">
                    
                        <!-- IF postSharing.length -->
                        <li class="dropdown-header">[[topic:share_this_post]]</li>
                        <!-- ENDIF postSharing.length -->
                        {{{each post.index.postSharing}}}
                            <li>
                                <a role="menuitem" component="share/{postSharing.id}" tabindex="-1" href="#"><span class="menu-icon"><i class="fa fa-fw {postSharing.class}"></i></span> {postSharing.name}</a>
                            </li>
                        {{{end}}}        
                    </ul>
                </span>
                <!-- /Share -->

It seems 'postSharing' doesn't return anything. Can you point me to the right direction?

Thanks!

Mickola

@pitaj , Happy New Year.

I wonder if you can share your tips regarding this. Basically I want to be able to Upvote, Share, Bookmark the first/main post from the Category/Topic page.

Thanks!

Mickola

Hi,

Let say, I have a site (not a NodeBB site) and it has a newsletter form where users can subscribe by filling in their names & email addresses. After they hit submit, I'd like to redirect to the the forum site (Registration page).

Is it possible to pass variables (eg: email address/username) to Registration page via query string?
For example, https://community.nodebb.org/register?username=jack&[email protected]

What I want to achieve is to since users have filled their information earlier, albeit on a different site, the Registration form should have a prefilled form (ie: name and email address).

Thanks

Mickola

@PitaJ , reply, upvote/downvote, etc. should apply to the main post. Is it possible?

Mickola

Hi,

I wonder if NodeBB allows users to reply, upvote, bookmark, etc. the post from category list page.

alt text

Do I need a plugin or can I just modify the theme to do that?

Thanks in advance.

Mickola

When using Redactor as composer, clicking 'New Topic' or 'Reply' button will create multiple GIF button. See screenshot below:

The GIF button multiplies every time I close the composer and reopen it. It doesn't happen if I'm using the default Composer.

Anybody face the same issue?

Mickola

Here you go:

Active plugins:
        * nodebb-plugin-composer-default (installed, disabled)
        * nodebb-plugin-composer-quill (installed, disabled)
        * nodebb-plugin-composer-redactor (installed, enabled)
        * nodebb-plugin-dbsearch (installed, enabled)
        * nodebb-plugin-emoji (installed, enabled)
        * nodebb-plugin-emoji-android (installed, enabled)
        * nodebb-plugin-markdown (installed, enabled)
        * nodebb-plugin-mentions (installed, enabled)
        * nodebb-plugin-soundpack-default (installed, enabled)
        * nodebb-plugin-spam-be-gone (installed, enabled)
        * nodebb-rewards-essentials (installed, enabled)
        * nodebb-theme-lavender (installed, disabled)
        * nodebb-theme-persona (installed, enabled)
        * nodebb-theme-slick (installed, disabled)
        * nodebb-theme-vanilla (installed, disabled)
        * nodebb-widget-essentials (installed, enabled)

I believe composer-default plugin is still need to be installed, but it can be disabled. I also tested on 1.13.2 and it works just fine.

Mickola

Just installed 1.13.0 and it doesn't seem to have the same issue as 1.13.3

Mickola

Here's what I am seeing:

2020-05-09T15:14:20.581Z [4567/23816] - verbose: [build] Querying CPU core count for build strategy
2020-05-09T15:14:20.582Z [4567/23816] - verbose: [build] System returned 16 cores, opting for parallel build strategy
2020-05-09T15:14:20.582Z [4567/23816] - verbose: [build] building the following targets: plugin static dirs, requirejs modules, client js bundle, admin js bundle, client side styles, admin control panel styles, templates, languages, sounds
  started
2020-05-09T15:14:20.591Z [4567/23816] - info: [themes] Using theme nodebb-theme-persona
2020-05-09T15:14:20.591Z [4567/23816] - verbose: [plugins] loading the following fields from plugin data: staticDirs, modules, clientScripts, acpScripts, cssFiles, lessFiles, acpLessFiles, languageData, soundpack
2020-05-09T15:14:20.600Z [4567/23816] - verbose: [plugins] Found 1 less file(s) for plugin nodebb-plugin-markdown
2020-05-09T15:14:20.600Z [4567/23816] - verbose: [plugins] Found 1 css file(s) for plugin nodebb-widget-essentials
2020-05-09T15:14:20.602Z [4567/23816] - verbose: [plugins] Found 1 less file(s) for plugin nodebb-plugin-emoji
2020-05-09T15:14:20.602Z [4567/23816] - verbose: [plugins] Found 1 css file(s) for plugin nodebb-plugin-composer-redactor
2020-05-09T15:14:20.602Z [4567/23816] - verbose: [plugins] Found 5 less file(s) for plugin nodebb-plugin-composer-redactor
2020-05-09T15:14:20.603Z [4567/23816] - verbose: [plugins] Found 1 less file(s) for plugin nodebb-plugin-spam-be-gone
2020-05-09T15:14:20.616Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-theme-persona
2020-05-09T15:14:20.624Z [4567/23816] - verbose: [plugins] found 2 static directories for nodebb-plugin-markdown
2020-05-09T15:14:20.624Z [4567/23816] - verbose: [plugins] Found 2 AMD-style module(s) for plugin nodebb-plugin-markdown
2020-05-09T15:14:20.625Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-markdown
2020-05-09T15:14:20.625Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-markdown
2020-05-09T15:14:20.625Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-mentions
2020-05-09T15:14:20.625Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-mentions
2020-05-09T15:14:20.625Z [4567/23816] - verbose: [plugins] found 1 static directories for nodebb-rewards-essentials
2020-05-09T15:14:20.625Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-rewards-essentials
2020-05-09T15:14:20.625Z [4567/23816] - verbose: [plugins] Found 3 sound file(s) for plugin nodebb-plugin-soundpack-default
2020-05-09T15:14:20.626Z [4567/23816] - verbose: [plugins] found 1 static directories for nodebb-plugin-emoji
2020-05-09T15:14:20.663Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-emoji
2020-05-09T15:14:20.663Z [4567/23816] - verbose: [plugins] found 1 static directories for nodebb-plugin-dbsearch
2020-05-09T15:14:20.664Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-dbsearch
2020-05-09T15:14:20.664Z [4567/23816] - verbose: [plugins] found 1 static directories for nodebb-plugin-spam-be-gone
2020-05-09T15:14:20.664Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-spam-be-gone
2020-05-09T15:14:20.664Z [4567/23816] - verbose: [plugins] Found 1 js file(s) for plugin nodebb-plugin-spam-be-gone
2020-05-09T15:14:20.687Z [4567/23816] - verbose: [plugins] Found 2 js file(s) for plugin nodebb-plugin-emoji
2020-05-09T15:14:20.687Z [4567/23816] - verbose: [plugins] Found 1 AMD-style module(s) for plugin nodebb-theme-persona
2020-05-09T15:14:20.689Z [4567/23816] - verbose: [plugins] Found 4 js file(s) for plugin nodebb-theme-persona
2020-05-09T15:14:20.698Z [4567/23816] - verbose: [plugins] Found 5 AMD-style module(s) for plugin nodebb-plugin-emoji
2020-05-09T15:14:20.711Z [4567/23816] - verbose: [plugins] Found 17 js file(s) for plugin nodebb-plugin-composer-redactor
2020-05-09T15:14:20.724Z [4567/23816] - info: [build] Building in parallel mode
2020-05-09T15:14:20.725Z [4567/23816] - info: [build]         plugin static dirs  build started
2020-05-09T15:14:20.727Z [4567/23816] - info: [build]          requirejs modules  build started
2020-05-09T15:14:20.728Z [4567/23816] - info: [build]           client js bundle  build started
2020-05-09T15:14:20.729Z [4567/23816] - info: [build]            admin js bundle  build started
2020-05-09T15:14:20.730Z [4567/23816] - info: [build]         client side styles  build started
2020-05-09T15:14:20.730Z [4567/23816] - info: [build] admin control panel styles  build started
2020-05-09T15:14:20.730Z [4567/23816] - info: [build]                  templates  build started
2020-05-09T15:14:20.730Z [4567/23816] - info: [build]                  languages  build started
2020-05-09T15:14:20.730Z [4567/23816] - info: [build]                     sounds  build started
2020-05-09T15:14:21.958Z [4567/23816] - info: [build]                     sounds  build completed in 1.228sec
2020-05-09T15:14:22.063Z [4567/23816] - info: [build]         plugin static dirs  build completed in 1.338sec
2020-05-09T15:14:22.112Z [4567/23816] - info: [build]          requirejs modules  build completed in 1.385sec
2020-05-09T15:14:22.575Z [4567/23816] - info: [build]            admin js bundle  build completed in 1.846sec
2020-05-09T15:14:22.732Z [4567/23816] - info: [build]           client js bundle  build completed in 2.004sec
2020-05-09T15:14:25.616Z [4567/23816] - info: [build]         client side styles  build completed in 4.886sec
2020-05-09T15:14:29.429Z [4567/23816] - info: [build] admin control panel styles  build completed in 8.699sec
2020-05-09T15:14:31.170Z [4567/23816] - info: [build]                  languages  build completed in 10.44sec
2020-05-09T15:14:31.314Z [4567/23816] - verbose: [meta/templates] Successfully compiled templates.
2020-05-09T15:14:31.314Z [4567/23816] - info: [build]                  templates  build completed in 10.584sec
2020-05-09T15:14:31.315Z [4567/23816] - info: [build] Asset compilation successful. Completed in 10.59sec.
[cluster] Restarting...
Clustering enabled: Spinning up 1 process(es).

[cluster] Child Process (23816) has exited (code: null, signal: SIGTERM)
2020-05-09T15:14:31.816Z [4567/20064] - verbose: * using configuration stored in: E:\projects\retipster-forum-new-1.13\config.json
2020-05-09T15:14:31.910Z [4567/20064] - info: Initializing NodeBB v1.13.3 http://localhost:4567
2020-05-09T15:14:31.910Z [4567/20064] - verbose: * using mongo store at 127.0.0.1:27017
2020-05-09T15:14:31.910Z [4567/20064] - verbose: * using themes stored in: E:\projects\retipster-forum-new-1.13\node_modules
2020-05-09T15:14:33.663Z [4567/20064] - verbose: [minifier] utilizing a maximum of 15 additional threads
2020-05-09T15:14:33.791Z [4567/20064] - verbose: Checking dependencies for outdated modules
2020-05-09T15:14:34.415Z [4567/20064] - verbose: [notifications.init] Registering jobs.
2020-05-09T15:14:34.416Z [4567/20064] - verbose: [user/jobs] (Re-)starting user jobs...
2020-05-09T15:14:34.417Z [4567/20064] - verbose: [user/jobs] Starting job (digest.daily)
2020-05-09T15:14:34.418Z [4567/20064] - verbose: [user/jobs] Starting job (digest.weekly)
2020-05-09T15:14:34.420Z [4567/20064] - verbose: [user/jobs] Starting job (digest.monthly)
2020-05-09T15:14:34.420Z [4567/20064] - verbose: [user/jobs] Starting job (reset.clean)
2020-05-09T15:14:34.421Z [4567/20064] - verbose: [user/jobs] 4 jobs started
2020-05-09T15:14:34.422Z [4567/20064] - verbose: [emailer] Setting up SMTP fallback transport
2020-05-09T15:14:34.446Z [4567/20064] - verbose: [middleware/autoLocale] Retrieves languages list for middleware
2020-05-09T15:14:34.467Z [4567/20064] - info: [themes] Using theme nodebb-theme-persona
2020-05-09T15:14:34.467Z [4567/20064] - verbose: [plugins] Initializing plugins system
2020-05-09T15:14:34.481Z [4567/20064] - verbose: [emailer] Built custom email templates
2020-05-09T15:14:34.491Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-theme-persona
2020-05-09T15:14:34.538Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-markdown
2020-05-09T15:14:34.602Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-mentions
2020-05-09T15:14:34.606Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-widget-essentials
2020-05-09T15:14:34.609Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-rewards-essentials
2020-05-09T15:14:34.610Z [4567/20064] - verbose: [plugins] Found 3 sound file(s) for plugin nodebb-plugin-soundpack-default
2020-05-09T15:14:34.610Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-soundpack-default
2020-05-09T15:14:34.685Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-emoji
2020-05-09T15:14:34.698Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-emoji-android
2020-05-09T15:14:34.817Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-composer-redactor
2020-05-09T15:14:34.868Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-dbsearch
2020-05-09T15:14:34.919Z [4567/20064] - verbose: [plugins] Loaded plugin: nodebb-plugin-spam-be-gone
2020-05-09T15:14:34.920Z [4567/20064] - verbose: [plugins/fireHook] filter:sanitize.config
2020-05-09T15:14:34.921Z [4567/20064] - info: [plugins] Plugins OK
2020-05-09T15:14:34.921Z [4567/20064] - verbose: [plugins/fireHook] static:assets.prepare
2020-05-09T15:14:34.922Z [4567/20064] - verbose: [plugins/fireHook] static:app.preload
2020-05-09T15:14:34.923Z [4567/20064] - verbose: [plugins/fireHook] static:app.load
2020-05-09T15:14:34.963Z [4567/20064] - verbose: [plugins/fireHook] action:markdown.updateParserRules
2020-05-09T15:14:34.964Z [4567/20064] - verbose: [emoji] Building emoji assets
2020-05-09T15:14:34.964Z [4567/20064] - verbose: [plugins/fireHook] filter:emoji.packs
2020-05-09T15:14:34.975Z [4567/20064] - verbose: [emoji] Loaded packs {"0":"a","1":"n","2":"d","3":"r","4":"o","5":"i","6":"d"}
2020-05-09T15:14:34.977Z [4567/20064] - info: [plugins/spam-be-gone] Settings loaded
2020-05-09T15:14:34.994Z [4567/20064] - verbose: [plugins] All plugins reloaded and rerouted
2020-05-09T15:14:34.994Z [4567/20064] - verbose: [plugins/fireHook] filter:auth.init
2020-05-09T15:14:35.016Z [4567/20064] - info: Routes added
(node:20064) ExperimentalWarning: The fs.promises API is experimental
2020-05-09T15:14:35.018Z [4567/20064] - verbose: [meta/blacklist] Loading 0 blacklist rule(s)
2020-05-09T15:14:35.019Z [4567/20064] - verbose: [plugins/fireHook] filter:flags.getFilters
2020-05-09T15:14:35.019Z [4567/20064] - info: NodeBB Ready
2020-05-09T15:14:35.024Z [4567/20064] - verbose: [plugins/fireHook] action:nodebb.ready
2020-05-09T15:14:35.024Z [4567/20064] - info: Enabling 'trust proxy'
2020-05-09T15:14:35.028Z [4567/20064] - info: NodeBB is now listening on: 0.0.0.0:4567
2020-05-09T15:14:50.289Z [4567/20064] - verbose: [plugins/fireHook] filter:user.getSettings
2020-05-09T15:14:50.289Z [4567/20064] - verbose: [plugins/fireHook] filter:user.notificationTypes
2020-05-09T15:14:50.298Z [4567/20064] - verbose: [plugins/fireHook] filter:middleware.buildHeader
2020-05-09T15:14:50.298Z [4567/20064] - verbose: [plugins/fireHook] filter:user.getSettings
2020-05-09T15:14:50.298Z [4567/20064] - verbose: [plugins/fireHook] filter:user.notificationTypes
2020-05-09T15:14:50.298Z [4567/20064] - verbose: [plugins/fireHook] filter:config.get
2020-05-09T15:14:50.302Z [4567/20064] - verbose: [plugins/fireHook] action:middleware.pageView
2020-05-09T15:14:50.303Z [4567/20064] - verbose: [plugins/fireHook] response:router.page
2020-05-09T15:14:50.311Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:50.311Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:50.316Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:50.316Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:50.316Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges.topics.filter
2020-05-09T15:14:50.318Z [4567/20064] - verbose: [plugins/fireHook] filter:post.getFields
2020-05-09T15:14:50.319Z [4567/20064] - verbose: [plugins/fireHook] filter:user.whitelistFields
2020-05-09T15:14:50.320Z [4567/20064] - verbose: [plugins/fireHook] filter:users.get
2020-05-09T15:14:50.321Z [4567/20064] - verbose: [plugins/fireHook] filter:parse.post
2020-05-09T15:14:50.358Z [4567/20064] - verbose: [plugins/fireHook] filter:user.whitelistFields
2020-05-09T15:14:50.359Z [4567/20064] - verbose: [plugins/fireHook] filter:users.get
2020-05-09T15:14:50.364Z [4567/20064] - verbose: [plugins/fireHook] filter:teasers.get
2020-05-09T15:14:50.366Z [4567/20064] - verbose: [plugins/fireHook] filter:categories.build
2020-05-09T15:14:50.366Z [4567/20064] - verbose: [plugins/fireHook] filter:middleware.render
2020-05-09T15:14:50.366Z [4567/20064] - verbose: [plugins/fireHook] filter:meta.getMetaTags
2020-05-09T15:14:50.367Z [4567/20064] - verbose: [plugins/fireHook] filter:meta.getLinkTags
2020-05-09T15:14:50.369Z [4567/20064] - verbose: [plugins/fireHook] filter:widget.render:html
2020-05-09T15:14:50.375Z [4567/20064] - verbose: [plugins/fireHook] filter:user.whitelistFields
2020-05-09T15:14:50.376Z [4567/20064] - verbose: [plugins/fireHook] filter:user.whitelistFields
2020-05-09T15:14:50.377Z [4567/20064] - verbose: [plugins/fireHook] filter:topics.unreadCutoff
2020-05-09T15:14:50.380Z [4567/20064] - verbose: [plugins/fireHook] filter:middleware.renderFooter
2020-05-09T15:14:50.382Z [4567/20064] - verbose: [plugins/fireHook] filter:users.get
2020-05-09T15:14:50.382Z [4567/20064] - verbose: [plugins/fireHook] filter:users.get
2020-05-09T15:14:50.383Z [4567/20064] - verbose: [plugins/fireHook] filter:user.getSettings
2020-05-09T15:14:50.383Z [4567/20064] - verbose: [plugins/fireHook] filter:user.notificationTypes
2020-05-09T15:14:50.383Z [4567/20064] - verbose: [plugins/fireHook] filter:scripts.get
2020-05-09T15:14:50.385Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:50.385Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges.global.get
2020-05-09T15:14:50.390Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:50.390Z [4567/20064] - verbose: [plugins/fireHook] filter:user.isModerator
2020-05-09T15:14:50.391Z [4567/20064] - verbose: [plugins/fireHook] filter:topics.getUnreadTids
2020-05-09T15:14:50.393Z [4567/20064] - verbose: [plugins/fireHook] filter:middleware.renderHeader
2020-05-09T15:14:50.767Z [4567/20064] - verbose: [plugins/fireHook] static:sockets.validateSession
2020-05-09T15:14:50.841Z [4567/20064] - verbose: [plugins/fireHook] action:analytics.increment
2020-05-09T15:14:51.142Z [4567/20064] - verbose: [plugins/fireHook] filter:manifest.build
2020-05-09T15:14:56.160Z [4567/20064] - verbose: [plugins/fireHook] static:sockets.validateSession
2020-05-09T15:14:56.169Z [4567/20064] - verbose: [plugins/fireHook] action:middleware.pageView
2020-05-09T15:14:56.170Z [4567/20064] - verbose: [plugins/fireHook] response:router.page
2020-05-09T15:14:56.173Z [4567/20064] - verbose: [plugins/fireHook] filter:user.getSettings
2020-05-09T15:14:56.173Z [4567/20064] - verbose: [plugins/fireHook] filter:user.notificationTypes
2020-05-09T15:14:56.173Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:56.173Z [4567/20064] - verbose: [plugins/fireHook] filter:user.isModerator
2020-05-09T15:14:56.175Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges:isUserAllowedTo
2020-05-09T15:14:56.175Z [4567/20064] - verbose: [plugins/fireHook] filter:privileges.categories.get
2020-05-09T15:14:56.176Z [4567/20064] - verbose: [plugins/fireHook] filter:category.topics.prepare
2020-05-09T15:14:56.177Z [4567/20064] - verbose: [plugins/fireHook] filter:categories.buildTopicsSortedSet
2020-05-09T15:14:56.178Z [4567/20064] - verbose: [plugins/fireHook] filter:categories.buildTopicsSortedSet
2020-05-09T15:14:56.178Z [4567/20064] - verbose: [plugins/fireHook] filter:categories.getSortedSetRangeDirection
2020-05-09T15:14:56.178Z [4567/20064] - verbose: [plugins/fireHook] filter:user.getSettings
2020-05-09T15:14:56.178Z [4567/20064] - verbose: [plugins/fireHook] filter:user.notificationTypes
2020-05-09T15:14:56.180Z [4567/20064] - verbose: [plugins/fireHook] filter:category.get
2020-05-09T15:14:56.181Z [4567/20064] - verbose: [plugins/fireHook] action:analytics.increment
2020-05-09T15:14:56.181Z [4567/20064] - verbose: [plugins/fireHook] filter:category.build
2020-05-09T15:14:56.181Z [4567/20064] - verbose: [plugins/fireHook] filter:middleware.render
2020-05-09T15:14:56.181Z [4567/20064] - verbose: [plugins/fireHook] filter:meta.getMetaTags
2020-05-09T15:14:56.181Z [4567/20064] - verbose: [plugins/fireHook] filter:meta.getLinkTags
2020-05-09T15:14:56.183Z [4567/20064] - verbose: [plugins/fireHook] filter:user.getSettings
2020-05-09T15:14:56.183Z [4567/20064] - verbose: [plugins/fireHook] filter:user.notificationTypes
2020-05-09T15:14:56.183Z [4567/20064] - verbose: [plugins/fireHook] filter:config.get
2020-05-09T15:14:56.185Z [4567/20064] - verbose: [plugins/fireHook] filter:widget.render:html
2020-05-09T15:14:56.277Z [4567/20064] - verbose: [plugins/fireHook] static:sockets.validateSession

It doesn't give me any error message. The console still show the same error:

nodebb.min.js?v=51c9rpk8efh:32571 Uncaught TypeError: Cannot read property 'length' of undefined
    at Object.composer.newTopic (nodebb.min.js?v=51c9rpk8efh:32571)
    at nodebb.min.js?v=51c9rpk8efh:32352
    at dispatch (nodebb.min.js?v=51c9rpk8efh:5731)
    at elemData.handle (nodebb.min.js?v=51c9rpk8efh:5535)
    at Object.trigger (nodebb.min.js?v=51c9rpk8efh:9017)
    at nodebb.min.js?v=51c9rpk8efh:9095
    at Function.each (nodebb.min.js?v=51c9rpk8efh:683)
    at jQuery.fn.init.each (nodebb.min.js?v=51c9rpk8efh:505)
    at jQuery.fn.init.trigger (nodebb.min.js?v=51c9rpk8efh:9094)
    at Object.app.newTopic (nodebb.min.js?v=51c9rpk8efh:17465)

Mickola

Hi there,

I just had a clean install of NodeBB 1.13.3 and tried to replace the default composer with redactor (or quill). However, everytime I click 'New Topic', it doesn't do anything and my console window shows the following error (referring to composer.js)

Uncaught TypeError: Cannot read property 'length' of undefined
    at Object.d.newTopic (composer.js:198)
    at client.js:23
    at dispatch (jquery.js:5429)
    at g.handle (jquery.js:5233)
    at Object.trigger (jquery.js:8715)
    at jquery.js:8793
    at Function.each (jquery.js:381)
    at x.fn.init.each (jquery.js:203)
    at x.fn.init.trigger (jquery.js:8792)
    at Object.app.newTopic (app.js:718)

I am still able to 'Reply' a topic. This issue doesn't happen with the default composer.

Any thoughts?

Mickola

I guess I found what the issue is. Apparently SendGrid API for Node.js doesn't seem to have fromname as one of its parameters. I modified the plugin and add a new line just before call SendGrid.send function.

// Add this line
data.from = data.from_name + '<' + data.from + '>';

SendGrid.send({
  to: data.to,
  toname: data.toName,
  subject: data.subject,
  from: data.from,
  fromname: data.from_name || userData.username || undefined,
  text: data.text,
  html: data.html,
  headers: data.headers,
  reply_to: replyTo,
}, next);

Now, it's working!

Mickola

@gotwf
I've added both "Email Address" and "From Name". The NodeBB I am using now is v1.11.2, SendGrid plugin: 2.2.3.
I check the plugin and index.js has the following:

SendGrid.send({
  to: data.to,
  toname: data.toName,
  subject: data.subject,
  from: data.from,
  fromname: data.from_name || userData.username || undefined,
  text: data.text,
  html: data.html,
  headers: data.headers,
  reply_to: replyTo,
}, next);

So, it seems fromname doesn't return anything, not even userData.username. Any ideas?

Mickola

Hi,

I am using SendGrid to send email from NodeBB. I went to Settings > Email and add both email address (eg: [email protected]) and from (eg: John Smith).

The email I receive only shows the email address ([email protected]) instead of John Smith <[email protected]>

Any idea what caused this issue?

Thanks!

Mickola

Hi,

I am using 'Persona' theme and have an issue with 'Reply' button. Currently, when I hit that button, it triggers a modal 'Create a new topic instead?' with 2 buttons to reply the topic or create a new topic.

I don't want this behaviour. Instead, I like the Reply button to open the composer.

Any direction?

Thanks!