Great thanks @julian , It was just that I noticed that npm audit still shows those vulnerabilities in version 2 but version 3 is okay.
Matthew Price
Posts
-
2.x security update cycle -
2.x security update cycleDo you have a timeline for when 2.x support will end in terms of receiving security updates?
Also I can see that webpack and socket.io versions were updated in March to protect against some identified vulnerabilities in v3. Is this likely to be rolled out to v2 as well? We could manually update these via package.json providing there's no breaking changes but wanted to check here first.
-
[nodebb-plugin-emoji] Emoji PluginNo problem, thanks @PitaJ, I noticed that it updated me to v5 when I ran an npm update but as I say I've backported back and now it's okay. I'll wait to hear from you regarding modifiers.
-
[nodebb-plugin-emoji] Emoji Plugin@Matthew-Price as an example
-
[nodebb-plugin-emoji] Emoji PluginIs https://github.com/NodeBB/nodebb-plugin-emoji/issues still the best place to raise issues for this plugin?
In the newest version of nodebb-plugin-emoji (5.0.5) the css is completely not working and just ends up looking like the following:
I've not looking massively into this but I can see the old version used less, whereas this is supposed to use sass so I'm not sure if this is the reason.
Because of this we backported to version 4.0.6. This works find exempt there is an issue I have raised in regards to skin tone modifiers, which I'm not sure if you're aware of. https://github.com/NodeBB/nodebb-plugin-emoji/issues/59
Not sure what version Nodebb uses on this community but I have noticed this forum is also affected by that.
-
HEIC Image Support?It works as a file upload but would be nice if it could be converted to a viewable image, especially as a lot of our audience are using newer iphones.
-
NodeBB have a work plugin for upload files on S3?The S3 plugin is a bit strange as there are a few variants as a lot of them appear to be forked and then abandoned again.
We were originally going to look at redeveloping our own plugin but found this one worked for our needs and still works in the latest version:
https://www.npmjs.com/package/nodebb-plugin-s3-uploads-updated-again
-
HEIC Image Support?Any plans for HEIC support? I understand it's not supported by browsers yet but it would be useful to have some way of converting file uploads to jpeg as we're starting to find this an issue with iPhone users.
-
3 Category Levels (trimChildren helper)@baris Yes I am using the 'treat as section' so it would be possible to check this config to determine whether to trim or not.
-
3 Category Levels (trimChildren helper)Thanks for response. Exactly what I was looking for
-
3 Category Levels (trimChildren helper)Our existing forum structure includes an extra level, which we use as a section heading. While this works this prevents our theme from showing the subcategories underneath.
I have tracked this down to the helpers.trimChildren function, which sets the children variable to undefined as a way of limiting the depth. As we need as extra depth level is there any way of overriding this function without having to resort to modifying core code?
You can see in these screenshots. The first screenshot is how it looks normally and the second is how we want it to look.