@julian I think I see this in Chrome on desktop as well, I will send you a link over chat to demonstrate. See if this gives you the right target as expected, or if it is too high up, thanks!
klockprat
Posts
-
Layout shift in 1.17.1 -
Layout shift in 1.17.1I see layout shift, a link to the first unread post usually ends up above the right target - I guess when images are being loaded.
This is seen in recent Chrome browsers on Android and IPhone.
Send a chat and I can share a url where this is visible (on hosted nodebb). We are new to nodebb and don't know if this is something that appeared in a recent version or not.
-
Block composer during upload/resize@pitaj said in Block composer during upload/resize:
So you can still submit while multiple photos are uploading?
Yes - or at least when I tried the last time, the upload showed 100%, but the tags were not replaced with the "resize". So maybe the upload was finished, but not the resize?
@baris said in Block composer during upload/resize:
Maybe it's a bug with the code that replaces the progress text with the actual filename. https://github.com/NodeBB/nodebb-plugin-composer-default/blob/master/static/lib/composer/uploads.js#L234-L248
So the upload is successful and it lets you submit the post but if the above code fails it won't replace the
Upload 100%
with the url of the image.When you reproduce this please check the network tab for the upload request and check if the file was uploaded in your public/uploads folder.
The uploads do not end up in the /uploads/files/ folder.
I'm using the hosted solution of nodeBB, and am of course happy to help debug further!
-
Block composer during upload/resize@baris said in Block composer during upload/resize:
I thought we already did this. https://github.com/NodeBB/nodebb-plugin-composer-default/blob/master/static/lib/composer.js#L668
Can you able to submit the post while a big upload is still going?
I have seen users post with the percentage showing, but now when I try I can't...
Tried again with several photos, and then it failed
-
[nodebb-plugin-rss] RSS Feed plugin@klockprat answering myself here, I decided to go with an external service instead (Zapier in my case) since I need a couple of other automations as well anyway
-
Block composer during upload/resize@pitaj said in Block composer during upload/resize:
That's a good suggestion. Do you mind requesting this feature on our GitHub page?
Done, as issue #9587
-
[nodebb-plugin-rss] RSS Feed plugin@baris just about to try this to feed our forum with some RSS.
Are there any plans on adding RSS content to the 2.x releases, or should I downgrade to have that functionality? Will you continue to support the 1.x releases?
Thanks!
-
Block composer during upload/resizeIs there any way to block the composer (default) to not enable the user to submit the post during upload/resizing of images
I get a few posts in the forum with the upload text instead of the real image. Would be great if the submit button was disabled until the upload and resize was done - or if the tag was updated first, and the upload/resize would continue in the background
-
Zommable imagesI run a forum with a lot of high res images. This causes a couple of problems
- loading times, this is managed by loading lower resolution images in the topic
- storage - this has several solutions
I would however want to solve this in a slightly different way, making the experience for the user more seamless.
Currently when a user wants to zoom an image, he first needs to click the image, load the original, and then zoom.
What I would want is the image to be zoomable in the topic. When a user zooms in the topic, JavaScript can identify the resolution and pixel density of the view, and reload a new higher resolution image as needed. Similar to a srcset for the browser, but dynamically force reloads.
I currently store images for the forum with netlify large media. I need to manually run scripts to move files from upload, send them to netlify, and update post links. This could all be handled by a plugin.
Netlify large media on its end provides transformation of your images to any resolution on the fly. This is fast and very convenient. No need to generate multiple versions of the images.
Example (these are all the same image):
What would I want then?
A plugin that uploads images to Netlify powered git LFS, and uses the transforms to load the right sized image for the view, and reloads a new version if the screen size changes, or the page is zoomed.For me this would be a fantastic feature, that nodeBB, as far as I know, would be the only forum software to have.
-
[nodebb-plugin-ns-likes] NS Likes@nicolas this looks like a nice plugin for us as well. Any plans on adding reactions instead of likes? As FB e.g. where you can choose like/heart/lol/etc
-
Reply button at end of topic@chez said in Reply button at end of topic:
@klockprat said in Reply button at end of topic:
<!-- IF privileges.topics:reply -->
<div class="clearfix quick-reply kp-quickreply">
<div class="pull-right">
<div component="topic/reply/container" class="btn-group action-bar bottom-sheet <!-- IF !privileges.topics:reply -->hidden<!-- ENDIF !privileges.topics:reply -->">
<a href="{config.relative_path}/compose?tid={tid}&title={title}" class="btn btn-sm btn-primary" component="topic/reply" data-ajaxify="false" role="button"><span class="visible-xs-inline visible-sm-inline visible-md-inline visible-lg-inline"> Reply</span></a>
</div>
</div>
</div>
<!-- ENDIF privileges.topics:reply -->Can you direct me under which category should it be injected?
In
partials/topic/quickreply.tpl
-
Reply button at end of topic@chez said in Reply button at end of topic:
@dunlix said in Reply button at end of topic:
@klockprat you could use
nodebb-plugin-customize
and add it as HTML yourself.Maybe you will agree to upload the html you edited?
I replaced the quick reply template with this
<!-- IF privileges.topics:reply --> <div class="clearfix quick-reply kp-quickreply"> <div class="pull-right"> <div component="topic/reply/container" class="btn-group action-bar bottom-sheet <!-- IF !privileges.topics:reply -->hidden<!-- ENDIF !privileges.topics:reply -->"> <a href="{config.relative_path}/compose?tid={tid}&title={title}" class="btn btn-sm btn-primary" component="topic/reply" data-ajaxify="false" role="button"><span class="visible-xs-inline visible-sm-inline visible-md-inline visible-lg-inline"> [[topic:reply]]</span></a> </div> </div> </div> <!-- ENDIF privileges.topics:reply -->
This way I can enable the button by enable quick reply. As you see I have removed the option to reply as a thread, I have also removed the icon and always show the text.
-
Reply button at end of topic@chez said in Reply button at end of topic:
@dunlix said in Reply button at end of topic:
@klockprat you could use
nodebb-plugin-customize
and add it as HTML yourself.Maybe you will agree to upload the html you edited?
Absolutely, as soon as I have something working I'll share here if you are interested!
I will probably change the quick reply template and change that into a button that opens the composer.
-
Use readmore.js for blockquotes@klockprat I will look inte customizing the template file to achieve this instead
-
Reply button at end of topic@dunlix that sounds great!
Edit: a rebuild and restart made the plugin visible.
Thought this plugin was only for modifying language strings, but this looks very powerful. Thanks a lot for pointing me to this!
-
Reply button at end of topicI am looking for an additional reply button at the end of the topic, alternatively that the quick reply field can easily open the composer.
A recurring comment from our users is that it's difficult to understand how to reply
-
Use readmore.js for blockquotesHi!
I'm migrating from another forum to hosted nodeBB but need som help with one important feature.
We have some users that make long posts, and when someone quotes, the quote become equally long, this makes it cumbersome to scroll throught the topic.
Other forums solve this by fading out, and a clickable "read more..." text that expands the big quotes.
I was hoping to do this as well, but am failing. Mainly I hope due to my lacking knowledge in javascript.
So I tried uploading
readmore.min.js
to /assets/uploads/... and added the following to custon javascript:function onLoad() { require(['/assets/uploads/readmore.min.js']); console.log('yeah it works'); console.log($('blockquote')); $('blockquote').readmore(); } $(document).ready(onLoad); $(window).on('action:ajaxify.end', onLoad);
This gives me the following output in the console:
Any help is much appreciated!