It was rather trivial to add the error message, here is how:
in uglify-js module, added a error reporting log to the file lib\parse.js in following method:
function js_error(message, filename, line, col, pos) {
console.log(message, filename, line, col, pos);
throw new JS_Parse_Error(message, filename, line, col, pos);
};
Looks like the error handling of fault barrier doesn't do what it supposed to.
@PitaJ Thank again for your help.
@pitaj that was great tip... When I bypass minification as you described (nodebb build --dev) it builds successfully, but it bombs out when I use 'nodebb build'. By the way I spend the whole day to run eslint to fix all of the reported issues but didn't help with build issue. Again thanks for the tip.
@pitaj said in How can I get more specific build error message:
JS linter plugin
@PitaJ Thank you,
Thanks gain.
Hello,
I am running nodebb 1.8.1 and developing few custom plugins. To build I generally use ./nodebb build from command line.
When there is an error, I sometimes get the following message:
D:\nb>nodebb build "javascript"
started
2018-04-04T20:29:53.546Z [155564] - info: [build] Building in parallel mode
2018-04-04T20:29:53.548Z [155564] - info: [build] plugin static dirs build started
2018-04-04T20:29:53.553Z [155564] - info: [build] requirejs modules build started
2018-04-04T20:29:53.554Z [155564] - info: [build] client js bundle build started
2018-04-04T20:29:53.556Z [155564] - info: [build] admin js bundle build started
2018-04-04T20:29:57.282Z [155564] - info: [build] plugin static dirs build completed in 3.734sec
2018-04-04T20:30:03.510Z [155564] - error: [build] client js bundle build failed
2018-04-04T20:30:03.512Z [155564] - error: [build] Encountered error during build step SyntaxError: Unexpected token: punc (,)
at JS_Parse_Error.get (eval at <anonymous> (D:\nb\node_modules\uglify-js\tools\node.js:21:1), <anonymous>:75:23)
at D:\nb\src\meta\minifier.js:115:19
at D:\nb\src\meta\minifier.js:242:11
at D:\nb\node_modules\async\dist\async.js:1126:9
at D:\nb\node_modules\async\dist\async.js:473:16
at iterateeCallback (D:\nb\node_modules\async\dist\async.js:980:24)
at D:\nb\node_modules\async\dist\async.js:958:16
at D:\nb\node_modules\async\dist\async.js:1123:13
at D:\nb\src\meta\minifier.js:212:4
at D:\nb\node_modules\graceful-fs\graceful-fs.js:78:16
2018-04-04T20:30:03.513Z [155564] - error: SyntaxError: Unexpected token: punc (,)
at JS_Parse_Error.get (eval at <anonymous> (D:\nb\node_modules\uglify-js\tools\node.js:21:1), <anonymous>:75:23)
at D:\nb\src\meta\minifier.js:115:19
at D:\nb\src\meta\minifier.js:242:11
at D:\nb\node_modules\async\dist\async.js:1126:9
at D:\nb\node_modules\async\dist\async.js:473:16
at iterateeCallback (D:\nb\node_modules\async\dist\async.js:980:24)
at D:\nb\node_modules\async\dist\async.js:958:16
at D:\nb\node_modules\async\dist\async.js:1123:13
at D:\nb\src\meta\minifier.js:212:4
at D:\nb\node_modules\graceful-fs\graceful-fs.js:78:16
This message is very generic and does not give me any clue were to look. I often resolve this issue by exhaustive search over my new code, specially looking at style and template files to find the error. I am however refactoring large part of my code and looking at diffs is becoming very time consuming if not impossible.
Is there an easy way to make uglify.js more verbose so it can tell me which file is breaking the build?
Any hint would be appreciated.
Thank you.
I work on nodebb 1.5.3 and accidentally made the grave mistake of installing a plugin using ACP and ended up losing all my development repos of non 'npm'ed plugins. At that point I decided to upgrade to latest 1.7.3 release since a fix (#6032) for this issue was supposed to be committed into that build. While I checked breaking change lists for 1.6.0 and 1.7.0, apparently I have over looked something since my list/grid topic-list show up all messed up (with no errors in console). I have a bootstrap based listview and gridview of the topics and I use JS code to select between them but now my page layout is gone like one of the libraries is not loading but I am not sure which one since I don't use anything other than jquery and bootstrap.I cannot figure this out but suspect it may be issue (#5980.) Any help would be appreciated and thank you in advance.
Edit:
I get the following error intermittently after several clicks and I am hoping to be related:
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
2017-12-31T06:55:43.950Z [1840] - error: /category/14/news
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
2017-12-31T06:55:49.005Z [1840] - error: /category/14/news
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
...
some more errors I get after refreshes:
2017-12-31T07:42:50.130Z [13716] - error: /category/5/general
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\category.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Error: Parsing failed for template D:\NodeBB-1.7.3\build\public\templates\500.js:
Script execution timed out.
at ContextifyScript.Script.runInContext (vm.js:53:29)
at ContextifyScript.Script.runInNewContext (vm.js:59:15)
at Object.runInNewContext (vm.js:112:38)
at evaluate (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\evaluate.js:17:6)
at fs.readFile (D:\NodeBB-1.7.3\node_modules\benchpressjs\build\lib\express.js:39:53)
at D:\NodeBB-1.7.3\node_modules\graceful-fs\graceful-fs.js:78:16
at tryToString (fs.js:513:3)
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:501:12)
@pitaj Thanks for the very helpful post. For the benefit of others who stumble upon same issue using multi-part middleware, the fix for issue in my original post was simply as follows:
plugin.init = function(params, callback) {
var app = params.router;
var middleware = params.middleware;
var multipart = require('connect-multiparty');
var multipartMiddleware = multipart();
var middlewares = [multipartMiddleware, middleware.applyCSRF];
var controller = uploadsController.uploadIcon;
var name = '/icon/upload';
app.post(name, middlewares, controller);
app.post('/api' + name, middlewares, controller);
app.get('/admin/icons', middleware.admin.buildHeader, renderAdmin);
app.get('/api/admin/icons', renderAdmin);
callback();
};
Thanks again for your support.Re: Documentation on making ajaxify.go work for custom routes?
Hello:
I am trying to create an alternate route, very similar to topic thumbnail upload route (/api/topic/thumb/upload) for uploading tiny icons. It appears that at server side, my controller does not receive the formData from ajaxSubmit call on the client side.
Currently, my plugin is using existing hook filter:uploadStored but it is adding significant complexity to my logic since I am required to preserve uploadThumb functionality. Besides the absence of image resize hook for bypassing that step caused a heck of work around.
Instrumentation shows the data flow correctly on the client side to AjaxSubmit and call is received at server endpoint but no data is uploaded.
Route definition:
plugin.init = function(params, callback) {
var app = params.router;
var middleware = params.middleware;
var multipart = require('connect-multiparty');
var multipartMiddleware = multipart();
var middlewares = [middleware.maintenanceMode, multipartMiddleware, middleware.validateFiles, middleware.applyCSRF];
var controller = uploadsController.uploadIcon;
// routeHelpers.setupPageRoute(app, '/icon/upload',middleware ,middlewares , uploadIcon);
var name = '/icon/upload';
app.post(name, middlewares, controller);
app.post('/api' + name, controller);
app.get('/admin/icons', middleware.admin.buildHeader, renderAdmin);
app.get('/api/admin/icons', renderAdmin);
callback();
};
My controller for uploadIcon has almost identical implementation as uploadsController.uploadThumb at this point:
uploadsController.uploadIcon= function(req, res, next) {
console.log('\n\n\nrequest object:',req); // I get request object without formData values
console.log('... files:',req.files); //undefined
console.log("... uuid:!%o",req.uuid); //undefined
console.log("...formData:!%o",req.formData); //undefined
// don't execute beyond this line
var files = req.files.files;
}
My change handler icon upload form container is identical to Thumb upload as well except the change handler calls icon upload function :
//uploadTopicIcon({files: files, post_uuid: post_uuid, route: '/api/topic/thumb/upload', formData: fd}); // everything works
uploadTopicIcon({files: files, post_uuid: post_uuid, route: '/api/icon/upload', formData: fd}); // no data is sent to server
This function is also almost identical to thumb upload except the names of the forms has changed:
function uploadTopicIcon(params) {
var post_uuid = params.post_uuid,
postContainer = $('#cmp-uuid-' + post_uuid),
spinner = postContainer.find('.topic-icon-spinner'),
iconForm = postContainer.find('#iconForm.');
iconForm.attr('action', config.relative_path + params.route);
iconForm.off('submit').submit(function() {
spinner.removeClass('hide');
uploads.inProgress[post_uuid] = uploads.inProgress[post_uuid] || [];
uploads.inProgress[post_uuid].push(1);
$(this).ajaxSubmit({
headers: {
'x-csrf-token': config.csrf_token
},
formData: params.formData,
error: onUploadError,
success: function(uploads) {
postContainer.find('#topic-icon-url').val((uploads[0] || {}).url || '').trigger('change');
},
complete: function() {
uploads.inProgress[post_uuid].pop();
spinner.addClass('hide');
}
});
return false;
});
iconForm.submit();
}
As I mentioned I have developed my plugin using the hooks but it is very intrusive and I really wish to get the custom route work. Any pointers appreciated since I have been pulling my hair for a few days now.
Thanks in advance