@baris Your solution was confirmed working for my plugin. Thank you Sir.

Re: nodebb-plugin-charts

I am trying install charts plug-in but doesn' look like it's working.

Here is my log information:
10/5 08:11 [7728] - warn: [plugins/load] The following plugins may not b
e compatible with your version of NodeBB. This may cause unintended behaviour or
crashing. In the event of an unresponsive NodeBB caused by this plugin, run ./ nodebb reset -p PLUGINNAME to disable it.

• nodebb-plugin-charts
• nodebb-plugin-spam-be-gone

Using given the metadata in example in the body of post simply does not interpret and appears as the text data.

Any idea?

Thanks.

@baris Your solution was confirmed working for my plugin. Thank you Sir.

@oplik0 I believe you are right. I am going wait longer and hope the support to be added later in the future. Thank you,

@julian sorry if I confused you.

getEmployeeDetail is Client-side function that emits the socket call to invoke server-side function SocketPlugins.employees.getDetail.

I verified that the call flow is being performed correctly and data from client is sent to server as those logs indicates.

The only issue is the client-side expects to get the 'person' data from server but somehow employees is populated with some weird callback object instead of the person. Is this correct assumption that returned value is assigned to employees in the following statement:
var employees = await socket.emit('plugins.employees.getDetail', {empId: empId,});

Thanks.

//Server-side 
var SocketPlugins = require.main.require('./src/socket.io/plugins');
SocketPlugins.employees.getDetail = async function (socket, data) {
	if (!data || !data.empId) {
		return null;
	}
	console.log('Got these parameters:', data); // params gets here as it should
	... do something  ...
	var person = { name: 'jimmy johnes', id: '007', address: '123 happy street', phone: '800-324-2344' };
	return person; **// Data is not going back to client** 
}

// client-side
async function getEmployeeDetail(empId) {	
	var employees = await socket.emit('plugins.employees.getDetail', {
		empId: empId,
	});
	console.log('Received callback from employees.getDetail:', employees); 
*// returned data is not correct and appears to be the callback object instead?!?!!?*
}

Re: Problem with socket in plugin after 1.12.2 -> 1.13.0 upgrade

Hello,

In a related scenario to the referenced topic, I have a problem migrating my plugins to conform with async/await calls. Looks like the returned data doesn't get to the calling client-side function.
Here is my test code in async/await form. Please note these functions work in old callback form:

var SocketPlugins = require.main.require('./src/socket.io/plugins');
SocketPlugins.employees.getDetail = async function (socket, data) {
	if (!data || !data.empId) {
		return null;
	}
	console.log('Got these parameters:', data); // params gets here as it should
	... do something  ...
	var person = { name: 'jimmy johnes', id: '007', address: '123 happy street', phone: '800-324-2344' };
	return person; **// Data is not going back to client** 
}

async function getEmployeeDetail(empId) {	
	var employees = await socket.emit('plugins.employees.getDetail', {
		empId: empId,
	});
	console.log('Received callback from employees.getDetail:', employees); 
*// returned data is not correct and appears to be the callback object ?!?!!?*
}

Client-side console:

Received callback from employees.getDetail: Tue Jan 28 2020 09:24:29 GMT-0500 (Eastern Standard Time)
i {io: i, nsp: "/", json: i, ids: 11, acks: {…}, …}*

Thank you for your guidance.

@Dan-Reyes I am not expert in Nodebb but getting stuck means number of things to me. I usually take some basic steps to get passed build/upgrade issues. You said you reset the plugin already. I would also clean the existing assets in \build\public and rebuild again. (Make sure back up your existing folder before experimenting)

Do you have any custom plugins? If you do, you may have an error that cases uglifier to silently crash. Temporarily modify uglify-es in node-module and change the following in parse.js and run to see if you get any parsing error:

function JS_Parse_Error(message, filename, line, col, pos) {
    this.message = message;
    this.filename = filename;
    this.line = line;
    this.col = col;
    this.pos = pos;

   // add following if not there
    console.log('*** Error: File:%s, Line:%d, Col:%d, Pos:%d, message:%s', filename, line, col, pos, message)
};

If you do have error clear it up and try again. Next, you may want to try the upgrade with different options to get to the bottom of this:

nodebb upgrade --help

Some tools like Atom have odd behavior and I recommend to quit them when upgrading. 

If nothing works, then you may want to install a fresh copy somewhere else and copy the content and overwrite your working instance. Again make sure to backup your data and custom work whatever you do.

@pitaj Thank you! I will give it a try.

Much appreciated.

@pichalite It is hard to answer such a questions since no premium and community collaboration is one of the strong reasons users choose open source products. That being said I like NodeBB and its community and I really like to see few more features and with the great talent behind this that is not far fetch. I am willing to pay what industry standard is to get the license for such premium features. I really need look into it to be able to give you my assessment on the price.

@PitaJ Great, thanks.

@PitaJ said in Choice of Grid Layout for Topics:

this is possible to do with a custom theme

Thanks for your reply @PitaJ .
I am rather thinking about a solution that is not limited to a specific theme and is not bugged down after each NodeBB release.

Will you consider creating a premium tier of official themes, built with committed features such as this one that can be purchased at a reasonable price? I am very concerned about maintenance of a set of custom features as your product evolves.