Same problem happens to me. Clicking on "Register" link in navigation results in error message "Error
Converting circular structure to JSON". Using latest from github

It works for me on latest. Maybe try to clear your cache.

AFAIK admins can see deleted topics and posts. If you log out, you shouldn't see it.

@igbuend said:

Small request for improvement: in library.js you have the hardcoded link http://platform.twitter.com/widgets.js . This gives problems (or warnings) with forums that run using "HTTPS". Can you modify the link to //platform.twitter.com/widgets.js? That way the browser will automatically choose HTTP or HTTPS depending on which protocol was used for loading the page :). Thanks!

Fixed

@Fayez-Abu-Helow Check chat message

@Fayez-Abu-Helow No, it should work after enabling it in admin panel. If you are using NodeBB 0.4.0, which was released yesterday, maybe these plugins are not compatible with it, but I can't test it myself right now so I can't tell you.

You need to restart your forum after installing plugin

@planner
Hm, Are you really running latest version? It should be 0.0.4. Because I have exactly same plugin installed here http://manutdforums.com it is working for me, can you check if it is working for you too?
Edit: Try reinstalling plugin completely with npm remove nodebb-plugin-google-adsense and then npm install nodebb-plugin-google-adsense

@planner Did you try to clear your cache?

@psychobunny said:

Nice work @dove totally destroyed my original plugin but this is good, one less plugin for me to have to update for 0.4x

I think a lot of people would find this useful. Thanks!

Haha, I saw your plugin, but I also saw this message "This plugin has been superceded by NodeBB's Widgets System, available as of v0.4.x.", so I thought that your probably won't update it any more

Had a few free mins again, so updated plugin.

• Fixed bug when ad in post was displayed even if disabled in admin panel;
• Made responsive height ad in post when enabled left or right position. For a short post ad will be 250x250 size, and for large post it will auto resize vertically to max of 600px.

@planner I noticed it now, there was wrong letter in if case check, so it shows ad in post even if disabled. But the most strange part is that google shows ads even without publisher ID and campagn ID specified, so I wonder who gets money for click ? Probably Google
Will update it sometime today.

@planner

@planner said:

@dove
If you have the time to make it a comprehensive ad plugin, here are a few suggestions:

• In the ACP, provide Location boxes for ads such that ad codes can be copies there.

• Locations could be for header, footer, left of post, right of post, middle of post, bottom of post, etc.

Sure I might find some free time next week and make it

@planner said:

@dove

If the plugin weekend competition was still going on, you'd have won. Thank you

No problems, had a couple of free hours today, so decided to make something

@planner said:

Within a post, can it show more than 1 ad? For example, if I have a very long post, can it place an ad at the top-left or top-right, and another won at the bottom of the post?

Is this for Google AdSense code only, or will it accept any ad code?

So far no, it can only show 1 ad inside post, but of course it can be improved and I will remember your suggestion when I update this plugin.
And it is for Adsense only

This plugin moved to https://github.com/NodeBB-Community/nodebb-plugin-adsense

#Install#
npm install nodebb-plugin-adsense

More info on GitHub

ACP Page

Ad Widget

Updated plugin, should work now.

@psychobunny Thanks, working great!

I tried to update to latest and got the same error

@julian said:

@dove Have you considered putting you code behind a $(document).ready();? That may be enough of a delay.

Aah, you gave me idea of delay. I set a timeout inside $(document).ready() with setTimeout and it seems to work, but with only $(document).ready() it didn't work.

I want to get if user is logged in when viewing static page on nodebb-plugin-static-page plugin. I can get user id by calling app.uid on client side javascript, but it is not reliable, because it seems it doesn't work when page is loaded freshly, not after ajax call from other page. Are there any ways to know if user is logged in?