Posts made by damian

damian

Thank you so much! I see this is packaged into the 1.13.2 release! Can't wait to try it out!

damian

It looks like this commit may have introduced the issue.

https://github.com/NodeBB/NodeBB/commit/7b90863971bdee5958432e65ce037e580755e93d

I'll do some investigation and see if changing this fixes it.

damian

Users post to my site and then share those posts to Facebook. After upgrading from 1.12.2 to 1.13.1 I no longer see proper description or og:description tags in the head. Instead, the posts shared to facebook include a description that reports that Javascript is disabled.

I'm not sure where to look in the code to try to find what might be affecting the change and I'm unsure if this is something specific to me.

Both my stage and prod forums have been upgraded to the 1.13.1 and then I downgraded stage. So both are running the same DB schema.

Here's the head section from my staging site which I downgraded to 1.12.2

<!DOCTYPE html>
<html lang="en-US" data-dir="ltr" style="direction: ltr;"  >
<head>
	<title>Review: 2019-05-04- The Civic Theater - New Orleans, LA | Spaffnerds: Of Nerds, By Nerds, and For Nerds</title>
	<meta name="viewport" content="width&#x3D;device-width, initial-scale&#x3D;1.0" />
	<meta name="content-type" content="text/html; charset=UTF-8" />
	<meta name="apple-mobile-web-app-capable" content="yes" />
	<meta name="mobile-web-app-capable" content="yes" />
	<meta property="og:site_name" content="Spaffnerds" />
	<meta name="msapplication-badge" content="frequency=30; polling-uri=https://forum.stage.spaffnerds.com/sitemap.xml" />
	<meta name="keywords" content="Spafford,Jam Band,Music,Funk,Soul,Rock" />
	<meta name="msapplication-square150x150logo" content="/assets/uploads/system/site-logo.png" />
	<meta name="title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta name="description" content="Setlist, Attendance, and Recordings for: 2019-05-04 - The Civic Theater - New Orleans, LA After three weeks of Spaffnerds tearing each other apart, consoling one another, and having emotions and rumors flying around like crazy, The day was finally here. W..." />
	<meta property="og:title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta property="og:description" content="Setlist, Attendance, and Recordings for: 2019-05-04 - The Civic Theater - New Orleans, LA After three weeks of Spaffnerds tearing each other apart, consoling one another, and having emotions and rumors flying around like crazy, The day was finally here. W..." />
	<meta property="og:type" content="article" />
	<meta property="article:published_time" content="2019-05-07T04:51:45.205Z" />
	<meta property="article:modified_time" content="2019-05-22T22:33:17.566Z" />
	<meta property="article:section" content="Reviews" />
	<meta property="og:image" content="https://i.imgur.com/KpG7iM6.png" />
	<meta property="og:image:url" content="https://i.imgur.com/KpG7iM6.png" />
	<meta property="og:image" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:image:url" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:url" content="https://forum.stage.spaffnerds.com/topic/757/review-2019-05-04-the-civic-theater-new-orleans-la" />

Here's the head section from my production site which I downgraded to 1.13.1

<!DOCTYPE html>
<html lang="en-US" data-dir="ltr" style="direction: ltr;"  >
<head>
	<title>Review: 2019-05-04- The Civic Theater - New Orleans, LA | Spaffnerds: Of Nerds, By Nerds, and For Nerds</title>
	<meta name="viewport" content="width&#x3D;device-width, initial-scale&#x3D;1.0" />
	<meta name="content-type" content="text/html; charset=UTF-8" />
	<meta name="apple-mobile-web-app-capable" content="yes" />
	<meta name="mobile-web-app-capable" content="yes" />
	<meta property="og:site_name" content="Spaffnerds" />
	<meta name="msapplication-badge" content="frequency=30; polling-uri=https://forum.spaffnerds.com/sitemap.xml" />
	<meta name="keywords" content="Spafford,Jam Band,Music,Funk,Soul,Rock" />
	<meta name="msapplication-square150x150logo" content="/assets/uploads/system/site-logo.png" />
	<meta name="title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta name="description" />
	<meta property="og:title" content="Review: 2019-05-04- The Civic Theater - New Orleans, LA" />
	<meta property="og:description" />
	<meta property="og:type" content="article" />
	<meta property="article:published_time" content="2019-05-07T04:51:45.205Z" />
	<meta property="article:modified_time" content="2019-05-22T22:33:17.566Z" />
	<meta property="article:section" content="Reviews" />
	<meta property="og:image" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:image:url" content="https://i.imgur.com/Fqa89tW.png" />
	<meta property="og:url" content="https://forum.spaffnerds.com/topic/757/review-2019-05-04-the-civic-theater-new-orleans-la" />

damian

@mat-m is spot on, though my perspective is definitely production, not test. Running the leanest container possible has the added benefit of reducing the attack vectors as there is simply less surface for somebody to target. Alpine is specifically designed to be as lightweight as possible and as stripped down as possible.

Do we know who owns the image build process and can s/he weigh in on this?

damian

I noticed that the official images for nodebb are built on the default node images which are built on debian. This produces rather large images. For example the v1.12.1 build is 1.39gb. I built the 1.12.x branch off of the alpine image and it is 569mb in size.

Is there a reason that we aren't using alpine by default for the official images? Would it be possible to publish both debian based and alpine based official images? It seems like it would be easy to just keep a parallel Dockerfile for alpine and build and distribute both images.

damian

@PitaJ The plugin can be found here:
https://github.com/bsparks/nodebb-plugin-jwt

damian

@PitaJ Well that explains it. I'm npm linking it

The plugin doesn't appear to be available in ACP and the version in NPM looks out of date. Forgive my newbie nature, but what are my options here to get this running in production?

damian

So it turns out that the JWT plugin works, it's just missing a dependency. The package.conf needs nconf installed. Once it's there the plugin starts up as expected.

From there it's very simple. Just browse to yourforum.com/api/jwt and you'll get the token if you're logged in, or you'll be redirected to the login page if you're not. Write a bit of code in your site to consume this from an ajax call and save it locally for some period of time. I suppose you could get it on each load but that seems wasteful. Cache it in local storage and the user is now logged in on your site as well.

damian

@Shard if I'm not mistaken the session sharing plugin allows you to create users in YOUR application and then share them into nodebb. I'm not sure about the OP but I'm working on the reverse solution. Given the great user management/profile system in nodebb, I want to leverage that and then just share that user into my application.

There's a jwt plugin that should expose a jwt which can then be used in a non-nodebb app. Unfortunately it isn't in acp and it looks like it isn't up to date. It doesn't show up after being activated and the dev log reports that the plugin may not work with the current version of nodebb.

I'm going to spend a little time trying to get it updated. I think there's a lot of value in this because of how robust the entire user system is in nodebb.

damian

@JaredBusch I'll see if I can put some info together on this and report back. I just got a local (dev) install running of my forum so I can run with debug output and see what I can get. It's still happening.

Stay tuned, and thanks for the reply.

damian

@TaLoche I have the same problem on mobile. It works fine on desktop but on mobile I get

"Error

Something went wrong when parsing the server response."