@Nicolas first of all, I must apologize for my reply. I read it and doesn't sound well. Sorry.

So NodeBB already convert it to string.. It is strange.. Do you have any idea why is it happening? Why if I send an string instead of a number through the websocket it works? It seems it isn't caused by other plugins which parse the post.

Maybe is a bug appending string to integer in a old NodeJS version?

@PitaJ said in Chat REST API endpoint changes:

@alberto__segura this was changed precisely to allow admins to look through other user's chats. That's why this was necessary.

You're just being anal over such a small thing. Deal with it.

Oh, i didn't realized admins can now read user private conversations. Now it have more sense. Anyway, the usual endpoint should work for the actual logged user. Also, I don't like the admins could directly read other users conversations

@PitaJ said in Chat REST API endpoint changes:

It's not a big deal. /api/chats returns the relative url you need, so doing something like this isn't hard:

fetch('/api/chats')
  .then(body => body.text())
  .then(url => fetch(url))
  .then(body => body.json())
  .then(result => {
    // do something with your resulting object
  });

Yeah, it is not difficult, but it is totally illogic. If you do a API REST, please, do it well or don't do it. It's obvious that /api/chats will show actual logged user chats. It is not necessary to add the username in the endpoint url. An user cannot read other users chats, it is absurd.

Yes you can do two requests to fetch the user chats, you can do all the request you want, why do you not add more? If you are developing a mobile app to use the REST API, it doesn't matter how many request you do, it doesn't matter if your app consume all the data the user has contracted.

Yes, it's not difficult to make two or more request, but it is not efficient, and it isn't a well designed API. To do a bad API, don't do anything and save your time.

Also, if you think that it is well designed, please, do all your API equal. /api/notifications should be /api/user/{userslug}/notifications if we follow the same logic. It is bad designed, but at least follow the same logic.

@Nicolas said in [nodebb-plugin-ns-spoiler] NS Spoiler:

Screenshot only gives me an information that it tries to lookup from index 1 in the post, and can not find it. Do you use plugins which parse posts?

Do you know to read?

Index is irrelevant, if you read your own code you will realize that you don't use the index before parse the post. The error is that "getPostFields" (this line) is not returning any post due to the type of the "postId" variable, which it seems to be string instead of integer.

Why isn't it working? I don't know, maybe due to some index based on previous NodeBB versions or maybe due to the version of MongoDB.

I have tested in my local nodebb forum for tests and it works with both integer and string type, but some forums only seems to accept string. As i said, maybe due to previous versions of NodeBB or a different version of MongoDB.

In the last versions of NodeBB you have changed the chats endpoint for your REST API from: /api/chats to /api/user/{userslug}/chats.

It doesnt make any sense. Now, a third party app which uses the REST API needs to get the userslug or do a manual redirect to the new endpoint. It doesnt make any sense since the chat rooms for the logged user must be retrieved easily by making a simple request to /api/chats. Just like it was before and just like you must do to get the notifications (/api/notifications).

Please, bring back the usual endpoint.

@Nicolas said in [nodebb-plugin-ns-spoiler] NS Spoiler:

Easiest test guys:

create a single post with only one spoiler, let's say content of the spoiler like this:

:::

spoiler content

:::

Three questions:

1. Does it render properly your spoiler? It should have only a single button in the post.
2. Inspect HTML of your post with a spoiler, what index do you see there? data-index of div.ns-spoiler
3. When you click a spoiler button, do you see an original content or an error in the console? Content of the error?

Have you seen that?

(posted by @exodo a few days ago)

Here you have the problem, you must check server side the type of the 'postId' parameter and convert to string to be sure it will return post content. You should add the conversion on this line.

@PitaJ said in Nested quotes:

@alberto__segura

Why not remove it?

Because it's an intrinsic part of markdown that requires work to remove.

we only need a simple regex, we did it in older versions with a custom composer (https://github.com/exo-do/nodebb-plugin-composer-exodo/commit/da2351cf94baf1c8580af4c760b1ff19785e3198), but we cannot maintain our own custom composer. It should be part of default NodeBB composer.

@PitaJ said in Nested quotes:

4 deep

3 deep

2 deep

1 deep

0

To hide nested quotes 3 deep or more, you can use the following custom CSS:

blockquote > blockquote blockquote {
  display: none;
}

To hide 2 deep or more, use this:

blockquote blockquote {
  display: none;
}

Also, what happened to the quote collapsing? It works on this forum.

This workaround is shit. It is inefficient. It could reach a high data usage over 3G/4G. As you said, users dont need more than 3 levels of deep, so why not to remove it? We could do NodeBB easier, faster and more efficient.

I did a super-simple iOS app in Swift (https://github.com/segura2010/exodobb-for-iOS) for a forum.
It was my first iOS app, so design is not beautiful, and code is not well organized.. but it works well and is very fast

Then I started working in a Android app, i called it bbTalk. It allows to manage different accounts for differents forums (yes, just a tapatalk for NodeBB forums). The code is better than the code for iOS app, but I am doing the app in my free time, so the app is not finished
I haven not publish the code, but I would like to publish it on Github. Basically because i am doing a library to use the rest API and WebSockets of NodeBB, so it could be interesting for others apps.

Some pics of the iOS app:

Some pics of the Android app:

@julian said:

@alberto__segura that works just fine no need to change what works really.

I wanted to have notifications that are always correct. If two users reply, the notification recipient would only get one notif. That's okay, but could be better. These grouped notifications do the trick.

yes, grouped notifications are the best solution for the web notifications, but we thought about the plugin and email notifications. If you use the Telegram Bot plugin or the pushbullet plugin, you will receive a lot of notifications from the same topic or post, we doesn't like it, so we tried to fix it. I think both solutions could work together pretty well

@julian said:

I initially wanted to group them as they were created, although it is difficult given that each individual notification can be shared with other users.

It gets complicated in situations like:

• Notification: User replied to topic
• Notification pushed to 4 users
• 2 of those users read that notification
• A different user replied to that topic

Now, what happens here? Do we modify the existing notification object? If we do, then the two users who read the notification already will receive a notification with incorrect data (that is, it will say two users replied to a topic, when it should say 1).

In hindsight, it might actually be better to keep notifications granular, and have each individual client handle duplication separately...

Do not send notification to the users who didnt read these notifications. In @exodo we modified the notifications and it doesn't send notification to the user who hasn't read last notification about something. For example: if someone favourited your post, you wont receive more notifications about more favs for that post until you read that post.

@MJ said:

@alberto__segura said:

Your redisdb is open to outside.. :S

I use DigitalOcean hosting

Is there a tutorial how to make redisdb not open to outside.
And if I do, this problem cannot return?

as @julian said, you should read it: http://redis.io/topics/security

Your redisdb is open to outside.. :S

@baris i understand Thanks!
I'm not good with nginx configuration, so i thought use cluster was easier, but use nginx is better.

@julian mmm i understand! Thanks for your explanation!
So cluster is bad with socketio.. There no way to redirect all request from an IP to the same worker? It should fix the problem with socketio, i think..

Now i know that cluster isn't good to use with socketio

Hi everyone!
I have read this, and I don't know if nodebb use cluster library from NodeJS or something similar

Can someone explain to me if nodebb is able to use cluster library?
I know that you can run nodebb in different instances (using different ports), but i don't know if it uses cluster to do that or not.. What is the different between run different instances of nodebb and use cluster library with multiple workers? What is better?
If Nodebb don't use workers, would be use cluster lib a good idea?

Thanks!!

@lombisi check out https://github.com/exo-do
We have done a plugin to ignore users and other to ban users for a specified time.

@ngsankar said:

@exodo . thank you . I managed to install and configure. However after first msg is sent from telegram, nodebb got broken and stopped working.

Its strange , there is no reference to the plugin in the error log...luckily i was clearly noting down action i was doing...and guessed something going wrong here...after i removed the plug in , forum got up and running...i am able to reproduce it now..v0.8.2 is not liking something, but dont know what. Hope u r able to find it...I like the plug in..if this is resolved,...i will surely use it..thanks for ur effort...

following is the error log

3/11 13:14 [15929] - info: NodeBB v0.8.2 Copyright (C) 2013-2014 NodeBB Inc.
3/11 13:14 [15929] - info: This program comes with ABSOLUTELY NO WARRANTY.
3/11 13:14 [15929] - info: This is free software, and you are welcome to redistribute it under certain conditions.
3/11 13:14 [15929] - info:
3/11 13:14 [15929] - info: Time: Tue Nov 03 2015 13:14:10 GMT-0500 (EST)
3/11 13:14 [15929] - info: Initializing NodeBB v0.8.2
3/11 13:14 [15929] - warn: [plugins/nodebb-plugin-sso-facebook] Hook filter:user.delete is deprecated, please use an alternative
3/11 13:14 [15929] - warn: [plugins/nodebb-plugin-sso-google] Hook filter:user.delete is deprecated, please use an alternative
3/11 13:14 [15929] - info: NodeBB Ready
3/11 13:14 [15929] - info: NodeBB is now listening on: 0.0.0.0:4567
3/11 13:14 [15929] - error: TypeError: undefined is not a function
at /home/ngsankar/nodebb/src/user/posts.js:37:12
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:697:13
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:52:16
at done (/home/ngsankar/nodebb/node_modules/async/lib/async.js:248:21)
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:44:16
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:694:17
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:173:37
at /home/ngsankar/nodebb/src/user.js:405:5
at fireFilterHook (/home/ngsankar/nodebb/src/plugins/hooks.js:86:11)
at Object.Plugins.fireHook (/home/ngsankar/nodebb/src/plugins/hooks.js:70:5)
at filterIsModerator (/home/ngsankar/nodebb/src/user.js:400:12)
at /home/ngsankar/nodebb/src/user.js:462:6
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:697:13
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:52:16
at done (/home/ngsankar/nodebb/node_modules/async/lib/async.js:248:21)
at /home/ngsankar/nodebb/node_modules/async/lib/async.js:44:16

We use 0.7.3 in our forum... But i have updated it to work on 0.8.2
Now it should work fine! Thanks you for using!

@ngsankar said:

@exodo , I want to use this plugin. After activating the plugin, it seems to break something and bringing nodebb down. Not 100% sure if this is to do with this plugin, but after removing the plugin, nodebb is back. log output is below, any advise ? thanks.

I am using nodebb v0.8.2 , mongodb 3.0.7 with nodejs v0.10.40.

30/10 10:40 [12462] - info: Time: Fri Oct 30 2015 10:40:44 GMT-0400 (EDT)
30/10 10:40 [12462] - info: Initializing NodeBB v0.8.2
30/10 10:40 [12462] - info: [database] Checking database indices.
30/10 10:40 [12462] - warn: [socket.io] Clustering detected, you are advised to configure Redis as a websocket store.
30/10 10:40 [12462] - warn: [plugins/nodebb-plugin-sso-google] Hook filter:user.delete is deprecated, please use an alternative
30/10 10:40 [12462] - warn: [plugins/nodebb-plugin-sso-facebook] Hook filter:user.delete is deprecated, please use an alternative
30/10 10:40 [12462] - error: ReferenceError: callback is not defined
at /home/ngsankar/nodebb/node_modules/nodebb-plugin-telegram-notifications/library.js:76:11
at handleCallback (/home/ngsankar/nodebb/node_modules/mongodb/lib/utils.js:96:12)
at /home/ngsankar/nodebb/node_modules/mongodb/lib/collection.js:1322:5
at handleCallback (/home/ngsankar/nodebb/node_modules/mongodb/lib/utils.js:96:12)
at /home/ngsankar/nodebb/node_modules/mongodb/lib/cursor.js:666:5
at handleCallback (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:244:5)
at setCursorNotified (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:564:3)
at /home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:672:16
at queryCallback (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:323:5)
at Callbacks.emit (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:95:3)
at null.messageHandler (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:243:23)
at Socket.<anonymous> (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/connection/connection.js:262:22)
at Socket.emit (events.js:95:17)
at Socket.<anonymous> (stream_readable.js:765:14)
at Socket.emit (events.js:92:17)
at emitReadable (_stream_readable.js:427:10)
ReferenceError: callback is not defined
at /home/ngsankar/nodebb/node_modules/nodebb-plugin-telegram-notifications/library.js:76:11
at handleCallback (/home/ngsankar/nodebb/node_modules/mongodb/lib/utils.js:96:12)
at /home/ngsankar/nodebb/node_modules/mongodb/lib/collection.js:1322:5
at handleCallback (/home/ngsankar/nodebb/node_modules/mongodb/lib/utils.js:96:12)
at /home/ngsankar/nodebb/node_modules/mongodb/lib/cursor.js:666:5
at handleCallback (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:244:5)
at setCursorNotified (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:564:3)
at /home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:672:16
at queryCallback (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:323:5)
at Callbacks.emit (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:95:3)
at null.messageHandler (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:243:23)
at Socket.<anonymous> (/home/ngsankar/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/connection/connection.js:262:22)
at Socket.emit (events.js:95:17)
at Socket.<anonymous> (stream_readable.js:765:14)
at Socket.emit (events.js:92:17)
at emitReadable (_stream_readable.js:427:10)
30/10 10:40 [12462] - info: [app] Shutdown (SIGTERM/SIGINT) Initialised.
30/10 10:40 [12462] - info: [app] Database connection closed.

net.js:1237
throw new Error('Not running');
^
Error: Not running
at Server.close (net.js:1237:11)
at shutdown (/home/ngsankar/nodebb/app.js:294:36)
at process.<anonymous> (/home/ngsankar/nodebb/app.js:174:3)
at process.emit (events.js:95:17)
at process._fatalException (node.js:301:26)

Hi! We have fixed the error
Now it should work well! Thank you for use our plugin!

Safari bug fixed on my pull request https://github.com/NodeBB/nodebb-plugin-composer-redactor/pull/12