Community

Thought about using a stricter style guide?

NodeBB Development
  • PitaJP

    In my opinion, AirBnB's style guide is the best of them all. It could also help you move over to ES6 eventually since they're working on that, too.

    Also, lose the damned tabs!

    0
  • yariplusY

    Hmm, idk, some parts of the code could use better adherence to a style for consistency, and it may encourage new contributors.

    I feel like styles are largely based on opinion though. And in situations where a style does help, such as avoiding confusing/ambiguous expressions, NodeBB rarely suffers from these problems.

    I am against tabs though. I hate them. Used to love them, but after using spaces, i can never go back. (I really really hate semicolons too.)

    0

Suggested Topics

  • vinuV
    ●

    NodeBB Pods non response after dumping 12 lack data using jmeter scripts

    NodeBB Development
    0 Votes
    6 Posts
    465 Views

    vinuV

    @volanar Thans for the suggestion. After switching to Postgres we are still not getting the better troughput than redis.

    @julian Is it possibl to share the any benchmark results of MongoDB.

    The only option we have now to go with redis(RDB + AOF) with the above results shared by @venkat123 here
    https://community.nodebb.org/post/84368

    Any suggestions on MongoDB, Redis or Postgress config setting to get better performance.

  • DoppyD
    ●

    I want use my flag.json or error.json in my plugin

    NodeBB Development
    0 Votes
    3 Posts
    939 Views

    PitaJP

    And you need to run ./nodebb build after making changes.

  • S
    ●

    Use case for subforums

    NodeBB Development
    0 Votes
    2 Posts
    1073 Views

    julianJ

    Hey @Shawn-Price, thanks for reaching out. It still seems like groups + forums per group would be the ideal answer here. Right now out-of-the-box, there is no support for NodeBB to create a category for a group whenever a group is created (the "group forum" concept), though this can be easily automated via a custom NodeBB plugin.

    Just as with @grumpi, I'd advise you to reach out to us at [email protected] and we can come up with a custom quote for you.

    Thanks!

  • S
    ●

    [Best practices?] If I'm running a droplet and want to use multiple urls for different node apps...?

    NodeBB Development
    0 Votes
    4 Posts
    1731 Views

    S

    I restarted nginx, and do so whenever I try to make changes, but it's not working... Is something like this valid? I made sure the file in sites-available and sites-enabled are linked.

    upstream io_nodes { ip_hash; server 127.0.0.1:4567; } server { listen 80; server_name forums.violetcomics.com; proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header Host $http_host; proxy_set_header X-NginX-Proxy true; proxy_redirect off; # Socket.io Support proxy_http_version 1.1; proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection "upgrade"; gzip on; gzip_min_length 1000; gzip_proxied off; gzip_types text/plain application/xml application/x-javascript text/css application/json; location @nodebb { proxy_pass http://io_nodes; } location ~ ^/(images|language|sounds|templates|uploads|vendor|src\/modules|nodebb\.min\.js|stylesheet\.css|admin\.css) { root /path/to/nodebb/public/; try_files $uri $uri/ @nodebb; } location / { proxy_pass http://io_nodes; } }

    Edit: Error came back. @[email protected] I'll get back to it later.

  • maniM
    ●

    How can I use dump.rdb in other nodebb?

    NodeBB Development
    0 Votes
    4 Posts
    1818 Views

    maniM

    @julian Thanks!

Copyright © 2023 NodeBB | Contributors