[nodebb-plugin-unresponsive] Unresponsive design

[boomzilla]

The way that NodeBB's responsive design works has irritated some of our users, so we came up with a plugin to allow users to effectively disable it.

The biggest complaint was getting the small / mobile composer view when the browser's window went below ~1000px.

[NedFodder]

@boomzilla The menu items don't work in FF.

Ubuntu x64 14.04, Chrome on left, FF on right:

SO says to use span.textContent instead of span.innerText.

[NedFodder]

@NedFodder Whoops, my FF (v44) is out of date. innerText was supposed to be added back in March (v45). I'll update to v46 and test again...

[boomzilla]

@NedFodder Not sure what's going on. Looks like a translator failure? Here I have Chrome / FF. Though maybe there's a better way than innerText?

[julian]

Neat! I'm kind of disappointed that a plugin had to be made to downgrade a part of NodeBB, but that's the beauty of open-source

[NedFodder]

@boomzilla said in [nodebb-plugin-unresponsive] Unresponsive design:

Looks like a translator failure

Definitely not, I added a console.log in createMenuItem and the translated text is there. See my second post, innerText should be fine on FF v45+.

[boomzilla]

@julian said in [nodebb-plugin-unresponsive] Unresponsive design:

to downgrade a part of NodeBB

Well, that's in the eye of the beholder.

@NedFodder said in [nodebb-plugin-unresponsive] Unresponsive design:

See my second post, innerText should be fine on FF v45+.

Yeah, but it's apparently nonstandard. I just didn't know any better. Seems like textContent is what you're supposed to use.

[boomzilla]

Updated to v0.1.1, should work on that old FF now.

[boomzilla]

For now, at least, it's disabled when the user picks a custom skin, because it works my changing CSS sheets and the skins come from a different domain, so cross origin policies prevent the ability to modify them.

[boomzilla]

This is growing and becoming a stylish front end. v0.3.0: