[nodebb-plugin-blog-comments] Blog Commenting Engine (Ghost, Wordpress widget)

[phenomlab]

@baris No - see below for a new post (Ghost) I just created

The DIV is empty on the screen, but in the code, I see

It's almost like it thinks the post is already published

[PitaJ]

@phenomlab does the ghost script get loaded from your NodeBB site?

[baris]

@phenomlab I will publish a new version for you to test.

[phenomlab]

@PitaJ Yes, I think this is the case as previously created blog posts seem to work fine and are pulling comments.

[phenomlab]

@baris Thanks

[baris]

Please try with v0.8.5

[phenomlab]

@baris Still the same I'm afraid. Installed, rebuilt and restarted. Also seeing this in the logs

2022-03-10T19:13:05.237Z [4567/195325] - error: GET /comments/get/622a4540dbb475d0e913fa95/0
TypeError: Cannot read property 'postcount' of null
    at Comments.getCommentData (/home/sudonix/nodebb/node_modules/nodebb-plugin-blog-comments/library.js:95:24)
    at async /home/sudonix/nodebb/src/routes/helpers.js:60:5
2022-03-10T19:13:31.810Z [4567/195325] - error: GET /comments/get/622a4540dbb475d0e913fa95/0
TypeError: Cannot read property 'postcount' of null
    at Comments.getCommentData (/home/sudonix/nodebb/node_modules/nodebb-plugin-blog-comments/library.js:95:24)
    at async /home/sudonix/nodebb/src/routes/helpers.js:60:5

[baris]

Did you make a new blog post after upgrading plugin to 0.8.5? Can you send a link to it?

[phenomlab]

@baris said in [nodebb-plugin-blog-comments] Blog Commenting Engine (Ghost, Wordpress widget):

Did you make a new blog post after upgrading plugin to 0.8.5? Can you send a link to it?

Yes, here you go
https://content.sudonix.com/testing-2/

[baris]

Ok try with 0.8.6 and let me know.

[phenomlab]

@baris That works

What changed ? It was working fine ?

[baris]

It was due to an bug I introduced when I rewrote the plugin a while back, when there was no topic found on the nodebb side it was sending back 404, instead it needs to return 200 but an undefined topic id so it can display the publish article button.

https://github.com/psychobunny/nodebb-plugin-blog-comments/commit/72df07603526a74fd305dd1ec4ab18d06f1fb692

0 barisusakli committed to psychobunny/nodebb-plugin-blog-comments

fix: do not 404 if mapping isnt established yet

[phenomlab]

@baris Great ! Thanks for fixing this.

[baris]

@phenomlab No worries, thanks for reporting the issue.