@frissdiegurke said in [nodebb-plugin-emoji-extended] Emoji Extended (reworked):
@exodo great job
A few things I noticed (just checked the code; not tested. Might be wrong at some point):
- You did not replace/remove the mappings, so there are mappings like
:-? that point to
confused when there is no such image.
- You should change the content of public/static/styles/[email,main].css instead of the .less files since only the css files get read. There is no less parsing at runtime.
- "inet" is a pretty bad-to-search name o_O it would be great to have a link within the attribution if there is any
- please put your own set ID here, this could cause some problems with cubicopp being installed in parallel otherwise.
- tiny typo
Since you've deactivated issues for that repo, I post the list here
Feel free to tell me about any issues you came across so we might decrease the barrier of publishing new sets. I guess I should somewhere provide a copy of cubicopp without the necessity of grunt.
updated all this but i didnt understand point 2, cubicopp code has less files too