[nodebb-plugin-emoji-extended] Emoji Extended

[baris]

That setting is supposed to show a warning page when you click a link that goes outside of nodebb. The relevant code is in ajaxify.js i think around here

https://github.com/NodeBB/NodeBB/blob/master/public/src/ajaxify.js#L260

[frissdiegurke]

@baris should be solved with gh#1775 then

ghost created this issue in NodeBB/NodeBB

closed fixed no href-attribute handled as external link #1775

[a_5mith]

Hey! I mean in user settings, not the ACP, there's an option in there to open external links in a new tab. But seems similar to the bug you've just found, will update and see if it fixes.

[frissdiegurke]

@a_5mith yup, works all fine now even if both options are enabled, thanks for report

[frissdiegurke]

since there have been major changes I bump this topic now:

The new version 0.3.0-1 includes my emoji-parser dependency which manages the emoji images to stay up-to-date besides other minor improvements (like the long-awaited : within alt-tags...)

Thanks to @julian it should be compatible with the new NodeBB version 0.5.0 as soon as it arrives

Since the movement from emoji-images to my self-written emoji-parser is a major change, please notice me about bugs that may ocur

[esiao]

@frissdiegurke
Not related to this new version since I have the problem since the 2.x.x one but the Emoticons are not displaying (broken image) and in my console there's this error

GET http://localhost/plugins/nodebb-plugin-emoji-extended/images/frowning.png net::ERR_CONNECTION_REFUSED 

I don't know if it's a misconfiguration of wamp by my side or an issue with the plugin.

[frissdiegurke]

@esiao said:

@frissdiegurke
Not related to this new version since I have the problem since the 2.x.x one but the Emoticons are not displaying (broken image) and in my console there's this error

GET http://localhost/plugins/nodebb-plugin-emoji-extended/images/frowning.png net::ERR_CONNECTION_REFUSED 

I don't know if it's a misconfiguration of wamp by my side or an issue with the plugin.

what does base_url within your config.json contain? I guess it's like "base_url": "http://localhost". If so please put your public domain-name there

[esiao]

@frissdiegurke
Yes it's localhost but since I'm using it on localhost that's normal. I may need to create a vhost and change the config after.

[frissdiegurke]

@esiao said:

@frissdiegurke
Yes it's localhost but since I'm using it on localhost that's normal. I may need to create a vhost and change the config after.

localhost should work if you browse the board from the same machine (or virtual machine). In this case the emoji should get displayed correctly

[esiao]

@frissdiegurke
I agree but that's not what is happening.
The url taken is http://localhost/plugins/nodebb-plugin-emoji-extended/images/grinning.png
And if I try to open it it's a 404.
I think that's because of wamp. It may expect an adress like http://localhost/Github/NodeBB/node_modules/nodebb-plugin-emoji-extended/emoji/grinning.png because there's no plugins folder in my www.
So creating a vhost may fix this. I'll try and keep you updated.

[esiao]

@frissdiegurke
And this is not working
GET http://gg.dev/plugins/nodebb-plugin-emoji-extended/images/frowning.png 404 (Not Found)
gg.dev is my vhost.

[frissdiegurke]

0.3.1-1

• Some better mappings like :D to instead of (which gets mapped by xD now) implemented.
• Also copying a emoji now copies the original text (shortens instead of :...: when used).
• The title-attribute also contains the shortens (or the name of the emoji without : if no shorten got used).
• Fixed code-exclusion for code-tags containing attributes.
• Minor fixes.

0.3.1-2

• Added button to open dialog with emoji-overview to composer

@julian / @psychobunny I suggest an update for this board

[esiao]

@frissdiegurke Yeah that's good news

[A Former User]

@frissdiegurke, excellent updates I can't wait to put them into effect!
Now, if only there was a way to cap the number of emojis users put in their posts

[baris]

Updated to 0.3.1-2, that modal with so many emojis (drunk)

[Hưng Thành Nguyễn]

@frissdiegurke nice plugin but it has a bug which make the site crashed in internet Explorer 11
Below is the detail.
It make the site looks crap and crash the shoutbox plugin and many others.

[frissdiegurke]

ah, seems like I shouldn't use the browser-functions to create promises I'll change to jQuery-Deferred later this day

[Hưng Thành Nguyễn]

@frissdiegurke yeah, waiting for the new one. I just test all around the site to figure out what made the site crashed

[frissdiegurke]

@Hưng-Thành-Nguyễn It should be solved now (0.3.1-3), please test it since I don't have any IE where I could test appropriate
But since I'm using jQuery.Deferred() now it shouldn't cause any more trouble with IE.

@Developers (interesting that it got autocompleted :)) please update. Thanks!

Sorry for trouble

[Schamper]

I was just about to complain about this is well