• Home
  • Categories
  • Recent
  • Popular
  • Top
  • Tags
  • Users
  • Groups
  • Documentation
    • Home
    • Read API
    • Write API
    • Plugin Development
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
v3.5.1 Latest
Buy Hosting

Possible bug? Deleted Posts listed

Scheduled Pinned Locked Moved NodeBB Development
13 Posts 7 Posters 3.9k Views
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • jongarrisonJ Offline
    jongarrisonJ Offline
    jongarrison Plugin & Theme Dev
    wrote on last edited by
    #1

    I sometimes see something like this:

    0_1446148084477_Screen Shot 2015-10-29 at 12.46.38 PM.png

    Is this a bug? Feature?

    PitaJP 1 Reply Last reply
    0
  • PitaJP Offline
    PitaJP Offline
    PitaJ Global Moderator Plugin & Theme Dev
    replied to jongarrison on last edited by
    #2

    @jongarrison it's expected behavior

    1 Reply Last reply
    0
  • julianJ Offline
    julianJ Offline
    julian GNU/Linux
    wrote on last edited by
    #3

    Intentional. If we hid them from the list, pagination would get all messed up (long story).

    To remove the post completely, purge.

    1 Reply Last reply
    0
  • jongarrisonJ Offline
    jongarrisonJ Offline
    jongarrison Plugin & Theme Dev
    wrote on last edited by
    #4

    Ok, good to know.

    1 Reply Last reply
    0
  • psychobunnyP Offline
    psychobunnyP Offline
    psychobunny
    wrote on last edited by psychobunny
    #5

    Actually, @julian (actually @baris, likely) can I get the long story for this one? 😛 I feel like I already know the reason why, but not sure why we can't height: 0; overflow: hidden for that.

    I'm probably going to get an answer that makes me facepalm but I might as well ask.

    EDIT: my CSS recommendation is only for users who aren't able to restore that topic of course

    PitaJP henrywrightH 2 Replies Last reply
    0
  • PitaJP Offline
    PitaJP Offline
    PitaJ Global Moderator Plugin & Theme Dev
    replied to psychobunny on last edited by
    #6

    @psychobunny you would actually need

    .category > ul > li.deleted {
      min-height: 0;
      height: 0;
      padding: 0;
      overflow: hidden;
    }
    
    1 Reply Last reply
    1
  • psychobunnyP Offline
    psychobunnyP Offline
    psychobunny
    wrote on last edited by
    #7

    My thoughts exactly. Better than having a "this is deleted!" post.

    @baris pinging you for your two cents

    barisB 1 Reply Last reply
    1
  • henrywrightH Offline
    henrywrightH Offline
    Henry Wright
    replied to psychobunny on last edited by
    #8

    @psychobunny said:

    but not sure why we can't height: 0; overflow: hidden for that.

    My SEO buzzer is going off! Would Google frown on that?

    1 Reply Last reply
    0
  • barisB Offline
    barisB Offline
    <baris> NodeBB
    replied to psychobunny on last edited by
    #9

    @psychobunny we display them so we don't have pages with missing topics when you use pagination.

    1 Reply Last reply
    1
  • julianJ Offline
    julianJ Offline
    julian GNU/Linux
    wrote on last edited by
    #10

    ☝ That. Because we store the deleted state of a topic in the topic hash itself, and individual users can or cannot see the topic/post depending on their privilege level, we have to filter the topics after retrieving the tids from the database, and if the user happens to not be able to see some of them, then a page with 20 topics suddenly only has 18 (or less).

    Basically, this was a non-issue until we got spammed, and then when we deleted 20-40 spam topics, then entire categories would simply be empty because the "page" had only deleted topics.

    wktangW 1 Reply Last reply
    0
  • jongarrisonJ Offline
    jongarrisonJ Offline
    jongarrison Plugin & Theme Dev
    wrote on last edited by
    #11

    I think I understand the reasons related to scalability for leaving the deleted posts, but how about some sort of throttled auto purge functionality? This way a NodeBB site wouldn't be over taxed by a massive number of deletions, but would still have deleted posts removed from view in a timely way.

    1 Reply Last reply
    0
  • wktangW Offline
    wktangW Offline
    wktang
    replied to julian on last edited by
    #12

    @julian said in Possible bug? Deleted Posts listed:

    if the user happens to not be able to see some of them, then a page with 20 topics suddenly only has 18

    Does this apply to infinite scrolling as well?

    julianJ 1 Reply Last reply
    0
  • julianJ Offline
    julianJ Offline
    julian GNU/Linux
    replied to wktang on last edited by
    #13

    @wktang Yes, this does apply to IS as well.

    1 Reply Last reply
    0

Copyright © 2023 NodeBB | Contributors
  • Login

  • Don't have an account? Register

  • Login or register to search.
Powered by NodeBB Contributors
  • First post
    Last post
0
  • Home
  • Categories
  • Recent
  • Popular
  • Top
  • Tags
  • Users
  • Groups
  • Documentation
    • Home
    • Read API
    • Write API
    • Plugin Development