Embedded polls in nodeBB

[Schamper]

@exodo you should consider making a pull request.

[Tanguy Bodin-Hullin]

@exodo @yariplus @rbeer @Schamper Thank you for your help. I'm full of hope now !!

[yariplus]

@rbeer said:

@yariplus
Have you started working on it, yet?

Yeah, It's working for me on 0.8 and 0.9 though, I only made a few minor changes. So I just upped the compatibility string.

[whitts]

This plugin seems to work fine on 0.9 but the dialog for creating it looks a bit strange. Please see attached. Thanks

[yariplus]

@whitts Just missing a translator call.

PR'd @Schamper https://github.com/Schamper/nodebb-plugin-poll/pull/36

yariplus created this issue in Schamper/nodebb-plugin-poll

closed Missing translator call. #36

[whitts]

@yariplus

Is this to do with locale? or something different entirely? Is it something i can edit in the js files? Thanks

[yariplus]

@whitts Nothing to do with locale. Those [[ ]] strings are translation keys, but the js just never runs the translator. Kinda my fault because I was the one who added all the translation keys.

I would wait till @Schamper updates the package instead of editing the js yourself.

[julian]

If there is a working fork I would encourage @Schamper to add that author as contributor to his plugin.

Just a thought

[yariplus]

@julian The fork tree looks kinda a mess tbh. A lot of them look like people applying patches that were already on other forks. The big ones are the Chinese and German and Spanish translations that are just sitting there without a pr.

[Schamper]

Fix published to npm as version 0.1.3.

I'm determined to merge PR's and publish new versions as soon as I can.

[whitts]

@Schamper

I just updated and it looks good now - thanks . What date/time format is the "Automatically end poll" field supposed to be in? Would it be easier to add a datepicker?

Thanks for your help on this.

[whitts]

just tried the date field and it worked but it doesnt look like you can view the results after its finished:

Thanks