@julian Right, I understand. It just makes it difficult to migrate from a more traditional forum like phpBB (which is the most, or perhaps second-most, used forum software today). I think making it easier to migrate from phpBB's format could only help nodeBB gain more ground 🙂 Here is the github issue I opened a couple weeks ago. It was closed, though I hope we can reopen it. I'm more than willing to contribute. Let me know if there's anything I can do.lots0logs created this issue in NodeBB/NodeBB closed Posts from child categories are not shown on the home page. #2549
Often I'll remove a class or id only to find a little later that I've broken some functionality.
We're attempting to transition to using @psychobunny's "components" system. You'll see parts of it throughout the site, where we used to have
class="something", now has
If you find references to a class that serve no purpose, they are probably referenced via theme and/or client-side JS, and should probably be moved to a component.
For this case, I'd file 1 issue with all of the ones you find, not one per issue
@julian The move to custom data attributes makes complete sense. The only thing I'd point out is their naming (and I think @psychobunny has mentioned this himself in the past). As far as I know, in order for custom data attributes to be valid, they should be prefixed with
data-. So for example it should be
Preaching to the choir, buddy. @psychobunny flies by his own rules
I'd code in an update for this, although it's just a matter of finding the time.
@julian how about running one huge find and replace job? Wait... on second thoughts maybe not ha