NodeBB Vanilla - Small bug

Bug Reports
  • Add this to the header.less in Vanilla

    #notif_dropdown:before {
    	content: '\f0a2';
    	display: inline-block;
    	font-family: FontAwesome;
    	font-style: normal;
    	font-weight: normal;
    	line-height: 1;

    When using FontAwesome without the specific fa class, you could most certainly break the style with inconsistencies.

    When you're manually manipulating font icons using your own class with :before you should always reset the position by using:

    font-style: normal;
    font-weight: normal;
    line-height: 1;

    Exceptions on when you're styling the icon itself

    In this case, when you hover on the notification icon AND there's a background added to it, it doesn't match with the other icons beside it and bleeds out the header by a single pixel.

    Screen Shot 2013-12-31 at 7.27.29 PM.png

  • Wow, good work @trevor, and good eye. Something like that is pretty damn easy to miss.

    Tag @psychobunny

  • Yeah it annoyed me as I noticed it and did almost everything else to fix it and failed for 3 hours, two days later I took another shot and it was like a duh moment.

Suggested Topics

  • 0 Votes
    16 Posts

    Now it appears to be solved

  • 0 Votes
    6 Posts

    I installed v0.6.x-dev which may have been the cause. Also, I may not have ran "npm install -g forever" in the nodebb directory. I'm not sure if this would make a difference?

    Forever is working fine with v0.5.4 and installation using "npm install -g forever" in the nodebb directory.
    I execute Forever using this cron job.
    @reboot cd /home/nodebb && forever start app.js

  • My nodebb can't register

    Bug Reports
    0 Votes
    9 Posts

    @Lingyong-Zhang what's the rest of that error, make sure your redis is greater than 2.6.0.

  • 0 Votes
    5 Posts

    Here is the full log :

    Notif Obj function (cutoff) { if (process.env.NODE_ENV === 'development') {'[notifications.prune] Removing expired notifications from the database.'); } var today = new Date(), numPruned = 0; if (!cutoff) { cutoff = new Date(today.getFullYear(), today.getMonth(), today.getDate() - 7); } var cutoffTime = cutoff.getTime(); async.parallel({ "inboxes": function(next) { db.getSortedSetRange('users:joindate', 0, -1, function(err, uids) { if(err) { return next(err); } uids = { return 'uid:' + uid + ':notifications:unread'; }); next(null, uids); }); }, "expiredNids": function(next) { db.getSetMembers('notifications', function(err,nids) { async.filter(nids, function(nid, next) { db.getObjectField('notifications:' + nid, 'datetime', function(err, datetime) { if (parseInt(datetime, 10) < cutoffTime) { next(true); } else { next(false); } }); }, function(expiredNids) { next(null, expiredNids); }); }); } }, function(err, results) { if(err) { if (process.env.NODE_ENV === 'development') { winston.error('[notifications.prune] Ran into trouble pruning expired notifications. Stack trace to follow.'); winston.error(err.stack); } return; } async.eachSeries(results.expiredNids, function(nid, next) { db.sortedSetsScore(results.inboxes, nid, function(err, results) { if(err) { return next(err); } // If the notification is not present in any inbox, delete it altogether var expired = results.every(function(present) { return present === null; }); if (expired) { destroy(nid); numPruned++; } next(); }); }, function(err) { if (process.env.NODE_ENV === 'development') {'[notifications.prune] Notification pruning completed. ' + numPruned + ' expired notification' + (numPruned !== 1 ? 's' : '') + ' removed.'); } }); }); } D:\nuitInfo2013\forum\node_modules\mongodb\lib\mongodb\connection\base.js:242 throw message; ^ TypeError: undefined is not a function at Object.Notifications.init (D:\nuitInfo2013\forum\src\notifications.js:16:38) at D:\nuitInfo2013\forum\app.js:126:21 at D:\nuitInfo2013\forum\src\upgrade.js:26:4 at D:\nuitInfo2013\forum\src\database\mongo.js:309:4 at D:\nuitInfo2013\forum\src\database\mongo.js:342:4 at D:\nuitInfo2013\forum\node_modules\mongodb\lib\mongodb\collection\query.js:147:5 at Cursor.nextObject (D:\nuitInfo2013\forum\node_modules\mongodb\lib\mongodb\cursor.js:733:5) at commandHandler (D:\nuitInfo2013\forum\node_modules\mongodb\lib\mongodb\cursor.js:713:14) at D:\nuitInfo2013\forum\node_modules\mongodb\lib\mongodb\db.js:1806:9 at Server.Base._callHandler (D:\nuitInfo2013\forum\node_modules\mongodb\lib\ mongodb\connection\base.js:442:41)
  • 0 Votes
    10 Posts

    @planner Glad it worked out okay 🙂