Can I have a plugin send notifications that are not topic related?

[baris]

Does it ajaxify to admin/plugins/approval? It should do a cold load, if not we should fix that.

[pichalite]

@baris It does not do a cold load. This is what it looks like when I click on the notification.

[baris]

Sounds like notifications need a way to open the link in a new tab.

[PitaJ]

@baris you should detect whenever anything is going to /admin/... and automatically open it in a new tab.

[julian]

@pitaj @pichalite gh#2849

julianlam created this issue in NodeBB/NodeBB

closed Ajaxifying to an ACP page should conduct a cold load #2849

[pichalite]

@julian one problem. when I click on the notification, it's opening the same link in current tab and in a new tab.

[PitaJ]

@pichalite looking at the code, that shouldn't be happening. Hmmm...

[baris]

Should be fixed in https://github.com/NodeBB/NodeBB/commit/ca31ac882ca1177afdfb077adf4235c5c48924d0

0 barisusakli committed to NodeBB/NodeBB

added return true/false

[pichalite]

@baris doesn't seem to be fixed. Still same issue.

[julian]

Is the relevant code in public/src/ajaxify?

[baris]

@pichalite Try with https://github.com/NodeBB/NodeBB/commit/f89741636cdad244d38bf2c8dca52054f65c335c

Let me know if that works.

0 barisusakli committed to NodeBB/NodeBB

return false to prevent default

[pichalite]

@baris no luck.

yes @julian the relevant code is in public/src/ajaxify

FYI I'm on latest NodeBB master, vanilla & lavender

[baris]

Can you try again on latest.

[pichalite]

@baris works now, thanks.