Socket io issue?

[julian]

@a_5mith said:

@Julian, aand the smilies are broken again.

You were saying...? XD

[a_5mith]

@julian Is this an update to the smilies plugin or NodeBB itself?

[julian]

NodeBB actually haha... was a bug I introduced yesterday.

[a_5mith]

@julian said:

NodeBB actually haha... was a bug I introduced yesterday.

I'm shocked. Was the Home link in the Breadcrumb you too?

[Normando]

@julian said:

@Normando Give the latest commits a go Socket.IO 1.0 is merged in, undergoing testing at the moment.

Can I merge in my 0.5.5 these commits for testing?

https://github.com/NodeBB/NodeBB/commit/d544b19220820cc8cfb0aa7c4903b47413a536bc

https://github.com/NodeBB/NodeBB/commit/647b15c7efe4c22c519db29661e0c25f675203f1

0 barisusakli committed to NodeBB/NodeBB

set path on socket.io server

0 barisusakli committed to NodeBB/NodeBB

Merge remote-tracking branch 'origin/master' into socket.io1.x

[baris]

@Normando was your forum in a sub folder? The first commit should fix the problem with socket.io 1.0x and subfolder installs.

[julian]

@a_5mith Oh boy, where did the breadcrumbs go...

[a_5mith]

@julian Nowhere, I think that's 80% the issue.

[julian]

They're back

Edit: What... now the "home" button doesn't work.

[a_5mith]

@julian That was what I was trying to tell you.

[julian]

Now we're done.

[Normando]

@baris said:

@Normando was your forum in a sub folder? The first commit should fix the problem with socket.io 1.0x and subfolder installs.

No baris, the forum is not in a subfolder. So can I apply the first commit or the second one? Or both?

Thanks

[julian]

@Normando You should stick to letting git handle the changes. No need to modify any files on your own.

If you're on master branch, a git pull followed by a npm install and ./nodebb upgrade should do it. As always, back up your NodeBB database first.

[Normando]

@julian I am not on master branch. I am on 0.5.x branch. My current version is 0.5.5.

[julian]

You'll have to upgrade to the master branch if you want to use socket.io 1.0, although we may be launching v0.6.0 shortly...

[Normando]

Fixed!!! Thanks!