But lemmie tell you writing Javascript inside an HTML widget is a Pain In The Neck.
0.6.0 Breaking Changes
-
Ideally we should change those to be objects as well so we don't have to do this amount of breaking changes in the future. Ie stuff like
plugins.fireHook('action:post.delete', pid);
Should be
plugins.fireHook('action:post.delete', {pid: pid, uid:uid});
There aren't alot of these as far as I know so I will make a list and let you all know about the changes here when they happen.
-
@baris I thought we were leaving the single-argument hooks as-is for now? I don't mind changing it, though... may as well get it all over in one go.
-
-
Recent Replies widget is deprecated please switch over to Recent Posts widget if you were using it. It has the same functionality.
-
Updated with link to config changes. https://community.nodebb.org/topic/3392/config-json-updated-base_url-and-relative_path-no-longer-exist
-
I'm confused, are all hooks being updated to use a single data object? in particular
plugins.fireHook('action:topic.delete', tid);
?PS. is there a set date you guys are aiming for the 0.6.0 release?
-
Yes, all hooks use only a single param now.
No more
plugins.fireHook('someHookName', a, b, c, d, callback);
Not all the params are an object though like the one you posted.
-
@baris make every. Single. Hook. Have an object param. That way we will never ever need to worry about breaking changes again!
Seriously: consistency is the best possible thing you can have with software
-
Yeah agreed will try to get that in for 0.6.0
-
ohh ok thanks for making it clear
-
Updated with header.tpl changes, relevant thread https://community.nodebb.org/topic/3488/header-tpl-changes