Email notification for new chat message not working for some users

[razibal]

Hopefully someone can point me in the right direction to debug an issue with some users not getting notified of new chat messages via email. Where would I be able to see the logic used to determine the notifications? Is this managed in src/notifications.js?
Just to be clear, the users in question do have their settings set to "Notifications & Email" for receiving chat messages. Do the "Do not Disturb/Invisible" statuses impact email notifications?

Thanks!

[baris]

It's here https://github.com/NodeBB/NodeBB/blob/master/src/messaging/notifications.js#L60-L64. If the user is considered online(aka performed an action in the past x minutes) then the notification isn't sent.

Maybe it might make sense to change this to be a more real time check using socket.io online status.

[razibal]

I think it might help as it appears that the users not getting notified are being identified as online despite having logged off

[crazycells]

@baris said in Email notification for new chat message not working for some users:

aka performed an action in the past x minutes

what is the default value for this time?

[baris]

I think it is 30 minutes on a new install, it can be configured in the ACP.

[baris]

@razibal I've changed how this works on the develop branch, instead of checking the online status it will check if the user has already read the chat, this should cause an email to be sent to all users who haven't seen the chat message.