awesome theme
Solved v2.0 custom persona theme mobile problems
-
Ive just updated to v2.0, and now the navigation/user menus don't work on mobile?
here's my site:
support.sweetpproductions.comand, here's the repo for my theme, all I am doing is adding custom css, with also some custom javascript:
github.com/sweetppro/nodebb-theme-sweetpcan anyone see anything obvious I am doing wrong?
-
I forgot to mention, I am using the Paper skin
-
@sweetp very nice theme
-
@sweetp they seen to work fine on mobile for me
-
@phenomlab this is so odd....
I use a VPN, and the menus weren't working via VPN.
as soon as I disabled it, removed the cache and reloaded... the menus worked.thanks for the second set of eyes
-
@Varun-Ganesh-D thx
-
actually the bug still happens.
specifically if I refresh the homepage.
(macOS 12.3.1, iOS 15.4.1)when I add a get request local override for this script:
2286.ab7f70f35005dbd282bd.min.js
I don't see the issue
This script is being block on page reload, and a bunch of other scripts (one of which is for the mobile menus I guess) aren't loading...
I don't know how to debug this, or have any idea how to fix.It also occurs using the defualt NodeBB Persona theme. I havnt tried any others.
here's a video:
-
-
@sweetp ok so I have a fix, in the file:
nodebb-theme-persona/public/persona.js
on lines 13-16, commenting out the event handler
//$(window).on('action:app.load', function () { setupTaskbar(); setupMobileMenu(); //});
Now the menus show as they should every time.
Theres probably a better way...
I'll post a bug report to GitHub -
@sweetp I added a PR here:
https://github.com/NodeBB/nodebb-theme-persona/pull/548 -
-
updated PR here:
https://github.com/NodeBB/nodebb-theme-persona/pull/550