My expandy width button has vanished

General Discussion
  • Only just noticed that the hamburger button in the bottom right has vanished. Not entirely sure why or how, I'm on latest, but I've not seen it for a while. Master, vanilla 0.0.32 and lavender 0.0.37, I've disabled all the plugins, changed the theme back and forth.

    I'm suspecting aliens or something. But I'm not sure.

  • rofl, hamburger button

    works fine over here on this site, and its fairly latest, so not sure what's going on (unless a very recent commit broke it)

  • @psychobunny

    Yeah I'm not sure either. I've not seen it for a few commits, I'd imagine it's on my end, but other than plugins and the theme, I'm not sure if I've changed anything else.

  • Works over here when you hover anywhere on the bottom right corner. 👍

    Screen Shot 2014-05-24 at 3.04.04 PM.png

  • @trevor Seems I've broken it then. 😆

  • It often ends up obscuring the reply button too.
    Screen Shot 2014-05-29 at 11.06.05 PM.png

    I think this is an option that should be in settings, not hovering around as a fixed element constantly (purely IMO) 😉

    Also, users are starting to associate the hamburger with "menu", not changey-widthy. It's not an expected behavior.

  • @Trev I've noticed this, the icon is normally associated with menu. Arrows-h would be a better option here. Or even chevron left and right, then swap them when narrowing.

  • gh#1599 (derpity derp space filling)

  • Wow, nice to see this already fixed. It's no longer obscuring my reply button. 🙂

    I'm curious what the reasoning was behind having this control always present. Would it not be more sensible to set a max-width on the container as the default? Edge-case users who have a strong preference for extra-wide content could still find the setting elsewhere.

    Extra "position: fixed" elements can lead to slowdowns or glitches with scrolling on mobile devices (and small FPS drop on some desktop browser engines). There's also readability issues when paragraphs end up very long. It could detract from an otherwise very positive impression of the software when people hit the site with maximized browser windows.

    The same issue is present with the editor, as it always scales to 100% viewport width, which is only effective up to a certain threshold before it becomes a liability.

    Not trying to tear apart the layout, but I've been working in UI/Interaction Design for a long time, so can be a bit picky with these things 🙂 I'm happy to offer advice if anyone wants to hear it. I think NodeBB is great and see huge potential with the platform.

  • Personally I always use NodeBB at a fixed layout or make my window 1280px wide, the fluid layout is cool but it makes reading posts a pain when the resolution is 2560px wide. The reason the toggle is a fixed element was to allow users to quickly switch between the two. Also it is only available on the lavender theme, vanilla is always fixed.

  • @baris said:

    Personally I always use NodeBB at a fixed layout or make my window 1280px wide, the fluid layout is cool but it makes reading posts a pain when the resolution is 2560px wide. The reason the toggle is a fixed element was to allow users to quickly switch between the two. Also it is only available on the lavender theme, vanilla is always fixed.

    Why would they need to quickly switch between the two? I'm not convinced the average user even has a preference, they simply expect the content to be readable without requiring any thought or intervention. The fixed control only serves to add clutter/confusion in an area where they're scanning for action-items like submit or reply.

  • @Trev @baris

    From the limited feedback I've gotten, it may confuse users. (or rather, one test user) One user clicked on it perhaps by accident, got sick of the extra-wide screen on a large monitor, and closed the tab.

  • Yeah it isn't something that most user would use, and its pretty easy to disable/hide if you want. Just a .resizer {display: none;} to your customize tab 😉

  • @baris
    It's looking like we'll be forking NodeBB to rebuild the front-end in Angular, so we'll probably have some bigger challenges to tackle first 🙂 We've started initial exploratory work today/yesterday. All looks very positive so far.

  • That's awesome! Let us know how it goes. 🙂

  • @baris
    Of course. Nothing is a definite schedule yet, but we're trying to progress as quickly as possible. We've already been developing an in-house solution that bridges our Angular/Node/Redis stuff to XenForo's backend, but I'd somehow never heard of NodeBB. It makes far more sense to migrate our data and build on NodeBB instead.

    We'll be sharing back everything we can. The only parts staying private will be styles/SASS and anything specific to our layout look & feel. Even then, the aim would be to release generic versions of enhancements.

  • Looking forward to seeing what you got going with angular. I originally built templates.js as a competitor to existing templating frameworks

    From my results I've seen that templates.js performs a ton faster than handlebars and ember, although I never benchmarked against angular. Give me a shout with your progress, I know early days we were definitely thinking about abstracting the templating engine, so if you make some progress here I'm sure there will be some people who are interested 🙂

    As far as automated data-binding is concerned, both ember and angular are definitely miles ahead of templates.js, but we haven't been hurting in that department for NodeBB. Preliminary testing has shown that at least, templates.js performs faster than ember.js when it comes to that aspect 🙂

    Totally biased stuff going on right now, hopefully we can get a few more people interested in the framework and then we can get some proper numbers going on 🙂 Glad to see someone trying to build something completely different 😄

  • @psychobunny
    Performance and perceived speed is priority one for us too, so I hope Angular does well. I suspect it will. Our Node/Angular guy is very up to date with current best practices and techniques, so that should help a lot.

  • great! whatever you guys can contribute back would be greatly appreciated 🙂

    EDIT: If you guys need a hand anywhere, feel free to send us a message. I'd like to see NodeBB support multiple front-end frameworks, so anything I can do to bump that progress along - you know who to reach out to 😉


Suggested Topics


  • 0 Votes
    10 Posts
    770 Views
  • 0 Votes
    6 Posts
    3253 Views
  • 0 Votes
    4 Posts
    939 Views
  • New topic button

    General Discussion
    1 Votes
    4 Posts
    2199 Views
  • 0 Votes
    3 Posts
    1427 Views