custom page template's javascript in wrong place?

[Bejan]

I created a new theme (from persona) with a new testpage.tpl.
After a nodebb build, I get this message in devtools:

GET https://mydomain.com/assets/src/client/testpage.js?v=6a0hef49d1f 404 (Not Found)

And in fact, no testpage.js exists at that (nginx) location. There is one in build/public/templates/testpage.js however. But it's in the wrong place for the server to find it for the browser's request.

Is this how it's supposed to be? How can this be fixed?

Thanks any helpful feedback.

[baris]

Take a look at https://github.com/NodeBB/nodebb-plugin-quickstart/commit/d7eeafaf242eeb448af047ef4d2bfc87075887e7.

The quickstart plugin now has a sample for creating a new page along with the clientside javascript that's loaded when the user navigates to that page.

When you create a new page/template nodebb automatically tries to load a requirejs module for that page from assets/src/client/<templateName>.js The error you see is because you are missing the js file.

[Bejan]

@baris Thank you! Just started looking. Maybe I should switch from a theme to a plugin then, right now? Or should I just port the plugin functionality you merged into the theme?

[baris]

Doesn't really matter, it's up to you. If the plugin is closely tied to the theme functionality keep it in the theme. If the plugin can be used with other themes make it a separate nodebb plugin.

[Bejan]

@baris Thank you. Very valuable feedback. Ought the theme quickstart to be kept in sync with the plugin quickstart?