Your browser does not seem to support JavaScript. As a result, your viewing experience will be diminished, and you may not be able to execute some actions.

Please download a browser that supports JavaScript, or enable it if it's disabled (i.e. NoScript).

1.12.0 Breaking Changes

NodeBB Development

1

2

1126

Log in to reply

baris Admin NodeBB last edited by baris
We are dropping support for NodeJS v6.x in 1.11.0+.

Please see the following issues for breaking changes to plugins and themes.

https://github.com/NodeBB/NodeBB/issues?utf8=✓&q=is%3Aissue+milestone%3A1.12.0+label%3A"breaking+change+(themes)"+
https://github.com/NodeBB/NodeBB/issues?q=is%3Aissue+milestone%3A1.12.0+label%3A"breaking+change+(plugins)"

If you have plugins that are affected, please update your plugin and add the below to your package.json
```
"nbbpm": {
   "compatibility": "^1.12.0"
}
```
Reply Quote 2
1 Reply Last reply
baris Admin NodeBB last edited by

Theme Breaking Change
https://github.com/NodeBB/NodeBB/pull/7109

barisusakli created this issue in NodeBB/NodeBB

closed Category watch state #7109
Reply Quote 2
1 Reply Last reply

Suggested Topics

MongoDB index changes
NodeBB Development • mongodb • • baris

3

0
Votes

3
Posts

1254
Views

It's not a must, but doing it will save quite a bit of space when your forum gets large.
How to see changes on browser asap when I've just change some code in my theme or plugin?
NodeBB Development • • thuanpq.io

6

0
Votes

6
Posts

1905
Views

N

@pitaj said in How to see changes on browser asap when I've just change some code in my theme or plugin?: grunt thank you so much brother
1.7.0 Breaking Changes
NodeBB Development • breaking 1.7.0 • • baris

3

2
Votes

3
Posts

3778
Views

Due to changes introduced to loading javascript assets in 1.7.0, using jquery in widgets requires waiting for the page load event. Sample widget for 1.7.0+ if (window.jQuery) { doStuffThatUsesJquery(); } else { window.addEventListener('load', doStuffThatUsesJquery); }
When are you planning to release 1.10.2?
NodeBB Development • • Dravere

6

0
Votes

6
Posts

465
Views

Oh, we are actually supposed to be merging the version bump back into master, let me do that now.
1.10.0 Breaking Changes
NodeBB Development • breaking 1.10.0 • • baris

3

1
Votes

3
Posts

2032
Views

Hi, I think I have discovered another breaking change that you didn't mention, though it is probably super-niche. This commit: https://github.com/NodeBB/NodeBB/commit/ec91ef1c644044bba44198b031913655e784b4bb broke our custom SSO plugin. The result was that after successfully logging in our external identity provider and being redirected to our Forum's callback endpoint, I was ending up not logged in (the button in the header still said "Log in") and stuck on /register/complete roadblock. It looked like our Passport strategy verify callback, that parses output from the identity provider and fetches user data via OAuth2 was not invoked at all. It turns out that the changes in this commit don't play well together with passport-oauth2 (https://github.com/jaredhanson/passport-oauth2) internal ability to protect against CSRF (which we were using). This strategy was already using state parameter to pass its own CSRF token. I don't have more time to investigate but I suspect things shipwrecked when NodeBB overwrote the state parameter with its own CSRF token. Turning off passport-oauth2 internal CSRF protection (by removing state: true from its options) fixed the issue. 0 julianlam committed to NodeBB/NodeBB closes #6553

| |

Copyright © 2020 NodeBB | Contributors