Skin display issue (noskin)

[doekia]

Ok things get returned to normal but I suspect the is some security at stake here.
Been the only admin I know that nothing get changed from the BO.
User settings was on allowing them to change their skin.
At some point the only scenario I can think of, it that some user action has invaded the default settings.

I have disabled user skin change.

[PitaJ]

Yes it's an issue caused by this:

https://github.com/NodeBB/NodeBB/issues/6306

[teh_g]

Phew, glad it wasn't just me. Thanks for the quick reply @PitaJ

[torn2]

Dumb question, but how does this stop working if we haven't made any changes/upgrades on our side?

[PitaJ]

@torn2 the skins are loaded from an external CDN. It automatically loads the latest version.

Unfortunately some skins were released with the latest version being made for bootstrap 4.

[torn2]

@pitaj said in Skin display issue (noskin):

@torn2 the sounds are loaded from an external CDN. It automatically loads the latest version.

Unfortunately some skins were released with the latest version being made for bootstrap 4.

But we're running version 1.6.1 and haven't upgraded and the skins worked fine. About two days ago they suddenly broke???

[BuZz]

@torn2 because they referenced an external CSS which was updated to v4.0 (bootstrap) which broke existing skins that were built on v3.3.x

[trulore]

Thanks guys!

Changing the bootstrap url from "/latest" to "/3.3.7" in two places (src/client/account/settings.js and src/middleware/header.js) gave us an immediate fix to this problem.

And just random kudos for how easy it is to find and fix things in NodeBB. Definitely my favorite forum software!

[linuxlover]

Damn, I lost users because of this, first time I'm a little disappointed by NodeBB

Here is a quick fix for webmasters experiencing this persona skins issue

cd NodeBB-*
sed -i 's#bootswatch/latest#bootswatch/3.3.7#g' public/src/client/account/settings.js src/middleware/header.js
./nodebb build
./nodebb restart

Hope this helps

Edit: Sorry I might have been a little rude here, NodeBB rules of course, keep up the great work

[PitaJ]

Just FYI, you don't need to run manual changes. You can just git pull now that we've released a hotfix (as long as you're on v1.7.x).

[linuxlover]

@pitaj I haven't installed NodeBB with git sadly
I'd really like to know how can I start using git on a non git install, if that's possible!

[PitaJ]

@annihil that's a good question. What version are you on now?

[linuxlover]

@pitaj Latest, 1.7.4
I'm using this script to update

cd NodeBB-1.X.X
./nodebb stop
cd ..
redis-cli save
sudo cp /var/lib/redis/dump.rdb ~/dump-1.X.X.rdb
wget https://github.com/NodeBB/NodeBB/archive/v1.X.Y.tar.gz
tar czf backup-1.X.X.tar.gz NodeBB-1.X.X
mv NodeBB-1.X.X NodeBB-1.X.Y
tar xf v1.X.Y.tar.gz
cd NodeBB-1.X.Y
npm update
./nodebb upgrade or ./nodebb build
./nodebb start

where X.X is the current version and X.Y is the newer version

but I would prefer to have just to git pull of course ^^

[PitaJ]

@annihil this should work, but definitely back up the whole nodebb folder and your database first.

To achieve this, we're going to do the following steps:

1. Initialize an empty git repository in the existing directory
2. Add the Github repository as a new remote on this local git repo
3. Fetch the data from the remote repo
4. Ensure that the local repo is equal to the remote
5. Switch to the correct branch locally

Okay, now here's the respective CLI commands:

$ git init
$ git remote add origin https://github.com/nodebb/nodebb.git
$ git fetch
$ git reset --hard origin/v1.7.x
$ git checkout v1.7.x 

Hopefully that works for you. It certainly helps that you're already on latest v1.7.x.

[linuxlover]

Thanks, it worked flawlessly