@baris Thank you. Very valuable feedback. Ought the theme quickstart to be kept in sync with the plugin quickstart?
Custom favicon not being shown
I just installed NodeBB and I uploaded a custom favicon, however it isn't showing.
I've tried the following:
Rebuilding and restarting NodeBB
Restarting the entire server
If I go directly to the URL where it was uploaded, it shows up fine, but it doesn't show up anywhere else.
How can I fix this?
Have you tried going to
your.site/favicon.ico? My guess is that it will probably show up.
That redirects me to /assets/favicon.ico?v=cqb8f9bnedm which doesn't show the favicon I uploaded
Here's the link to my site: https://forum.minnit.chat
You can try it there.
Here's the path where the favicon was uploaded: https://forum.minnit.chat/assets/uploads/system/favicon.ico?v=1517029307480
I decided to just do an nginx redirect to fix it, and that seems to work perfectly. Thanks anyway!
This is fixed in https://github.com/NodeBB/NodeBB/issues/6336
TLINDEN last edited by
@baris: I had the same issue and the patch fixes it for me. Hower, I'm unsure how to "officially" update. I'm currently on branch v1.7.x, which doesn't contain the fix. Therefore I patched the file manually.
Are you devs regularly merging such stuff to the v1.7.x branch so people just have to
git pullfrom time to time or how is the process here?
Sorry for the digression
We don't normally backport stuff into 1.7.x unless it is a security issue. You can either wait for the next release which is 1.7.6 or apply the patch like you did.
Xanthrop last edited by
Lodge this one under annoyances then for 1.7.x Glad I found this thread.