Update to 1.7.2 from 1.7.0 removed all code from Custom header

[fais3000]

Since the update to 1.7.2. We can't see our HTML and JS code in the Custom header anymore.

[PitaJ]

The JS code in the custom header should be moved to the Custom Javascript tab instead. If you had any other HTML, then it should have remained.

[suparomana]

@PitaJ I have exactly the same Problem. Custom Javascript is gone after updating to 1.7.3. Custom JS und header tab are empty. Is there a possibility to recover that code?

[julian]

Oh, that's really odd... the upgrade script should've copied the existing code over...

What happens if you check the database for customHTML and customJS in config hash?

Mongo:

db.objects.find({ _key: "config" }, { "customJS": 1, "customHTML": 1 });

[fais3000]

@julian and @PitaJ Both of these fields (customHTML and customJS) were empty.

[julian]

Then unfortunately it doesn't look as though the code is recoverable

Do you know roughly what kind of code you had there? It'd be helpful so we can fix any bugs/errors in the upgrade script.

[fais3000]

@julian Yes, i was afraid that would be the case. Anyways, my fault for not having them in version control.

So apart from Google analytics script, we were doing mostly cosmetic and UX changes on the persona theme based on the url segments. e.g if the composer page is loaded, we select a specific category as default. or things like having autosuggest (using the api plugin you wrote) on the search input field.

You can have a look at the website to have an idea http://definedictionarymeaning.com.

We were intentionally overwriting stuff in the custom header to avoid overwriting the tpl files. Because with new releases, updating template changes is quite tedious.

[julian]

Thanks @fais3000 -- once you have the code reconstructed, it would be helpful if you could share it with us for testing, but of course, it is up to you

[julian]

@fais3000 -- no need, I've found a data set that got wiped, so we'll get this fixed up. Sorry we cannot fix your forum's custom html though, it's gone

gh#6259

julianlam created this issue in NodeBB/NodeBB

closed generate-custom-html.js upgrade script wipes custom html #6259

[fais3000]

Good work @julian!