NodeBB process dying after upgrading to 1.7.0

Technical Support
  • Hi!

    After today upgrade to 1.7.0 we observe a significant increase in errors leading to process dying and being restarted.
    Seems to always be preceded by this stacktrace:

    23/11 14:30:39 [94] - error: TypeError: Cannot read property 'disabled' of undefined
    at /home/app/nodebb/src/controllers/composer.js:22:25
    at nextTask (/home/app/nodebb/node_modules/async/dist/async.js:5297:14)
    at next (/home/app/nodebb/node_modules/async/dist/async.js:5304:9)
    at /home/app/nodebb/node_modules/async/dist/async.js:906:16
    at /home/app/nodebb/node_modules/nodebb-plugin-composer-default/library.js:160:12
    at /home/app/nodebb/node_modules/async/dist/async.js:3861:9
    at /home/app/nodebb/node_modules/async/dist/async.js:421:16
    at iterateeCallback (/home/app/nodebb/node_modules/async/dist/async.js:928:24)
    at /home/app/nodebb/node_modules/async/dist/async.js:906:16
    at Immediate.<anonymous> (/home/app/nodebb/node_modules/async/dist/async.js:3858:13)
    at runCallback (timers.js:676:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)
    

    Would you care to take a look? Thanks!

  • https://github.com/NodeBB/NodeBB/commit/97ac4a2e8c800e61af303eb989d1e2709fe92688 If you are on 1.7.x branch please pull that update, this is already fixed on master and will be available on 1.7.1 soon.

  • Thanks! Pulling right now 🙂

    [EDIT] Seems to have solved it!


Suggested Topics


  • NodeBB 2.0 Upgrade Issues

    Unsolved Technical Support
    1 Votes
    17 Posts
    1k Views

    @baris @julian I've just found out that this problem goes much deeper. If you look at the general page in the ACP, all of the values are missing (but are there in the database). In addition, the email page does not allow any changes to be saved.

    Appears to be the same bug on page load

    586b69c7-bf48-4d73-a27b-177bfb90dcb5-image.png

  • 0 Votes
    3 Posts
    603 Views

    Your config looks fine, not sure why it is only reading from a single one.

    { find: "objects", filter: { _key: /user:/i, username: "admin" }

    This doesn't look like a query we do in core nodebb, do you have some plugins that run custom queries? This doesn't use the indexes properly should probably be

    { find: "objects", filter: { _key: /^user:\d+$/i, username: "admin" }

  • 0 Votes
    2 Posts
    859 Views

    You must run git pull before running ./nodebb upgrade.

  • 0 Votes
    7 Posts
    2k Views

    make sure you have port 80 and/or 443 open on your firewall. I see 80 is open (I get the "Welcome to Nginx" message). So now you need to make a few changes in your nginx config for it to redirect 4567 to your site on 80/443 (http/https), as currently it is set to the nginx page.

    The docs has a config you can use, just make the changes like Pitaj has suggested and for https, you will need a certificate. Lets-Encrypt is free

    **Edit to add: Don't forget to restart nginx to use the new config

  • 0 Votes
    15 Posts
    3k Views

    I am also running docker! Needed to mount both my nodejs and nginx volumes to the nginx container. It works good, as it should. Nginx for static feels good 😉